From mboxrd@z Thu Jan  1 00:00:00 1970
From: Holger Sunke <holger.sunke@posteo.de>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] Added i586/386 support for GO language required for
 node_exporter.
Date: Fri, 21 May 2021 08:56:18 +0000
Message-ID: <82c9782c-f69c-2e69-dbcc-e5975a7ec160@posteo.de>
In-Reply-To: <4D48B785-2B11-4844-A45F-FE0683CA13D7@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1561046625778515336=="
List-Id: <development.lists.ipfire.org>

--===============1561046625778515336==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,


Am 11.05.21 um 11:53 schrieb Michael Tremer:
> Hello,
>=20
>> On 7 May 2021, at 19:19, Holger Sunke <holger.sunke(a)posteo.de> wrote:
>>
>> Hello Michael,
>>
>>
>> Am 07.05.21 um 13:28 schrieb Michael Tremer:
>>> Hello Holger,
>>> Thanks for this patch, but I am afraid it doesn=E2=80=99t do exactly what=
 you intend to do.
>>>> On 6 May 2021, at 20:46, Holger Sunke <holger.sunke(a)posteo.de> wrote:
>>>>
>>>> ---
>>>> lfs/Config | 4 ++++
>>>> lfs/go     | 6 +++---
>>>> 2 files changed, 7 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/lfs/Config b/lfs/Config
>>>> index eadbbc408..4d0f2f00b 100644
>>>> --- a/lfs/Config
>>>> +++ b/lfs/Config
>>>> @@ -138,6 +138,10 @@ ifeq "$(BUILD_ARCH)" "aarch64"
>>>> 	GOARCH =3D arm64
>>>> endif
>>>>
>>>> +ifeq "$(BUILD_ARCH)" "i586"
>>>> +	GOARCH =3D 386
>>>> +endif
>>> This is fine.
>>>> +
>>>> ########################################################################=
#######
>>>> # Common Macro Definitions
>>>> ########################################################################=
#######
>>>> diff --git a/lfs/go b/lfs/go
>>>> index 6ebb37080..97effcb84 100644
>>>> --- a/lfs/go
>>>> +++ b/lfs/go
>>>> @@ -28,10 +28,9 @@ VER        =3D 1.15.4
>>>>
>>>> THISAPP    =3D go-$(VER)
>>>> DL_FILE    =3D go$(VER).$(GOOS)-$(GOARCH).tar.gz
>>>> -DL_FROM    =3D $(URL_IPFIRE)
>>>> +DL_FROM    =3D https://golang.org/dl/
>>>> DIR_APP    =3D $(DIR_SRC)/go
>>>> TARGET     =3D $(DIR_INFO)/$(THISAPP)
>>>> -SUP_ARCH   =3D x86_64
>>> This however enables Go for all architectures including aarch64 and armv5=
tel which is not what you intend.
>>> The correct solution would be to add i586 to the list of supported archit=
ectures.
>>> However, I would object to only add Go for i586 because you personally us=
e IPFire on this architecture (please not Adolf=E2=80=99s remarks on our sche=
dule to discontinue i586). We only build Go for x86_64 because the only packa=
ge that uses it is the Amazon SSM agent which is not relevant on any other ar=
chitecture. node_exporter seems to be a package that could in theory run on a=
ny architecture and I feel that we should not discriminate by only building s=
omething for one architecture because we do not want to test it on any of the=
 others.
>>
>> Not sure if I get you right, but finally I think I should change the Confi=
g to make "go" compile for _all_ architectures supported by ipfire as node_ex=
porter depends on it.
>=20
> Yes, that is correct. We aim to treat all architectures the same. Sometimes=
 that isn=E2=80=99t possible, but that isn=E2=80=99t the case here.
>=20
> Best,
> -Michael
>=20

Dou you have a list of all architectures supported by IPFire beyond=20
i586(legacy), aarch64(=3Darm64?), x86_64 and arm?

Kind regards

Holger
>>
>>> -Michael
>>>>
>>>> ########################################################################=
#######
>>>> # Top-level Rules
>>>> @@ -41,7 +40,8 @@ objects =3D $(DL_FILE)
>>>>
>>>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>>
>>>> -$(DL_FILE)_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
>>>> +go$(VER).$(GOOS)-amd64.tar.gz_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
>>>> +go$(VER).$(GOOS)-386.tar.gz_MD5 =3D 8d1c3539c88710273f61b0c810b7448c
>>>>
>>>> install : $(TARGET)
>>>>
>>>> --=20
>>>> 2.30.2
>=20

--===============1561046625778515336==--