From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: diagrams - all over the CGIs
Date: Wed, 13 May 2020 10:59:01 +0100
Message-ID: <83755B15-1C34-4BE9-8F6E-6FEC2B1220C0@ipfire.org>
In-Reply-To: <857233b6-b5ca-bd04-f483-3da5c0a9eb94@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3464086190009882807=="
List-Id: <development.lists.ipfire.org>

--===============3464086190009882807==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 13 May 2020, at 09:38, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Hi,
>=20
> this just came to my view while looking at Peters patches for
> 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
>=20
> Searching for the translation string  ...$Lang::tr{'graph'}... I found
> it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
>=20
> What are these repetitions good for?
>=20
> I mean, you click on "Network (external)". You read the topic
> "Net-Traffic graphs (external)" or "... (internal).
>=20
> You know: here I'll find ... graphs. Ok. Lets see.
>=20
> But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or
> CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda
> *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?

Yeah, we absolutely do not need that word in the headline.

=E2=80=9CMemory=E2=80=9D should make it clear what we are showing. It is obvi=
ous that the graph is a graph.

> My two cents: I think we don't need this translation string at these
> specific points in the WUI.

Would you like to send in a patch for this?

Best,
-Michael

>=20
> Opinions?
>=20
> Best,
> Matthias


--===============3464086190009882807==--