From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Trying to update gd Date: Sat, 19 Jun 2021 17:43:43 +0200 Message-ID: <8458e0bf-c5ba-214c-e695-656139240b6c@ipfire.org> In-Reply-To: <767ECA00-0689-43A9-813D-59694B95CA2D@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1782411574867343696==" List-Id: --===============1782411574867343696== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 19/06/2021 14:09, Michael Tremer wrote: > Hello, >=20 > Could you just try putting that filename in quotes? >=20 > That should work. Yep, that worked. So the updated gd is working on all charts. I will submit the patch for it. Thanks for the help. Regards, Adolf. >=20 > -Michael >=20 >> On 18 Jun 2021, at 22:26, Adolf Belka wrote: >> >> Hi Michael, >> >> On 18/06/2021 10:35, Michael Tremer wrote: >>> Hello, >>>> On 17 Jun 2021, at 19:53, Adolf Belka wrote: >>>> >>>> Hi All, >>>> >>>> I found that gd was at version 2.0.33 from 2006 and there have been seve= ral updates all the way up to May this year, some of them to fix bugs or secu= rity concerns. >>> Definitely needs an update! >>>> So I did a build for version 2.3.1 also taking the opportunity to disabl= e-static libraries. >>>> >>>> This built successfully and I also ran the find-dependencies as the libr= aries changed from libgd.so.2.0.0 to libgd.3.0.9 There were no dependencies = on libgd.so.2 or libgd.2.0.0 >>>> >>>> As gd is used for the charts I installed the generated iso into a vm on = my testbed system to confirm they worked. >>>> >>>> None of the charts showed any data. Also the log pie charts did not work= . The error message from httpd/error_log was:- >>>> >>>> >>>> Can't load '/usr/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi/au= to/GD/GD.so' for module GD: libtiff.so.5: cannot open shared object file: No = such file or directory at /usr/lib/perl5/5.32.1/x86_64-linux-thread-multi/Dyn= aLoader.pm line 193. >>>> ^@ at /srv/web/ipfire/cgi-bin/getrrdimage.cgi line 24. >>>> Compilation failed in require at /srv/web/ipfire/cgi-bin/getrrdimage.cgi= line 24. >>>> BEGIN failed--compilation aborted at /srv/web/ipfire/cgi-bin/getrrdimage= .cgi line 24. >>>> [Thu Jun 17 16:38:29.559844 2021] [cgid:error] [pid 3156:tid 12722785323= 1680] [client 192.168.200.50:49220] End of script output before headers: getr= rdimage.cgi, referer: https://ipfire.localdomain:444/ >>>> >>>> >>>> This seems to be saying it can't find libtiff.so.5 >>>> >>>> Looking through the source tarballs over time I found that version 2.1.0= was where it started to look for libtiff. >>>> >>>> I then installed the libtiff addon in my vm and the charts were all work= ing. So the new gd requires the libtiff shared object libraries. >>>> >>>> The addon installs a lot more than just the libtiff so libs so it does n= ot seem right to build that structurally into the firewall. >>>> >>>> >>>> The only option I have come up with is to copy the libtiff so's into /us= r/lib/ after the install stage of gd. >>>> >>>> libtiff is built before gd so the files are available in the build. This= would seem to then provide the required libs without the rest of the libtiff= files. >>>> >>>> Is this a reasonable approach to use or is there a different method I sh= ould be using. >>> Can you not pass something like =E2=80=94-disable-tiff to the configure s= cript of gd to avoid it linking against libtiff? >>> We do not generate any TIFF files here, so it would be safe to disable th= at functionality. >> Thanks very much for the guidance. There was a configure option --without-= tiff so I used that. Built successfully and then tested it in my vm testbed. = All charts except memory.cgi work. I need to get more data to confirm that th= e log pie charts work. >> >> With memory.cgi I get an Internal Server Error. The log gives the followin= g:- >> >> Bareword "collectd" not allowed while "strict subs" in use at /srv/web/ipf= ire/cgi-bin/memory.cgi line 59. >> Bareword "localhost" not allowed while "strict subs" in use at /srv/web/ip= fire/cgi-bin/memory.cgi line 59. >> Bareword "swap" not allowed while "strict subs" in use at /srv/web/ipfire/= cgi-bin/memory.cgi line 59. >> Execution of /srv/web/ipfire/cgi-bin/memory.cgi aborted due to compilation= errors. >> >> Looking at line 59 and checking in git this looks to be related to a chang= e done by Stefan Schantl 8 days ago >> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D4353c579248b= 3016740252009b4ed15a4c6f8fe3 >> >> I don't want to commit the patch for gd until I have memory.cgi confirmed = working and enough firewall data to confirm the pie charts are working but it= looks close to completion. >> >> Regards, >> Adolf. >> >>> -Michael >>>> >>>> >>>> Regards, >>>> >>>> Adolf. >>>> >>>> >>>> --=20 >>>> Sent from my laptop >=20 --===============1782411574867343696==--