From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/5] ids-functions.pl: Drop downloader code for sourcefire
 based ruleset.
Date: Wed, 23 Mar 2022 09:37:18 +0000
Message-ID: <84EB6E23-4183-4427-A54C-6142B7E33BD8@ipfire.org>
In-Reply-To: <20220323040452.2609-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2885109862516939085=="
List-Id: <development.lists.ipfire.org>

--===============2885109862516939085==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Yes, agreed. We should not send any HEAD requests at all. GET will be able to=
 tell us the same.

Not sure if this is a relic from before when we had HTTP/1.1. Wow.

> On 23 Mar 2022, at 04:04, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Even if the servers do not support HEAD requests, the remote filesize
> (content_length) can be obtained from the connection headers.
>=20
> This generic method works for all servers and therefore we do not need
> the code for handle sourcefire servers in a different way anymore.
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> config/cfgroot/ids-functions.pl | 43 +++++----------------------------
> 1 file changed, 6 insertions(+), 37 deletions(-)
>=20
> diff --git a/config/cfgroot/ids-functions.pl b/config/cfgroot/ids-functions=
.pl
> index 94dccc8ae..eb276030b 100644
> --- a/config/cfgroot/ids-functions.pl
> +++ b/config/cfgroot/ids-functions.pl
> @@ -354,43 +354,6 @@ sub downloadruleset ($) {
> 			return 1;
> 		}
>=20
> -		# Variable to store the filesize of the remote object.
> -		my $remote_filesize;
> -
> -		# The sourcfire (snort rules) does not allow to send "HEAD" requests, so=
 skip this check
> -		# for this webserver.
> -		#
> -		# Check if the ruleset source contains "snort.org".
> -		unless ($url =3D~ /\.snort\.org/) {
> -			# Pass the requrested url to the downloader.
> -			my $request =3D HTTP::Request->new(HEAD =3D> $url);
> -
> -			# Accept the html header.
> -			$request->header('Accept' =3D> 'text/html');
> -
> -			# Perform the request and fetch the html header.
> -			my $response =3D $downloader->request($request);
> -
> -			# Check if there was any error.
> -			unless ($response->is_success) {
> -				# Obtain error.
> -				my $error =3D $response->status_line();
> -
> -				# Log error message.
> -				&_log_to_syslog("Unable to download the ruleset. \($error\)");
> -
> -				# Return "1" - false.
> -				return 1;
> -			}
> -
> -			# Assign the fetched header object.
> -			my $header =3D $response->headers();
> -
> -			# Grab the remote file size from the object and store it in the
> -			# variable.
> -			$remote_filesize =3D $header->content_length;
> -		}
> -
> 		# Load perl module to deal with temporary files.
> 		use File::Temp;
>=20
> @@ -416,6 +379,12 @@ sub downloadruleset ($) {
> 			return 1;
> 		}
>=20
> +		# Obtain the connection headers.
> +		my $headers =3D $response->headers;
> +
> +		# Get the remote size of the downloaded file.
> +		my $remote_filesize =3D $headers->content_length;
> +
> 		# Load perl stat module.
> 		use File::stat;
>=20
> --=20
> 2.30.2
>=20


--===============2885109862516939085==--