From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH 2/3] alsa: Fixes Bug#13087 - adds module removal for stopping alsa. Date: Wed, 03 May 2023 14:26:06 +0200 Message-ID: <84ea96e5-c750-ddc2-c15b-307d72d6c742@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2921160513520153732==" List-Id: --===============2921160513520153732== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 03/05/2023 14:08, Michael Tremer wrote: > What is the benefit of unloading the kernel modules? >=20 > Wouldn=E2=80=99t they automatically be reloaded once something triggers ude= v? I tested installing the alsa addon on my production machine, which doesn't ha= ve any sound capability at all and I don't plan to install it. However, after= installing the alsa addon I had the modules loaded and after uninstalling th= e alsa addon those alsa related kernel modules stayed there and would persist= till a reboot was done for a core update for example. It just seemed to me that unneeded kernel modules shouldn't stay loaded up ju= st because an addon was installed for a test and then removed. It seemed that things that installed modules should remove them when they are= uninstalled. Maybe the unloading should be moved to the uninstall.sh file rather than in t= he initscript. That might make more sense because then the addon has been com= pletely (hopefully) removed. Regards, Adolf >=20 > -Michael >=20 >> On 3 May 2023, at 12:47, Adolf Belka wrote: >> >> Hi Arne, >> >> On 02/05/2023 10:55, Arne Fitzenreiter wrote: >>> I think this will not work. >>> You have to run "alsctl store" to save the mixer settings before you unlo= ad the modules. >> Thanks for flagging this up. I hadn't thought of that. I will fix it. >>> There are also some *.conf files commented in the rootfiles. Also complai= ns that they are missing since some >>> versions. (still work on my hardware anyways.) >>> Please include it to the package. >> I will find them and uncomment them in the rootfile. >> >> What is the best way to submit these updates. Just a v2 update for the pat= ch 2/3 plus another patch for the rootfile update or should I do a v2 patch s= ubmission for the complete set of three patches from the original set togethe= r with an additional patch for the rootfile changes? >> >> Regards, >> >> Adolf. >>> Arne >>> Am 2023-04-21 23:15, schrieb Adolf Belka: >>>> - Stopping alsa or uninstalling it left the sound modules installed >>>> until a reboot was >>>> carried out. Uninstallation or stopping the kernel modules should >>>> also unload them. >>>> This patch adds in the modprobe -r commands to unload all the snd >>>> modules installed >>>> with the start command. The stop command is then added into the >>>> uninstall script to >>>> remove the modules. >>>> >>>> Fixes: Bug#13087 >>>> Tested-by: Adolf Belka >>>> Signed-off-by: Adolf Belka >>>> --- >>>> src/initscripts/packages/alsa | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/src/initscripts/packages/alsa b/src/initscripts/packages/al= sa >>>> index 348e33846..3bfb69f62 100644 >>>> --- a/src/initscripts/packages/alsa >>>> +++ b/src/initscripts/packages/alsa >>>> @@ -33,6 +33,10 @@ case "$1" in >>>> ;; >>>> stop) >>>> boot_mesg "Stopping ALSA... Saving volumes..." >>>> + modprobe -r snd_pcm_oss >/dev/null 2>&1 || failed=3D1 >>>> + modprobe -r snd_timer >/dev/null 2>&1 || failed=3D1 >>>> + (exit ${failed}) >>>> + evaluate_retval >>>> loadproc /usr/sbin/alsactl store >>>> ;; >=20 --===============2921160513520153732==--