From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability
Date: Wed, 26 May 2021 17:32:53 +0200 [thread overview]
Message-ID: <84fe99d7-da07-b4f2-0705-4dd5d5934645@ipfire.org> (raw)
In-Reply-To: <a1bf7fb7-7317-0403-ccf1-da774eb39e77@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]
Hi Adolf,
On 26.05.2021 13:01, Adolf Belka wrote:
> Hi Matthias,
>
> On 22/05/2021 16:53, Matthias Fischer wrote:
>> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
>>
>> Hi,
>>
>> in the meantime I worked on this - a bit - again. Currently, this CGI is
>> running here under Core 156 with no seen problems.
>>
>> I've made several changes and adjustments.
>>
>> First:
>> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>>
>> - I kept the old icon order "Download - Delete - Save".
>>
>> Changelog:
>> - Cleaned up the code a bit, some if-queries were unnessecary (if
>> ($cgiparams{'ACTION'} eq...).
>>
>> - Therefore, some lang strings became obsolete ('downloadaddon' and
>> 'downloadiso'.
>>
>> - Separated the ISO files from the IPF files for better overview.
>>
>> - Added query for deleting a backup file (onclick=\"return confirm...).
>>
>> - Added 'onclick' feature => deleting a file must be acknowledged.
>>
>> Biggest change:
>> - Added tables - as MT mentioned.
>>
>> Details can be seen in the attached screenshots.
>>
>> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)
>
> It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.
Nice. Thanks. But...
At the moment I have no idea how to change this CGI to show these
alternating rows. I never did this. For a start I looked into some other
CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services,
wakeonlan, wio and log.dat).
But alternate rows seem to be a bit more complicated to me than the
tables. Hm.
[I'm not an experienced programmer with CGI (call me
"scriptkiddie" ;-) ).]
If everything fails, I'll have to ask for hints how to do this. I'll see
how far I can get.
> Any chance of a diff so I can try it out on a testbed system?
No problem. Work in progress...
> By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320
I'm aware of this. Not much time these days... ;-)
Best,
Matthias
next prev parent reply other threads:[~2021-05-26 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167e8e93-3c40-f85c-9cb5-a552ca1ff9d5@ipfire.org>
2021-05-22 16:53 ` Jon Murphy
2021-05-25 10:34 ` Michael Tremer
2021-05-26 11:01 ` Adolf Belka
2021-05-26 15:32 ` Matthias Fischer [this message]
2021-05-26 15:53 ` Adolf Belka
2021-05-26 15:58 ` Leo Hofmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fe99d7-da07-b4f2-0705-4dd5d5934645@ipfire.org \
--to=matthias.fischer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox