From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fischer To: development@lists.ipfire.org Subject: Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability Date: Wed, 26 May 2021 17:32:53 +0200 Message-ID: <84fe99d7-da07-b4f2-0705-4dd5d5934645@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8280098808167019301==" List-Id: --===============8280098808167019301== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Adolf, On 26.05.2021 13:01, Adolf Belka wrote: > Hi Matthias, >=20 > On 22/05/2021 16:53, Matthias Fischer wrote: >> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=3D12588 >> >> Hi, >> >> in the meantime I worked on this - a bit - again. Currently, this CGI is >> running here under Core 156 with no seen problems. >> >> I've made several changes and adjustments. >> >> First: >> - I kept the icons - buttons didn't look as I hoped they would. ;-) >> >> - I kept the old icon order "Download - Delete - Save". >> >> Changelog: >> - Cleaned up the code a bit, some if-queries were unnessecary (if >> ($cgiparams{'ACTION'} eq...). >> >> - Therefore, some lang strings became obsolete ('downloadaddon' and >> 'downloadiso'. >> >> - Separated the ISO files from the IPF files for better overview. >> >> - Added query for deleting a backup file (onclick=3D\"return confirm...). >> >> - Added 'onclick' feature =3D> deleting a file must be acknowledged. >> >> Biggest change: >> - Added tables - as MT mentioned. >> >> Details can be seen in the attached screenshots. >> >> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;= -) >=20 > It looks okay to me. Alternating shades of grey for the rows as mentioned b= y Michael would also be fine. Nice. Thanks. But... At the moment I have no idea how to change this CGI to show these alternating rows. I never did this. For a start I looked into some other CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services, wakeonlan, wio and log.dat). But alternate rows seem to be a bit more complicated to me than the tables. Hm. [I'm not an experienced programmer with CGI (call me "scriptkiddie" ;-) ).] If everything fails, I'll have to ask for hints how to do this. I'll see how far I can get. > Any chance of a diff so I can try it out on a testbed system? No problem. Work in progress... > By the way, FYI there is another backup umbrella bug https://bugzilla.ipfir= e.org/show_bug.cgi?id=3D11320 I'm aware of this. Not much time these days... ;-) Best, Matthias --===============8280098808167019301==--