public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2] Core Update 165: Rename squid-accounting add-on to proxy-accounting
Date: Sat, 05 Mar 2022 21:40:32 +0100	[thread overview]
Message-ID: <85126118-096b-441b-fedd-949237266963@ipfire.org> (raw)
In-Reply-To: <cbfdd374-aa6d-7534-49cb-fa2c9d83ae6d@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]

Hi Peter,

On 05/03/2022 15:45, Peter Müller wrote:
> https://lists.ipfire.org/pipermail/development/2022-February/012482.html
>
> The second version of this patch omits bogus directives for restarting a
> service, which proxy-accounting is not.
Thanks very much for figuring this out. I will note this so that when I 
need to do it in future I know how to approach it.

Lucky thing is that all of the packages that were in my perl renaming 
patch set were all core packages with none being addons so this approach 
is not needed for any of them.

Regards,
Adolf.
> Cc: Michael Tremer <michael.tremer(a)ipfire.org>
> Cc: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
>   config/rootfiles/core/165/update.sh | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
> index fe4449fff..f505628e4 100644
> --- a/config/rootfiles/core/165/update.sh
> +++ b/config/rootfiles/core/165/update.sh
> @@ -97,6 +97,14 @@ rm -rvf \
>   	/var/ipfire/dhcpc/dhcpcd-hooks/10-mtu \
>   	/var/ipfire/firewall/p2protocols
>   
> +# Rename squid-accounting add-on to proxy-accounting, if installed
> +# (see: https://lists.ipfire.org/pipermail/development/2022-February/012482.html)
> +if [ -e "/opt/pakfire/db/installed/meta-squid-accounting" ] && [ -e "/opt/pakfire/db/meta/meta-squid-accounting" ]; then
> +	mv -v /opt/pakfire/db/installed/meta-squid-accounting /opt/pakfire/db/installed/meta-proxy-accounting
> +	mv -v /opt/pakfire/db/meta/meta-squid-accounting /opt/pakfire/db/meta/meta-proxy-accounting
> +	mv -v /opt/pakfire/db/rootfiles/squid-accounting /opt/pakfire/db/rootfiles/proxy-accounting
> +fi
> +
>   # Stop services
>   
>   # Extract files

-- 
Sent from my laptop


  reply	other threads:[~2022-03-05 20:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-05 14:45 Peter Müller
2022-03-05 20:40 ` Adolf Belka [this message]
2022-03-18 13:46   ` Adolf Belka
2022-03-19 13:09     ` Adolf Belka
2022-03-19 13:27       ` Matthias Fischer
2022-03-19 14:04         ` Adolf Belka
2022-03-19 14:18           ` Adolf Belka
2022-03-19 15:13             ` Adolf Belka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85126118-096b-441b-fedd-949237266963@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox