From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2] Core Update 165: Rename squid-accounting add-on to
 proxy-accounting
Date: Sat, 05 Mar 2022 21:40:32 +0100
Message-ID: <85126118-096b-441b-fedd-949237266963@ipfire.org>
In-Reply-To: <cbfdd374-aa6d-7534-49cb-fa2c9d83ae6d@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7674290637770404080=="
List-Id: <development.lists.ipfire.org>

--===============7674290637770404080==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Peter,

On 05/03/2022 15:45, Peter M=C3=BCller wrote:
> https://lists.ipfire.org/pipermail/development/2022-February/012482.html
>
> The second version of this patch omits bogus directives for restarting a
> service, which proxy-accounting is not.
Thanks very much for figuring this out. I will note this so that when I=20
need to do it in future I know how to approach it.

Lucky thing is that all of the packages that were in my perl renaming=20
patch set were all core packages with none being addons so this approach=20
is not needed for any of them.

Regards,
Adolf.
> Cc: Michael Tremer <michael.tremer(a)ipfire.org>
> Cc: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
>   config/rootfiles/core/165/update.sh | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/16=
5/update.sh
> index fe4449fff..f505628e4 100644
> --- a/config/rootfiles/core/165/update.sh
> +++ b/config/rootfiles/core/165/update.sh
> @@ -97,6 +97,14 @@ rm -rvf \
>   	/var/ipfire/dhcpc/dhcpcd-hooks/10-mtu \
>   	/var/ipfire/firewall/p2protocols
>  =20
> +# Rename squid-accounting add-on to proxy-accounting, if installed
> +# (see: https://lists.ipfire.org/pipermail/development/2022-February/01248=
2.html)
> +if [ -e "/opt/pakfire/db/installed/meta-squid-accounting" ] && [ -e "/opt/=
pakfire/db/meta/meta-squid-accounting" ]; then
> +	mv -v /opt/pakfire/db/installed/meta-squid-accounting /opt/pakfire/db/ins=
talled/meta-proxy-accounting
> +	mv -v /opt/pakfire/db/meta/meta-squid-accounting /opt/pakfire/db/meta/met=
a-proxy-accounting
> +	mv -v /opt/pakfire/db/rootfiles/squid-accounting /opt/pakfire/db/rootfile=
s/proxy-accounting
> +fi
> +
>   # Stop services
>  =20
>   # Extract files

--=20
Sent from my laptop


--===============7674290637770404080==--