From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fischer To: development@lists.ipfire.org Subject: diagrams - all over the CGIs Date: Wed, 13 May 2020 10:38:56 +0200 Message-ID: <857233b6-b5ca-bd04-f483-3da5c0a9eb94@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0521238189569699204==" List-Id: --===============0521238189569699204== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi, this just came to my view while looking at Peters patches for 'system.cgi' and 'graphs.pl' ("properly translate load average graph"). Searching for the translation string ...$Lang::tr{'graph'}... I found it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'. What are these repetitions good for? I mean, you click on "Network (external)". You read the topic "Net-Traffic graphs (external)" or "... (internal). You know: here I'll find ... graphs. Ok. Lets see. But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again? My two cents: I think we don't need this translation string at these specific points in the WUI. Opinions? Best, Matthias --===============0521238189569699204==--