From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] QoS: Do not try to unload any kernel modules Date: Thu, 18 Nov 2021 11:14:01 +0000 Message-ID: <85DE1A5F-AB09-4531-A2A8-2713D3A4DB55@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7017997723025211341==" List-Id: --===============7017997723025211341== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, > On 17 Nov 2021, at 20:15, Peter M=C3=BCller wr= ote: >=20 > Hello Michael, >=20 > could you elaborate more on this one? Sure. > From my basic understanding, QoS should not try to unload kernel modules in= deed, > but I did not get why it was doing so in the first place. Unloading kernel modules used to be an old thing to do. I have no idea really= why what the motivation was. Partly to save memory, and partly to not have unused module loaded since hard= ware for example was being detected by loading every single module and see if= it recognised any hardware. Here we unload the HTB scheduler simply because we do not need it any more af= ter the QoS was stopped. However, during an update, it might happen that the = QoS needs to be restarted. When the kernel has been updated in the same updat= er, we no longer have the kernel modules available for the running kernel. Si= nce sch_htb was unloaded, we can no longer load it again. That was the motiva= tion for this patch here. At least QoS continues to work until the system is = being rebooted after the update. Does this make sense? -Michael >=20 > Thanks, and best regards, > Peter M=C3=BCller >=20 >=20 >> Signed-off-by: Michael Tremer >> --- >> config/qos/makeqosscripts.pl | 2 -- >> 1 file changed, 2 deletions(-) >> diff --git a/config/qos/makeqosscripts.pl b/config/qos/makeqosscripts.pl >> index 0694bb78c..3234ab366 100644 >> --- a/config/qos/makeqosscripts.pl >> +++ b/config/qos/makeqosscripts.pl >> @@ -510,8 +510,6 @@ print <> iptables -t mangle --flush QOS-INC >/dev/null 2>&1 >> iptables -t mangle --delete-chain QOS-INC >/dev/null 2>&1 >> - rmmod sch_htb >/dev/null 2>&1 >> - >> for i in \$(ls \$RRDLOG/class_*.rrd); do >> rrdtool update \$i \$(date +%s): >> done --===============7017997723025211341==--