From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] logs.cgi/ids.dat: Rework linking to external rule documentation.
Date: Tue, 14 Aug 2018 09:16:36 +0100
Message-ID: <8653e3a2ac4ca12aa6ee5040825f1b63b5b70033.camel@ipfire.org>
In-Reply-To: <20180811180805.5859-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7960388433754609541=="
List-Id: <development.lists.ipfire.org>

--===============7960388433754609541==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Please see the comments on the bug ticket...

On Sat, 2018-08-11 at 20:08 +0200, Stefan Schantl wrote:
> Check if the sid of a rule belongs to sourcefire and link to the
> changed URL for gathering more details. If the sid of the rule belongs
> to emergingthreads now link to the emergingthreads documentation.
> 
> Fixes #11806.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  html/cgi-bin/logs.cgi/ids.dat | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.dat
> index 98176d690..5aef53499 100644
> --- a/html/cgi-bin/logs.cgi/ids.dat
> +++ b/html/cgi-bin/logs.cgi/ids.dat
> @@ -336,7 +336,14 @@ print <<END
>  END
>  	;
>  	if ($sid ne "n/a") {
> -		print "<a href='https://www.snort.org/rule_docs/$sid' ";
> +		# Link to sourcefire if the the rule sid is less than 1000000.
> +		if ($sid lt 1000000) {
> +			print "<a href='https://www.snort.org/rule_docs/1-$sid'"
> ;
> +		# Link to emergingtreads if the rule sid is between 2000000 and
> 3000000.
> +		} elsif (($sid gt 2000000) && ($sid lt 3000000)) {
> +			print "<a href='http://doc.emergingthreats.net/$sid'";
> +		}
> +		# Close html tag for hyperlink.
>  		print "target='_blank'>$sid</a></td>\n";
>  	} else {
>  		print $sid;


--===============7960388433754609541==--