From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4jFDqX58vlz3076 for ; Wed, 28 Oct 2026 17:28:56 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1 raw public key) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "YR1" (not verified)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4jFDqT0Xb3z2xHd for ; Wed, 28 Oct 2026 17:28:53 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4jFDqR1H8bz14q; Wed, 28 Oct 2026 17:28:51 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1793208531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yIegWyzwygJqO0OEXewKhAweCRPTVNwflLa14QZgmqM=; b=UkzooDvqfE9L8M+y83EAn2T0gidf0Tp9PEA0UKRbgfC073GIX24U5Nf6z3yO6QhOn9fkYx R23Xj5UcNB3dzjAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1793208531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yIegWyzwygJqO0OEXewKhAweCRPTVNwflLa14QZgmqM=; b=TmedEuCwdtOCflCwMM7I0U0Q5Z6OFKXvme1a31vT1QxPvwxOmKKSaUHuAGlh8IELQsGdT6 Fgd4PThJ8XZPCdAYKT4Mfrtx4+ZwhNFgkRY031AGzRnVZIHeHtmJ2LO918OA94R/5Db14s SMdE/ukaWa6UY7/x5wNbjMs5qgDPcyw8gl/IlGVE/CgBHQP5GzWDbmPrBH80zwt12Iokun qwGVUo0yd8C08uq0wk/dAUWGiIGptQ7ofaMu9fsJ3vO+HUtF8rwhi0Q/B4FPgVjtqcx19P oH80WdwX1XaqIt/Nontr0mkGmmT7ZcFN1rQvku1VQlessjHO37QptE43w/w6Lg== Content-Type: text/plain; charset=us-ascii Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH 0/3] OpenVPN: Fix N2N connections shown as DISCONNECTED while up From: Michael Tremer In-Reply-To: <20261027222110.2642078-1-antonio@mandelbit.com> Date: Wed, 28 Oct 2026 17:28:50 +0000 Cc: development@lists.ipfire.org Content-Transfer-Encoding: quoted-printable Message-Id: <8707D8AE-46F3-466E-A604-20C95B64BD88@ipfire.org> References: <20261027222110.2642078-1-antonio@mandelbit.com> To: Antonio Quartulli Hello Antonio, Thank you so much for your patch. I am happy to merge this and create a separate file with the function so = that it can be re-used properly. =46rom which version of OpenVPN will this work? All the best, -Michael > On 27 Oct 2026, at 22:21, Antonio Quartulli = wrote: >=20 > Hi all! >=20 > This is my first contribution to IPFire, so bear with me if I am doing > things the wrong way :) >=20 > This is what this small series addresses: >=20 > In P2P mode OpenVPN leaves its management state at AUTH/WAIT when a = new > session attempt never completes (e.g. a stray packet from the = internet), > although the tunnel keeps working. The WUI then shows the N2N = connection > as DISCONNECTED (bug #13897). >=20 > A fix for OpenVPN has already been published for review [1], but it is > not integrated yet. These patches fix IPFire while OpenVPN still > misbehaves. >=20 > A test harness is included to verify the fix and possibly perform > regression testing in the future. >=20 > Notes: > - index.cgi and ovpnmain.cgi now require the new > /var/ipfire/ovpn-functions.pl, so it needs to be shipped with the = next > Core Update. I left the filelists to you. > - wio.cgi (WIO addon) still uses the old check and has the same = problem; > I can send a follow-up if wanted. >=20 > [1] https://gerrit.openvpn.net/c/openvpn/+/2040 >=20 > Antonio Quartulli (3): > ovpn-functions.pl: Add a helper to get the status of N2N connections > ovpnmain.cgi/index.cgi: Use OpenVPN::n2n_status() > tests: Add tests for OpenVPN::n2n_status() >=20 > config/cfgroot/ovpn-functions.pl | 96 +++++++++++++++++++ > config/rootfiles/common/configroot | 1 + > html/cgi-bin/index.cgi | 12 +-- > html/cgi-bin/ovpnmain.cgi | 58 +---------- > lfs/configroot | 1 + > .../ovpn-functions.pl/data/auth_pending | 6 ++ > .../cfgroot/ovpn-functions.pl/data/connected | 7 ++ > .../data/connected_stray_session | 8 ++ > .../cfgroot/ovpn-functions.pl/data/empty | 1 + > .../cfgroot/ovpn-functions.pl/data/exiting | 7 ++ > .../ovpn-functions.pl/data/never_connected | 6 ++ > .../ovpn-functions.pl/data/notifications | 11 +++ > .../ovpn-functions.pl/data/reconnected | 11 +++ > .../ovpn-functions.pl/data/reconnecting | 9 ++ > .../cfgroot/ovpn-functions.pl/data/truncated | 3 + > .../cfgroot/ovpn-functions.pl/n2n_status.pl | 73 ++++++++++++++ > .../config/cfgroot/ovpn-functions.pl/test.sh | 70 ++++++++++++++ > 17 files changed, 315 insertions(+), 65 deletions(-) > create mode 100644 config/cfgroot/ovpn-functions.pl > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/auth_pending > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/connected > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/connected_stray_session > create mode 100644 tests/config/cfgroot/ovpn-functions.pl/data/empty > create mode 100644 tests/config/cfgroot/ovpn-functions.pl/data/exiting > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/never_connected > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/notifications > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/reconnected > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/reconnecting > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/data/truncated > create mode 100644 = tests/config/cfgroot/ovpn-functions.pl/n2n_status.pl > create mode 100755 tests/config/cfgroot/ovpn-functions.pl/test.sh >=20 > --=20 > 2.55.0 >=20 >=20