Hi Peter,

On 24/11/2023 14:16, Peter Müller wrote:
> Hello Adolf,
> 
> I have a question regarding this patch, please see below.
> 
>> - Update from version 2.11.2 to 2.12.0
>> - Update of rootfile
>> - Changelog
>>      2.12.0
>> 	Fixes:
>> 	 * Fix some manual page portability issues with groff 1.23.0.
>> 	 * Fix test failures when a working `iconv` is not available.
>> 	 * Ensure that timestamps read from the database can go past the year 2038,
>> 	   even on systems where this is not the default.
>> 	 * Fix `manpath` not parsing `PATH` entries with trailing slash correctly
>> 	   for guessing `MANPATH` entries.
>> 	 * More accurately document the behaviour of passing file names as arguments
>> 	   to `man` without the `-l`/`--local-file` option.
>> 	 * Avoid duplicate cleanup of old cat pages by both `man-db.service` and
>> 	   `systemd-tmpfiles-clean.service`.
>> 	Improvements:
>> 	 * Update system call lists in `seccomp` sandbox from `systemd`.
>> 	 * Upgrade to Gnulib `stable-202307`.
>> 	 * Work around the Firebuild accelerator in `seccomp` sandbox: if this is in
>> 	   use then we need to allow some socket-related system calls.
>> 	 * `man -K` now deduplicates search results that point to the same page.
>> 	 * Warn if `mandb` drops to `--user-db` mode due to running as the wrong
>> 	   user.
>> 	 * Change section title recommendations in `man(1)` to mention `STANDARDS`
>> 	   rather than `CONFORMING TO`, in line with `man-pages(7)`.
>> 	 * Add a `STANDARDS` section to `man(1)` itself.
>> 	 * Document that `man -K` may suffer from false negatives as well as false
>> 	   positives.
>> 	 * Take advantage of newer `groff` facilities to implement `man
>> 	   --no-hyphenation` and `man --no-justification`, if available.
>> 	 * `man -f` and `man -k` now pass any `-r`/`--regex` or `-w`/`--wildcard`
>> 	   options on to `whatis` and `apropos` respectively.
>> 	 * Always pass a line length to `nroff`, even if we believe that it matches
>> 	   the default.
>> 	 * Allow disabling `groff` warnings via `man --warnings`, by prefixing a
>> 	   warning name with `!`.
>>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>>   config/rootfiles/common/man | 5 +++--
>>   lfs/man                     | 4 ++--
>>   2 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/config/rootfiles/common/man b/config/rootfiles/common/man
>> index 83354be30..4051cac8d 100644
>> --- a/config/rootfiles/common/man
>> +++ b/config/rootfiles/common/man
>> @@ -8,10 +8,10 @@
>>   #usr/bin/manpath
>>   #usr/bin/whatis
>>   #usr/lib/man-db
>> -#usr/lib/man-db/libman-2.11.2.so
>> +usr/lib/man-db/libman-2.12.0.so
>>   #usr/lib/man-db/libman.la
>>   #usr/lib/man-db/libman.so
>> -#usr/lib/man-db/libmandb-2.11.2.so
>> +usr/lib/man-db/libmandb-2.12.0.so
> 
> So far, man was a build-time dependency only, which is why all entries in its
> rootfile were commented out:
> 
> $ grep -v -E '^#' config/rootfiles/common/man | wc -l
> 0
> 
> Is it intentional that usr/lib/man-db/libman-2.12.0.so and usr/lib/man-db/libmandb-2.12.0.so
> are commented in (i.e., we should/need to ship these)? If not, happy to fix that
> (no need for submitting a version 2 of this patch), just like to have it clarified. :-)

No it was not intentional. I know that those man related packages are 
build time only. I probably saw a library and my brain went to autopilot 
and said "oh yes, libraries are required".

Thanks for catching and for fixing for me.

Regards,
Adolf.

> 
> Thanks, and best regards,
> Peter Müller
> 
>>   #usr/lib/man-db/libmandb.la
>>   #usr/lib/man-db/libmandb.so
>>   #usr/libexec/man-db
>> @@ -54,6 +54,7 @@
>>   #usr/share/locale/ja/LC_MESSAGES/man-db-gnulib.mo
>>   #usr/share/locale/ja/LC_MESSAGES/man-db.mo
>>   #usr/share/locale/ka/LC_MESSAGES/man-db-gnulib.mo
>> +#usr/share/locale/ka/LC_MESSAGES/man-db.mo
>>   #usr/share/locale/ko/LC_MESSAGES/man-db-gnulib.mo
>>   #usr/share/locale/ko/LC_MESSAGES/man-db.mo
>>   #usr/share/locale/ms/LC_MESSAGES/man-db-gnulib.mo
>> diff --git a/lfs/man b/lfs/man
>> index 00150da4e..9a5ea7675 100644
>> --- a/lfs/man
>> +++ b/lfs/man
>> @@ -24,7 +24,7 @@
>>   
>>   include Config
>>   
>> -VER        = 2.11.2
>> +VER        = 2.12.0
>>   
>>   THISAPP    = man-db-$(VER)
>>   DL_FILE    = $(THISAPP).tar.xz
>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>   
>>   $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>   
>> -$(DL_FILE)_BLAKE2 = 80ac565cdb69736c0f922b9cbfddcae753d176329781deaf9434d87d7718f9b6ce0b6d4642a03f22a04c7f042dda7f8986b5bce0038f0748461ca55d66964ccc
>> +$(DL_FILE)_BLAKE2 = a6258c1fc9cd81be5d288298660f5b9bda22d726ef98dd5c0a1998809a32391f7244be6897ee8e03483e705a426d6a59d442de3dc2e84f45500daa825ac639db
>>   
>>   install : $(TARGET)
>>   

-- 
Sent from my laptop