From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Cosmetics: New icons for backup.cgi
Date: Sat, 29 Sep 2018 11:04:20 +0100 [thread overview]
Message-ID: <893702af3196780d874d169489388fc5ed43feb5.camel@ipfire.org> (raw)
In-Reply-To: <20180928175239.3243-1-matthias.fischer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 11253 bytes --]
Hello,
where are those icons coming from? Do we have a license to use them?
Also, wouldn't it be better to have just normal buttons instead of these tiny
icons? There are hard to click on because they are very small and indeed, there
are confusing.
Best,
-Michael
On Fri, 2018-09-28 at 19:52 +0200, Matthias Fischer wrote:
> Hi,
>
> this was triggered by:
>
> https://forum.ipfire.org/viewtopic.php?f=17&t=21372
>
> As suggested there, I added new icons for better readability. But I kept
> the icon order.
>
> Best,
> Matthias
>
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/backup.cgi | 24 ++++++++++++------------
> html/html/images/download.png | Bin 0 -> 646 bytes
> html/html/images/restore.png | Bin 0 -> 459 bytes
> 3 files changed, 12 insertions(+), 12 deletions(-)
> create mode 100644 html/html/images/download.png
> create mode 100644 html/html/images/restore.png
>
> diff --git a/html/cgi-bin/backup.cgi b/html/cgi-bin/backup.cgi
> index cac4146ab..e015abce4 100644
> --- a/html/cgi-bin/backup.cgi
> +++ b/html/cgi-bin/backup.cgi
> @@ -178,7 +178,7 @@ print <<END
> </tr>
> <tr><td align='center' colspan='2'>
> <input type='hidden' name='ACTION' value='backup' />
> - <input type='image' alt='$Lang::tr{'backup'}'
> title='$Lang::tr{'backup'}' src='/images/document-save.png' />
> + <input type='image' alt='$Lang::tr{'backup'}'
> title='$Lang::tr{'backup'}' src='/images/media-floppy.png' />
> </td></tr>
> </table>
> </form>
> @@ -202,8 +202,8 @@ my $Datei = "/var/ipfire/backup/".$_;
> my @Info = stat($Datei);
> my $Size = $Info[7] / 1024 / 1024;
> $Size = sprintf("%0.2f", $Size);
> -print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'}
> $Size MB</td><td width='5'><form method='post'
> action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION'
> value='download' /><input type='hidden' name='FILE' value='$_' /><input
> type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}'
> src='/images/package-x-generic.png' /></form></td>";
> -print "<td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input
> type='hidden' name='ACTION' value='delete' /><input type='hidden' name='FILE'
> value='$_' /><input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/user-trash.png' /></form></td></tr>";
> +print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'}
> $Size MB</td><td width='5'><form method='post'
> action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION'
> value='download' /><input type='hidden' name='FILE' value='$_' /><input
> type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}'
> src='/images/download.png' /></form></td>";
> +print "<td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input
> type='hidden' name='ACTION' value='delete' /><input type='hidden' name='FILE'
> value='$_' /><input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/delete.gif' /></form></td></tr>";
> }
> foreach (@backupisos){
> if ( $_ !~ /iso$/){next;}
> @@ -212,8 +212,8 @@ my $Datei = "/var/tmp/backupiso/".$_;
> my @Info = stat($Datei);
> my $Size = $Info[7] / 1024 / 1024;
> $Size = sprintf("%0.2f", $Size);
> -print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'}
> $Size MB</td><td width='5'><form method='post'
> action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION'
> value='downloadiso' /><input type='hidden' name='FILE' value='$_' /><input
> type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}'
> src='/images/package-x-generic.png' /></form></td>";
> -print "<td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input
> type='hidden' name='ACTION' value='delete' /><input type='hidden' name='FILE'
> value='$_' /><input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/user-trash.png' /></form></td></tr>";
> +print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'}
> $Size MB</td><td width='5'><form method='post'
> action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION'
> value='downloadiso' /><input type='hidden' name='FILE' value='$_' /><input
> type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}'
> src='/images/download.png' /></form></td>";
> +print "<td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input
> type='hidden' name='ACTION' value='delete' /><input type='hidden' name='FILE'
> value='$_' /><input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/delete.gif' /></form></td></tr>";
> }
> print <<END
> </table>
> @@ -258,14 +258,14 @@ print <<END
> <form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='hidden' name='ACTION' value='downloadaddon' />
> <input type='hidden' name='FILE' value='$_.ipf' />
> - <input type='image' alt='$Lang::tr{'download'}'
> title='$Lang::tr{'download'}' src='/images/package-x-generic.png' />
> + <input type='image' alt='$Lang::tr{'download'}'
> title='$Lang::tr{'download'}' src='/images/download.png' />
> </form>
> </td>
> <td align='right' width='5'>
> <form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='hidden' name='ACTION' value='delete' />
> <input type='hidden' name='FILE' value='$_.ipf' />
> - <input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/user-trash.png' />
> + <input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/delete.gif' />
> </form>
> </td>
> END
> @@ -279,7 +279,7 @@ print <<END
> <form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='hidden' name='ACTION' value='addonbackup' />
> <input type='hidden' name='ADDON' value='$_' />
> - <input type='image' alt='$Lang::tr{'backup'}'
> title='$Lang::tr{'backup'}' src='/images/document-save.png' />
> + <input type='image' alt='$Lang::tr{'backup'}'
> title='$Lang::tr{'backup'}' src='/images/media-floppy.png' />
> </form>
> </td></tr>
> END
> @@ -297,14 +297,14 @@ print <<END
> <form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='hidden' name='ACTION' value='downloadaddon' />
> <input type='hidden' name='FILE' value='$_.ipf' />
> - <input type='image' alt='$Lang::tr{'download'}'
> title='$Lang::tr{'download'}' src='/images/package-x-generic.png' />
> + <input type='image' alt='$Lang::tr{'download'}'
> title='$Lang::tr{'download'}' src='/images/download.png' />
> </form>
> </td>
> <td align='right' width='5'>
> <form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='hidden' name='ACTION' value='delete' />
> <input type='hidden' name='FILE' value='$_.ipf' />
> - <input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/user-trash.png' />
> + <input type='image' alt='$Lang::tr{'delete'}'
> title='$Lang::tr{'delete'}' src='/images/delete.gif' />
> </form>
> </td>
> <td align='right' width='5'></td></tr>
> @@ -323,8 +323,8 @@ print "</table>";
> print <<END
> <table width='95%' cellspacing='0'>
> <tr><td align='center' colspan='2'><font color='red'><br
> />$Lang::tr{'backupwarning'}</font><br /><br /></td></tr>
> -<tr><td align='left'>$Lang::tr{'backup'}</td><td align='left'><form
> method='post' enctype='multipart/form-data'
> action='$ENV{'SCRIPT_NAME'}'><input type="file" size='50' name="UPLOAD"
> /><input type='hidden' name='ACTION' value='restore' /><input type='hidden'
> name='FILE' /><input type='image' alt='$Lang::tr{'restore'}'
> title='$Lang::tr{'restore'}' src='/images/media-floppy.png'
> /></form></td></tr>
> -<tr><td align='left'>$Lang::tr{'backupaddon'}</td><td align='left'><form
> method='post' enctype='multipart/form-data'
> action='$ENV{'SCRIPT_NAME'}'><input type="file" size='50' name="UPLOAD"
> /><input type='hidden' name='ACTION' value='restoreaddon' /><input
> type='hidden' name='FILE' /><input type='image' alt='$Lang::tr{'restore'}'
> title='$Lang::tr{'restore'}' src='/images/media-floppy.png'
> /></form></td></tr>
> +<tr><td align='left'>$Lang::tr{'backup'}</td><td align='left'><form
> method='post' enctype='multipart/form-data'
> action='$ENV{'SCRIPT_NAME'}'><input type="file" size='50' name="UPLOAD"
> /><input type='hidden' name='ACTION' value='restore' /><input type='hidden'
> name='FILE' /><input type='image' alt='$Lang::tr{'restore'}'
> title='$Lang::tr{'restore'}' src='/images/restore.png' /></form></td></tr>
> +<tr><td align='left'>$Lang::tr{'backupaddon'}</td><td align='left'><form
> method='post' enctype='multipart/form-data'
> action='$ENV{'SCRIPT_NAME'}'><input type="file" size='50' name="UPLOAD"
> /><input type='hidden' name='ACTION' value='restoreaddon' /><input
> type='hidden' name='FILE' /><input type='image' alt='$Lang::tr{'restore'}'
> title='$Lang::tr{'restore'}' src='/images/restore.png' /></form></td></tr>
> </table>
> END
> ;
> diff --git a/html/html/images/download.png b/html/html/images/download.png
> new file mode 100644
> index
> 0000000000000000000000000000000000000000..6a12420a54eb0705aceb727ba47330a1ab91
> 1175
> GIT binary patch
> literal 646
> zcmV;10(t$3P)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV0006_Nkl<ZIE{^x
> zKWGzi6vsbzziUjIrcK)XF~O4l|A#FtU0lS)ML`rC6>)W|Q<q9XyNeD*X(tJSh=|~y
> z%|Xz`lR8<u*rLVSHkWJC<kIHue&>+1w3vWzdhhXlAHMJL6zaue=nh7_qpj8JrczI;
> z)dc{4zs6`RLCLQ0W5;YHYYb(a)fcQBTm#IOn&d&|IfU7gwp&?JI{PNWF>;xvh1LkGw9
> zns_z51dJcl=X=gzmJ58(a)_;ytGb?Nf*#6J#nUBCYz`Di?<Bq-Sy5r2sF!Y29sA`yRx
> zl5G*%Z{t>eYJ6c~;r=lPx~_K#Ay)f)M<~e>*FIk5dtsSVt#JU>3tJ4d46!(wK~w~<
> z-(a)K$)-0hy8o?bg}Fx$}{LkK~8pp9qeUeMLt!%B9ImFybn<{qA&eNH?SMbmtAc6MP|
> z)+~Uc>v~uSVfOcqAcWxe#vf9tI9bc!()$a<MUvaGJ9w5xz^^jU*G*x!Kqj+DKA(?h
> zz*I}H6(IxwspLuUAR37A>EdTR&qGRyD<!t=P^sAXntUV(a)DYDt@l%ngp>9}54RTLCO
> zsa~ZvB&Ec4U0mrR-CBNFyO^fAquI6{K0P{yq9`bE2&wzGz^1*4Eo{<(H1iMV!&)wv
> z1K{nu52!*#sA?6a)L=*6Wq2sf-1=RJ!rb6J48uS(3<H3z?HogcX(a)pQwRTWjOI-&*x
> zD3{9=_e%UK{=}6oxm>OaXb$+fdE?4|t&r(^QcWb-wv93~Gh;fA6LuU2$8io1C8fmk
> gJUq{9fC6CWFUS4*oKn&t!2kdN07*qoM6N<$f*4&i3;+NC
>
> literal 0
> HcmV?d00001
>
> diff --git a/html/html/images/restore.png b/html/html/images/restore.png
> new file mode 100644
> index
> 0000000000000000000000000000000000000000..6be95adaf7e9742b34f8afd94b3422dbef25
> e638
> GIT binary patch
> literal 459
> zcmV;+0W|)JP)<h;3K|Lk000e1NJLTq000;O000;W1^@s6;CDUv00004b3#c}2nYxW
> zd<bNS00009a7bBm000XU000XU0RWnu7ytkPZAnByR7i>K)z3;*K^zD0&vA2wOnLxu
> z(LxHZxM@`jkrL5*f?gyes|&qBJwOqP(YiPAA1J<nc3l~@RSPtN+hXS0aG870Ioi(a)M
> z40D+IeZSw|%$eT|*Z2=8(a)EEH&#BZFVjgOeWig**d=#;c=+^H-65I>{95uRZZjo6x4
> z!nYW6g4wF#lZp5WZVZSW!CGQcx{?AriFi>Vp&~KaDhpopZ(DMichJg=-^BMgfAQmo
> zGJ#KH{|>*(vPp0nIjKh0;C}4C)DZ8Y%Xu)!U(a)Z1uFJZ9Xqj7<j{%8DkPizN!n93Lo
> z$N96Id(PxlChm!_x<7b}TglvX<Q?P;dQD#T3la)#SvUln$@q)N{V;&570FdFj(hQY
> z6hETDTt$9m6!;v)H|h}I;FC~9{V<w{A7i4b_-&zhIzoj$7fwz?I4#q{o_Dw97&CRU
> zhr7a6Ty|Zr*U3DG1>tdN3lGkjP*m^n=qke3(a)E1{rYo;z~V&4D&002ovPDHLkV1j0b
> B$)NxM
>
> literal 0
> HcmV?d00001
>
next prev parent reply other threads:[~2018-09-29 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 17:52 Matthias Fischer
2018-09-29 10:04 ` Michael Tremer [this message]
2018-09-29 20:23 ` Matthias Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=893702af3196780d874d169489388fc5ed43feb5.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox