Re: [PATCH] setup: Fixes bug10245 - restarts non-local interfaces if no driver change

[Michael Tremer <michael.tremer@ipfire.org>]

Hello Adolf,

I am not sure that I follow the problem.

Why do we need to stop and start the network again later?

Would “non-local” not mean RED only?

-Michael

> On 18 Jun 2025, at 14:56, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - In the setup menu if the OK button is pressed when it asks if you want to change any
>   of the interfaces then the red, blue and orange interfaces are stopped. However if
>   none of the interfaces are changed then the network restart code does not get used.
> - This results in the system ending up with only the green interfrace being UP and
>   connected.
> - This is the first time I have done anything with c code so if my change is not
>   appropriate or there is a better way of doing it then I am fully open to suggestions.
> - I did test the code out on my vm testbed and it worked the way I expected it to but
>   that does not mean it is the right thing to do.
> - I also changed the text for the Network stop command from Restarting to Stopping as it
>   does not start the network again in all cases. The patch ends up now with the stop
>   message after the OK button has been pressed on the window showing the interfaces
>   that are available is shown. Then if no interface is changed and the Done button is
>   pressed the message about restarting the non-local network is shown.
> - If an interface is selected then the starting non-local network interfaces is not
>   shown as the full network start and unbound start will be carried out.
> 
> Fixes: bug10245
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> src/setup/networking.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/setup/networking.c b/src/setup/networking.c
> index 8d398f365..c380b1d34 100644
> --- a/src/setup/networking.c
> +++ b/src/setup/networking.c
> @@ -422,7 +422,7 @@ int changedrivers(void)
> }
> if (automode == 0)
> runcommandwithstatus("/etc/rc.d/init.d/network stop red blue orange",
> - _("Networking"), _("Restarting non-local network..."), NULL);
> + _("Networking"), _("Stopping non-local network..."), NULL);
> 
> findkey(kv, "CONFIG_TYPE", temp); configtype = atol(temp);
> if (configtype == 1)
> @@ -513,6 +513,10 @@ int changedrivers(void)
> }
> while ( rc <= 2);
> 
> + if ((automode == 0) && (netaddresschange == 0))
> + runcommandwithstatus("/etc/rc.d/init.d/network start red blue orange",
> + _("Networking"), _("Restarting non-local network..."), NULL);
> +
> freekeyvalues(kv);
> return 1;
> }
> -- 
> 2.49.0
> 
>