From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: GeoIP Blocked IPs not being logged
Date: Thu, 14 Feb 2019 11:14:54 +0000 [thread overview]
Message-ID: <8C75A51F-BCA4-4F9B-8681-BEF9A1D6E1C2@ipfire.org> (raw)
In-Reply-To: <q3pi8f$q5d$1@tuscan3.grantura.co.uk>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
Hey Rob,
Please only attach patches inline. That way, people can comment on them directly.
If I now write things like:
In the first file, line 12, something is not right there…
then nobody knows what I am referring to.
Best,
-Michael
> On 10 Feb 2019, at 16:07, Rob Brewer <ipfire-devel(a)grantura.co.uk> wrote:
>
> Hi Michael
>
> Rob Brewer wrote:
>
>>> However, I do not think that this is a bad idea, but it should be
>>> configurable on the firewall options page.
>>>
>> Yes I was thinking that this could be easily select-able with an if
>> statement around the LOG line if required.
>>
> OK I've been working on your suggestion and have added an additional
> checkbox to the GeoIP Block of geoip-block.cgi to enable/disable logging.
>
> (patch: geoip-block.cgi)
>
> I have also reworked rules.pl to enable geoip-block logging from geo-
> block.cgi.
>
> (patch: rules2.pl)
>
> Rob
> <geoip-block.cgi><rules2.pl>
prev parent reply other threads:[~2019-02-14 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 21:08 Rob Brewer
2019-02-06 17:18 ` Michael Tremer
2019-02-06 21:48 ` Rob Brewer
2019-02-10 16:07 ` Rob Brewer
2019-02-14 11:14 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8C75A51F-BCA4-4F9B-8681-BEF9A1D6E1C2@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox