From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: GeoIP Blocked IPs not being logged
Date: Thu, 14 Feb 2019 11:14:54 +0000
Message-ID: <8C75A51F-BCA4-4F9B-8681-BEF9A1D6E1C2@ipfire.org>
In-Reply-To: <q3pi8f$q5d$1@tuscan3.grantura.co.uk>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0860227651108343653=="
List-Id: <development.lists.ipfire.org>

--===============0860227651108343653==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hey Rob,

Please only attach patches inline. That way, people can comment on them direc=
tly.

If I now write things like:

  In the first file, line 12, something is not right there=E2=80=A6

then nobody knows what I am referring to.

Best,
-Michael

> On 10 Feb 2019, at 16:07, Rob Brewer <ipfire-devel(a)grantura.co.uk> wrote:
>=20
> Hi Michael
>=20
> Rob Brewer wrote:
>=20
>>> However, I do not think that this is a bad idea, but it should be
>>> configurable on the firewall options page.
>>>=20
>> Yes I was thinking that this could be easily select-able with an if
>> statement around the LOG line if required.
>>=20
> OK I've been working on your suggestion and have added an additional =20
> checkbox to the GeoIP Block of  geoip-block.cgi to enable/disable logging.
>=20
> (patch: geoip-block.cgi)
>=20
> I have also reworked rules.pl to enable geoip-block logging from geo-
> block.cgi.
>=20
> (patch: rules2.pl)
>=20
> Rob
> <geoip-block.cgi><rules2.pl>


--===============0860227651108343653==--