From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 05/13] kernel: Disable SLUB debugging
Date: Tue, 21 Sep 2021 10:42:16 +0100 [thread overview]
Message-ID: <8D766587-AB6D-42B3-8AAA-1082F139DA5A@ipfire.org> (raw)
In-Reply-To: <4938e18c-02b8-19c5-9175-aab827159d87@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 5203 bytes --]
Hello,
> On 18 Sep 2021, at 17:27, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Hello Michael,
> hello *,
>
> at the time of writing, I agree.
>
> Cross-check hardening features of kernel 5.10.x is an item still open on my todo list, and
> I will hopefully have some spare time for this next month. I will reevaluate SLUB debugging
> then as well, since kernsec mentions this to be necessary for some page poisoning options
> (whyever that is...).
Err. No. Why?
We want the distribution to be stable. And that means that we want to make consistent and long-standing changes.
Changing something back and forth for no reason apart from not having enough time to look into things properly right now is not what I would consider “stable”.
We can either drop this patch (i.e. NACK by you), or we can accept it and leave it.
As far as I can see this debugging option didn’t add any other configuration options that would be otherwise unavailable; and it significantly decreases the size of the memory allocator which should result in performance gains on smaller hardware with smaller CPU caches:
https://cateee.net/lkddb/web-lkddb/SLUB_DEBUG.html
-Michael
>
> Acked-by: Peter Müller <peter.mueller(a)ipfire.org>
>
> Thanks, and best regards,
> Peter Müller
>
>
>> This is not necessary on our systems and according to the documentation
>> will reduce code size of the allocator which will result in better
>> performance.
>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
>> ---
>> config/kernel/kernel.config.aarch64-ipfire | 3 +--
>> config/kernel/kernel.config.armv6l-ipfire | 3 +--
>> config/kernel/kernel.config.i586-ipfire | 3 +--
>> config/kernel/kernel.config.x86_64-ipfire | 3 +--
>> 4 files changed, 4 insertions(+), 8 deletions(-)
>> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/kernel.config.aarch64-ipfire
>> index d0ec69ba9..b277a17b5 100644
>> --- a/config/kernel/kernel.config.aarch64-ipfire
>> +++ b/config/kernel/kernel.config.aarch64-ipfire
>> @@ -226,7 +226,7 @@ CONFIG_PERF_EVENTS=y
>> # end of Kernel Performance Events And Counters
>> CONFIG_VM_EVENT_COUNTERS=y
>> -CONFIG_SLUB_DEBUG=y
>> +# CONFIG_SLUB_DEBUG is not set
>> # CONFIG_SLUB_MEMCG_SYSFS_ON is not set
>> # CONFIG_COMPAT_BRK is not set
>> # CONFIG_SLAB is not set
>> @@ -7751,7 +7751,6 @@ CONFIG_GENERIC_PTDUMP=y
>> CONFIG_PTDUMP_CORE=y
>> # CONFIG_PTDUMP_DEBUGFS is not set
>> # CONFIG_DEBUG_OBJECTS is not set
>> -# CONFIG_SLUB_DEBUG_ON is not set
>> # CONFIG_SLUB_STATS is not set
>> CONFIG_HAVE_DEBUG_KMEMLEAK=y
>> # CONFIG_DEBUG_KMEMLEAK is not set
>> diff --git a/config/kernel/kernel.config.armv6l-ipfire b/config/kernel/kernel.config.armv6l-ipfire
>> index a23906796..9d63b36ac 100644
>> --- a/config/kernel/kernel.config.armv6l-ipfire
>> +++ b/config/kernel/kernel.config.armv6l-ipfire
>> @@ -227,7 +227,7 @@ CONFIG_PERF_EVENTS=y
>> # end of Kernel Performance Events And Counters
>> CONFIG_VM_EVENT_COUNTERS=y
>> -CONFIG_SLUB_DEBUG=y
>> +# CONFIG_SLUB_DEBUG is not set
>> # CONFIG_SLUB_MEMCG_SYSFS_ON is not set
>> # CONFIG_COMPAT_BRK is not set
>> # CONFIG_SLAB is not set
>> @@ -7826,7 +7826,6 @@ CONFIG_DEBUG_MISC=y
>> # CONFIG_DEBUG_RODATA_TEST is not set
>> # CONFIG_DEBUG_WX is not set
>> # CONFIG_DEBUG_OBJECTS is not set
>> -# CONFIG_SLUB_DEBUG_ON is not set
>> # CONFIG_SLUB_STATS is not set
>> CONFIG_HAVE_DEBUG_KMEMLEAK=y
>> # CONFIG_DEBUG_KMEMLEAK is not set
>> diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel.config.i586-ipfire
>> index 9c49a90d8..56b40eac7 100644
>> --- a/config/kernel/kernel.config.i586-ipfire
>> +++ b/config/kernel/kernel.config.i586-ipfire
>> @@ -235,7 +235,7 @@ CONFIG_PERF_EVENTS=y
>> # end of Kernel Performance Events And Counters
>> CONFIG_VM_EVENT_COUNTERS=y
>> -CONFIG_SLUB_DEBUG=y
>> +# CONFIG_SLUB_DEBUG is not set
>> # CONFIG_COMPAT_BRK is not set
>> # CONFIG_SLAB is not set
>> CONFIG_SLUB=y
>> @@ -7383,7 +7383,6 @@ CONFIG_GENERIC_PTDUMP=y
>> CONFIG_PTDUMP_CORE=y
>> # CONFIG_PTDUMP_DEBUGFS is not set
>> # CONFIG_DEBUG_OBJECTS is not set
>> -# CONFIG_SLUB_DEBUG_ON is not set
>> # CONFIG_SLUB_STATS is not set
>> CONFIG_HAVE_DEBUG_KMEMLEAK=y
>> # CONFIG_DEBUG_KMEMLEAK is not set
>> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
>> index 0a1f67074..8247e9b48 100644
>> --- a/config/kernel/kernel.config.x86_64-ipfire
>> +++ b/config/kernel/kernel.config.x86_64-ipfire
>> @@ -245,7 +245,7 @@ CONFIG_PERF_EVENTS=y
>> # end of Kernel Performance Events And Counters
>> CONFIG_VM_EVENT_COUNTERS=y
>> -CONFIG_SLUB_DEBUG=y
>> +# CONFIG_SLUB_DEBUG is not set
>> # CONFIG_COMPAT_BRK is not set
>> # CONFIG_SLAB is not set
>> CONFIG_SLUB=y
>> @@ -7249,7 +7249,6 @@ CONFIG_GENERIC_PTDUMP=y
>> CONFIG_PTDUMP_CORE=y
>> # CONFIG_PTDUMP_DEBUGFS is not set
>> # CONFIG_DEBUG_OBJECTS is not set
>> -# CONFIG_SLUB_DEBUG_ON is not set
>> # CONFIG_SLUB_STATS is not set
>> CONFIG_HAVE_DEBUG_KMEMLEAK=y
>> # CONFIG_DEBUG_KMEMLEAK is not set
next prev parent reply other threads:[~2021-09-21 9:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 11:42 [PATCH 01/13] kernel: Change timer tick to 1000Hz Michael Tremer
2021-09-17 11:42 ` [PATCH 02/13] kernel: Disable suspending systems to RAM Michael Tremer
2021-09-18 16:09 ` Peter Müller
2021-09-17 11:42 ` [PATCH 03/13] kernel: Disable IRQ time accounting Michael Tremer
2021-09-18 16:10 ` Peter Müller
2021-09-17 11:42 ` [PATCH 04/13] kernel: Enable Pressure Stall Information Michael Tremer
2021-09-18 16:16 ` Peter Müller
2021-09-17 11:42 ` [PATCH 05/13] kernel: Disable SLUB debugging Michael Tremer
2021-09-18 16:27 ` Peter Müller
2021-09-21 9:42 ` Michael Tremer [this message]
2021-09-17 11:42 ` [PATCH 06/13] kernel: Disable any runtime testing Michael Tremer
2021-09-18 16:24 ` Peter Müller
2021-09-17 11:42 ` [PATCH 07/13] kernel: Disable OpenvSwitch Michael Tremer
2021-09-18 16:10 ` Peter Müller
2021-09-17 11:42 ` [PATCH 08/13] kernel: Disable network security hooks Michael Tremer
2021-09-18 16:23 ` Peter Müller
2021-09-17 11:42 ` [PATCH 09/13] kernel: Enable frontswap Michael Tremer
2021-09-18 16:20 ` Peter Müller
2021-09-17 11:42 ` [PATCH 10/13] kernel: Enable ExFAT on all architectures Michael Tremer
2021-09-18 16:10 ` Peter Müller
2021-09-20 13:48 ` Adolf Belka
2021-09-17 11:42 ` [PATCH 11/13] kernel: Enable support for TPM hardware Michael Tremer
2021-09-18 16:15 ` Peter Müller
2021-09-21 9:50 ` Michael Tremer
2021-09-21 11:40 ` Adolf Belka
2021-09-21 12:31 ` Adolf Belka
2021-10-01 17:25 ` Michael Tremer
2021-09-17 11:42 ` [PATCH 12/13] kernel: Zero-init all stack variables by default Michael Tremer
2021-09-18 16:11 ` Peter Müller
2021-09-21 9:50 ` Michael Tremer
2021-09-17 11:42 ` [PATCH 13/13] kernel: Enable all cgroups on all architectures Michael Tremer
2021-09-18 16:15 ` Peter Müller
2021-09-18 16:09 ` [PATCH 01/13] kernel: Change timer tick to 1000Hz Peter Müller
-- strict thread matches above, loose matches on Subject: below --
2021-09-07 15:02 Michael Tremer
2021-09-07 15:02 ` [PATCH 05/13] kernel: Disable SLUB debugging Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8D766587-AB6D-42B3-8AAA-1082F139DA5A@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox