From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH 05/13] kernel: Disable SLUB debugging Date: Tue, 21 Sep 2021 10:42:16 +0100 Message-ID: <8D766587-AB6D-42B3-8AAA-1082F139DA5A@ipfire.org> In-Reply-To: <4938e18c-02b8-19c5-9175-aab827159d87@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4495612976683318233==" List-Id: --===============4495612976683318233== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, > On 18 Sep 2021, at 17:27, Peter M=C3=BCller wr= ote: >=20 > Hello Michael, > hello *, >=20 > at the time of writing, I agree. >=20 > Cross-check hardening features of kernel 5.10.x is an item still open on my= todo list, and > I will hopefully have some spare time for this next month. I will reevaluat= e SLUB debugging > then as well, since kernsec mentions this to be necessary for some page poi= soning options > (whyever that is...). Err. No. Why? We want the distribution to be stable. And that means that we want to make co= nsistent and long-standing changes. Changing something back and forth for no reason apart from not having enough = time to look into things properly right now is not what I would consider =E2= =80=9Cstable=E2=80=9D. We can either drop this patch (i.e. NACK by you), or we can accept it and lea= ve it. As far as I can see this debugging option didn=E2=80=99t add any other config= uration options that would be otherwise unavailable; and it significantly dec= reases the size of the memory allocator which should result in performance ga= ins on smaller hardware with smaller CPU caches: https://cateee.net/lkddb/web-lkddb/SLUB_DEBUG.html -Michael >=20 > Acked-by: Peter M=C3=BCller >=20 > Thanks, and best regards, > Peter M=C3=BCller >=20 >=20 >> This is not necessary on our systems and according to the documentation >> will reduce code size of the allocator which will result in better >> performance. >> Signed-off-by: Michael Tremer >> --- >> config/kernel/kernel.config.aarch64-ipfire | 3 +-- >> config/kernel/kernel.config.armv6l-ipfire | 3 +-- >> config/kernel/kernel.config.i586-ipfire | 3 +-- >> config/kernel/kernel.config.x86_64-ipfire | 3 +-- >> 4 files changed, 4 insertions(+), 8 deletions(-) >> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/ke= rnel.config.aarch64-ipfire >> index d0ec69ba9..b277a17b5 100644 >> --- a/config/kernel/kernel.config.aarch64-ipfire >> +++ b/config/kernel/kernel.config.aarch64-ipfire >> @@ -226,7 +226,7 @@ CONFIG_PERF_EVENTS=3Dy >> # end of Kernel Performance Events And Counters >> CONFIG_VM_EVENT_COUNTERS=3Dy >> -CONFIG_SLUB_DEBUG=3Dy >> +# CONFIG_SLUB_DEBUG is not set >> # CONFIG_SLUB_MEMCG_SYSFS_ON is not set >> # CONFIG_COMPAT_BRK is not set >> # CONFIG_SLAB is not set >> @@ -7751,7 +7751,6 @@ CONFIG_GENERIC_PTDUMP=3Dy >> CONFIG_PTDUMP_CORE=3Dy >> # CONFIG_PTDUMP_DEBUGFS is not set >> # CONFIG_DEBUG_OBJECTS is not set >> -# CONFIG_SLUB_DEBUG_ON is not set >> # CONFIG_SLUB_STATS is not set >> CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy >> # CONFIG_DEBUG_KMEMLEAK is not set >> diff --git a/config/kernel/kernel.config.armv6l-ipfire b/config/kernel/ker= nel.config.armv6l-ipfire >> index a23906796..9d63b36ac 100644 >> --- a/config/kernel/kernel.config.armv6l-ipfire >> +++ b/config/kernel/kernel.config.armv6l-ipfire >> @@ -227,7 +227,7 @@ CONFIG_PERF_EVENTS=3Dy >> # end of Kernel Performance Events And Counters >> CONFIG_VM_EVENT_COUNTERS=3Dy >> -CONFIG_SLUB_DEBUG=3Dy >> +# CONFIG_SLUB_DEBUG is not set >> # CONFIG_SLUB_MEMCG_SYSFS_ON is not set >> # CONFIG_COMPAT_BRK is not set >> # CONFIG_SLAB is not set >> @@ -7826,7 +7826,6 @@ CONFIG_DEBUG_MISC=3Dy >> # CONFIG_DEBUG_RODATA_TEST is not set >> # CONFIG_DEBUG_WX is not set >> # CONFIG_DEBUG_OBJECTS is not set >> -# CONFIG_SLUB_DEBUG_ON is not set >> # CONFIG_SLUB_STATS is not set >> CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy >> # CONFIG_DEBUG_KMEMLEAK is not set >> diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kerne= l.config.i586-ipfire >> index 9c49a90d8..56b40eac7 100644 >> --- a/config/kernel/kernel.config.i586-ipfire >> +++ b/config/kernel/kernel.config.i586-ipfire >> @@ -235,7 +235,7 @@ CONFIG_PERF_EVENTS=3Dy >> # end of Kernel Performance Events And Counters >> CONFIG_VM_EVENT_COUNTERS=3Dy >> -CONFIG_SLUB_DEBUG=3Dy >> +# CONFIG_SLUB_DEBUG is not set >> # CONFIG_COMPAT_BRK is not set >> # CONFIG_SLAB is not set >> CONFIG_SLUB=3Dy >> @@ -7383,7 +7383,6 @@ CONFIG_GENERIC_PTDUMP=3Dy >> CONFIG_PTDUMP_CORE=3Dy >> # CONFIG_PTDUMP_DEBUGFS is not set >> # CONFIG_DEBUG_OBJECTS is not set >> -# CONFIG_SLUB_DEBUG_ON is not set >> # CONFIG_SLUB_STATS is not set >> CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy >> # CONFIG_DEBUG_KMEMLEAK is not set >> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/ker= nel.config.x86_64-ipfire >> index 0a1f67074..8247e9b48 100644 >> --- a/config/kernel/kernel.config.x86_64-ipfire >> +++ b/config/kernel/kernel.config.x86_64-ipfire >> @@ -245,7 +245,7 @@ CONFIG_PERF_EVENTS=3Dy >> # end of Kernel Performance Events And Counters >> CONFIG_VM_EVENT_COUNTERS=3Dy >> -CONFIG_SLUB_DEBUG=3Dy >> +# CONFIG_SLUB_DEBUG is not set >> # CONFIG_COMPAT_BRK is not set >> # CONFIG_SLAB is not set >> CONFIG_SLUB=3Dy >> @@ -7249,7 +7249,6 @@ CONFIG_GENERIC_PTDUMP=3Dy >> CONFIG_PTDUMP_CORE=3Dy >> # CONFIG_PTDUMP_DEBUGFS is not set >> # CONFIG_DEBUG_OBJECTS is not set >> -# CONFIG_SLUB_DEBUG_ON is not set >> # CONFIG_SLUB_STATS is not set >> CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy >> # CONFIG_DEBUG_KMEMLEAK is not set --===============4495612976683318233==--