From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] core177: remove rngd if the addon was not installed via pakfire
Date: Fri, 28 Jul 2023 18:20:07 +0100 [thread overview]
Message-ID: <8DCD88EF-B660-4032-8D31-DBD9EEE35F3B@ipfire.org> (raw)
In-Reply-To: <e09f3dd2-c295-6c05-e197-0356f6f3fba2@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]
Thank you. Already caught it:
https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=d4781c29aeb8f5ae2323c445142e48b303fd09e5
-Michael
> On 28 Jul 2023, at 17:52, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>
> Hi Arne,
>
> See my feedback below.
>
>
> On 28/07/2023 18:19, Arne Fitzenreiter wrote:
>> the old version is linked against the old openssl and will fail.
>>
>> fixes: #13197
>>
>> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
>> ---
>> config/rootfiles/core/177/update.sh | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/config/rootfiles/core/177/update.sh b/config/rootfiles/core/177/update.sh
>> index 818079940..2347afbdb 100644
>> --- a/config/rootfiles/core/177/update.sh
>> +++ b/config/rootfiles/core/177/update.sh
>> @@ -97,6 +97,15 @@ rm -f \
>> /opt/pakfire/db/meta/meta-squidclamav \
>> /opt/pakfire/db/rootfiles/squidclamav
>> +# remove old rngd if the addon is not installed
>> +if [ ! -e "/opt/pakfire/db/installed/meta-rng-tools" ]; then
>> + rm -rf /usr/bin/randstat \
>> + /usr/bin/rngtest \
>> + /usr/sbin/rngd \
>> + /etc/rc.d/init.d/rngd \
>> + /etc/rc.d/rc?.d/*rmgd
> I think this is a typo. should be *rngd
>
> Regards,
> Adolf.
>> +fi
>> +
>> # Extract files
>> extract_files
>> @@ -168,3 +177,4 @@ sync
>> # Don't report the exitcode last command
>> exit 0
>> +
>
> --
> Sent from my laptop
prev parent reply other threads:[~2023-07-28 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 16:19 Arne Fitzenreiter
2023-07-28 16:52 ` Adolf Belka
2023-07-28 17:20 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8DCD88EF-B660-4032-8D31-DBD9EEE35F3B@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox