From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] updatexlrator.cgi: Fix max disk usage input size
Date: Thu, 12 Aug 2021 11:31:40 +0100 [thread overview]
Message-ID: <8E120A86-67BA-4206-BCCA-3E2E2D33B54D@ipfire.org> (raw)
In-Reply-To: <20210812095148.855-1-hofmann@leo-andres.de>
[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]
Odd, that this was set to one.
Thank you for looking into this problem.
-Michael
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 12 Aug 2021, at 10:51, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrote:
>
> Increase to 3 digits to fit a percentage number.
>
> Fixes: #12675
>
> Reported-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/cgi-bin/updatexlrator.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi
> index 9cfe08f4e..4d5cc1370 100644
> --- a/html/cgi-bin/updatexlrator.cgi
> +++ b/html/cgi-bin/updatexlrator.cgi
> @@ -398,7 +398,7 @@ print <<END
> <td class='base'>$Lang::tr{'updxlrtr passive mode'}:</td>
> <td class='base'><input type='checkbox' name='PASSIVE_MODE' $checked{'PASSIVE_MODE'}{'on'} /></td>
> <td class='base'>$Lang::tr{'updxlrtr max disk usage'}: <img src='/blob.gif' alt='*' /></td>
> - <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='1' /> %</td>
> + <td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='3' /> %</td>
> </tr>
> </table>
> <hr size='1'>
> --
> 2.27.0.windows.1
>
next prev parent reply other threads:[~2021-08-12 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 9:51 Leo-Andres Hofmann
2021-08-12 10:31 ` Michael Tremer [this message]
2021-08-12 19:01 ` Bernhard Bitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8E120A86-67BA-4206-BCCA-3E2E2D33B54D@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox