From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: The unshared changes give a problem with build after doing git
 pull on next
Date: Thu, 29 Aug 2024 09:41:19 +0200
Message-ID: <8FD2349C-F3E1-4008-ACBA-5112CD0C6A98@ipfire.org>
In-Reply-To: <bf9c2036-82e5-4bc6-8c81-9d8024b6b216@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8185055593665662243=="
List-Id: <development.lists.ipfire.org>

--===============8185055593665662243==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Correct.

> On 28 Aug 2024, at 20:28, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> On 28.08.2024 19:52, Adolf Belka wrote:
>> Hi All,
>>=20
>> On 28/08/2024 18:30, Matthias Fischer wrote:
>>> On 28.08.2024 17:46, Michael Tremer wrote:
>>>> Hello everyone,
>>> Hi,
>>>=20
>>>> Could you please confirm that this works:
>>>>=20
>>>>   https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D5e8730eb=
9aec83a76b3ae7719925ede8470069a6
>>=20
>> I don't know if the problem is because of the above commit but coreutils f=
ails to build. It appears to be not finding aclocal-1.16
>=20
> IMHO 'automake 1.16.5 =3D> 1.17' must be the culprit...
>=20
>>=20
>> It built fine yesterday so the problem must be one of the updates that was=
 in the git pull I did today.
>=20
> Just a quick test: went back to 'automake 1.16.5'. Build runs.
>=20
> Best
> Matthias
>=20
>>=20
>>=20
>> Regards,
>>=20
>> Adolf.
>>=20
>>> For me it does.
>>>=20
>>>> It works for me on Ubuntu 22.04 LTS with kernel 5.15.
>>> Here:
>>> Ubuntu 22.04 LTS / 6.8.0-40-generic
>>>=20
>>> I tested 'make.sh' with all important parameters (clean, downloadsrc,
>>> gettoolchain) - right now a 'next'-build is running and looking good -
>>> I'll report when its ready. ;-)
>>>=20
>>> Best
>>> Matthias
>>>=20
>>>> There is also another fix to support kernels without time namespaces (< =
5.6). However, I am not sure if the built itself runs through on this and doe=
s not require anything more recent:
>>>>=20
>>>>   https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3Dfaccfa70=
754fabaed56c9147ace4d509f7d2317c
>>>>=20
>>>> -Michael
>>>>=20
>>>>> On 27 Aug 2024, at 20:03, / / <siosios1(a)hotmail.com> wrote:
>>>>>=20
>>>>> I can concur that moving the line to where Matthias put it does fix the=
 issues on my machines with downloading and building, it also takes care of t=
he error ->  mount: /git/ipfire-2.x/build_x86_64/proc: mount point does not e=
xist from what I am seeing.
>>>>>=20
>>>>> # If unshare is asked to terminate, terminate all child processes
>>>>>   "--kill-child"
>>>>>  )
>>>>>=20
>>>>> mount --bind ${BUILD_DIR}/proc ${BUILD_DIR}/proc
>>>>>=20
>>>>> fi
>>>>>=20
>>>>> while [ $# -gt 0 ]; do
>>>>>=20
>>>>> one thing I don't see is the mount when i check the output of mount or =
the output of findmnt -o+PROPAGATION
>=20


--===============8185055593665662243==--