From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] New package: IPTraffic 0.8.2
Date: Mon, 25 Jan 2021 20:48:10 +0000
Message-ID: <8FF22F1B-04FF-421D-92D7-70E408059B3C@ipfire.org>
In-Reply-To: <2cc215c55a63d98924de4db8780ebf7ca89aefd7.camel@cybermainzel.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4978948742817909033=="
List-Id: <development.lists.ipfire.org>

--===============4978948742817909033==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Frank,

> On 25 Jan 2021, at 20:22, Frank Mainz <frank(a)cybermainzel.de> wrote:
>=20
> Am Montag, den 25.01.2021, 20:05 +0000 schrieb Michael Tremer:
>> Hi Frank,
>>=20
>> Thank you for your email, but it didn=E2=80=99t answer any of my questions.
>>=20
>> I wasn=E2=80=99t aware of the wiki pages, but I had a look at it.
>>=20
>> The questions from my previous email remain though. I do not think a
>> single one was answered.
>=20
> That is not my problem.

Okay, I am sorry, but I would have to vote to reject this patch then.

It is very important that we review all code that is going into the distribut=
ion and that we have a reason that it is there. Code that is redundant, not n=
eeded and unmaintained is a potential security problem. I am sure this is ver=
y easy to understand.

Also, you can read here what it takes to get your patches into the distributi=
on:

  https://wiki.ipfire.org/devel/submit-patches

This is not there for our own entertainment. It is a tested and tuned process=
 which guarantees that IPFire is a product of very high quality.

>>> On 25 Jan 2021, at 19:51, Frank Mainz <frank(a)cybermainzel.de>
>>> wrote:
>>>=20
>>> Hello Michael,
>>>=20
>>> look in the WIKI and you know what is displayed. Otherwise, the
>>> traffic
>>> of individual IP addresses is logged with the help of entries in
>>> the
>>> CUSTOM chains and graphically prepared.
>>=20
>> The CUSTOM* chains can=E2=80=99t be touched by any programs that come with
>> the distributions. They exist for users to add any custom rules and
>> they are under full control by the user only.
>=20
> Then it does fit.

No, it doesn=E2=80=99t, because you are not the user of all those firewalls.

Every chain has a defined purpose, and you are using it for something it isn=
=E2=80=99t designed for and it will break setups.

>>> https://wiki.ipfire.org/addons/iptraffic-playground
>>>=20
>>>=20
>>> Greetings Frank
>>>=20
>>> PS: Fullquote removed
>>=20
>> Why? I don=E2=80=99t recommend doing this because it removes context from =
the
>> conversation.
>>=20
>> Best,
>> -Michael
>=20
> Then be careful next time not to quote >100 lines of source code. How
> this is supposed to preserve context is beyond me.

Because we write comments into the code. And we normally try to answer other =
people=E2=80=99s questions.

Do not forget that many people are reading this list and they do not devote a=
 lot of time to get themselves involved in everything. Therefore things have =
to be understood at a quick glance.

> But do what you want. Exactly because of such reactions I didn't want
> to port the AddOn for IPFire.

I have absolutely no idea why you are reacting like this. The process is clea=
r and I am here to make IPFire as good as I can possibly do.

I have simply asked what your code is and what it does. You seem to not want =
to answer those questions and why is unfortunately beyond me.

> Have a nice life. I am out.

Under those circumstances I must say that I find it very disappointing that y=
ou have wasted my time and Matthias=E2=80=99 time, too. I have re-read my ema=
il and I do not see why this might have caused any offence.

I assume that nobody else wants to push this forward any more and maintain th=
is code?

-Michael

--===============4978948742817909033==--