From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] util-linux: Do not ship broken symlink "/usr/bin/x86_64" Date: Tue, 12 Jul 2022 10:42:59 +0000 Message-ID: <8ac932ab-f9f4-101a-a6a5-1fbbb8c5b9a1@ipfire.org> In-Reply-To: <9EDD4D00-5DB1-43D4-8E88-7DCB0829F276@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1328123018718375220==" List-Id: --===============1328123018718375220== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Okay, then I'll vote for dropping the broken symlink, as nobody has asked for= "setarch" in years. > Oh no, we should of course ship setarch or drop x86_64. Either or the other. >=20 > I missed that we were talking about a *broken* symlink here. >=20 >> On 12 Jul 2022, at 11:44, Peter M=C3=BCller w= rote: >> >> Hello Michael, >> >> thanks for your reply. >> >>> Hello, >>> >>> Err, yes, but what do we gain from dropping this? >> >> Well, shipping a broken symlink did not seem to serve any purpose to me. O= r were >> you referring to not shipping /usr/bin/setarch? >> >> Thanks, and best regards, >> Peter M=C3=BCller >> >>> >>> Does it hurt us to be compatible with any general purpose distribution? >>> >>> -Michael >>> >>>> On 9 Jul 2022, at 14:37, Peter M=C3=BCller = wrote: >>>> >>>> This file points to /usr/bin/setarch, which we do not ship on any >>>> architecture. As it serves no obvious purpose on IPFire installations, >>>> we may as well not ship it entirely. >>>> >>>> Signed-off-by: Peter M=C3=BCller >>>> --- >>>> config/rootfiles/common/x86_64/util-linux | 2 +- >>>> config/rootfiles/core/170/update.sh | 1 + >>>> 2 files changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfile= s/common/x86_64/util-linux >>>> index bd862b557..de78f65c2 100644 >>>> --- a/config/rootfiles/common/x86_64/util-linux >>>> +++ b/config/rootfiles/common/x86_64/util-linux >>>> @@ -103,7 +103,7 @@ usr/bin/uclampset >>>> usr/bin/uuidgen >>>> usr/bin/uuidparse >>>> #usr/bin/whereis >>>> -usr/bin/x86_64 >>>> +#usr/bin/x86_64 >>>> #usr/include/blkid >>>> #usr/include/blkid/blkid.h >>>> #usr/include/libfdisk >>>> diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core= /170/update.sh >>>> index e3f93df57..5d8903189 100644 >>>> --- a/config/rootfiles/core/170/update.sh >>>> +++ b/config/rootfiles/core/170/update.sh >>>> @@ -57,6 +57,7 @@ rm -rvf \ >>>> /sbin/ifcfg \ >>>> /sbin/routef \ >>>> /sbin/rtpr \ >>>> + /usr/bin/x86_64 \ >>>> /usr/lib/libbfd-2.36.* \ >>>> /usr/lib/libbind9-9.16.2* \ >>>> /usr/lib/libdnet* \ >>>> --=20 >>>> 2.35.3 >>> >=20 --===============1328123018718375220==--