public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] HTML: Add language attribute
Date: Sun, 24 Apr 2022 14:04:37 +0000	[thread overview]
Message-ID: <8c0f2cf5-3950-cde8-0eb2-a2a7bb228391@ipfire.org> (raw)
In-Reply-To: <20220424104316.407-1-hofmann@leo-andres.de>

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Thank you for giving the web interface some love and care. :-)

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> This attribute is recommended by W3C, because it is used by
> screen readers to provide the correct pronunciation.
> 
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>  html/html/themes/ipfire/include/functions.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/html/themes/ipfire/include/functions.pl b/html/html/themes/ipfire/include/functions.pl
> index d74c962e4..8485996a2 100644
> --- a/html/html/themes/ipfire/include/functions.pl
> +++ b/html/html/themes/ipfire/include/functions.pl
> @@ -117,7 +117,7 @@ sub openpage {
>  
>  print <<END;
>  <!DOCTYPE html>
> -<html>
> +<html lang="$language">
>  	<head>
>  	<title>$headline - $title</title>
>  	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>

      reply	other threads:[~2022-04-24 14:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-24 10:43 Leo-Andres Hofmann
2022-04-24 14:04 ` Peter Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c0f2cf5-3950-cde8-0eb2-a2a7bb228391@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox