public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* [PATCH] HTML: Add language attribute
@ 2022-04-24 10:43 Leo-Andres Hofmann
  2022-04-24 14:04 ` Peter Müller
  0 siblings, 1 reply; 2+ messages in thread
From: Leo-Andres Hofmann @ 2022-04-24 10:43 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

This attribute is recommended by W3C, because it is used by
screen readers to provide the correct pronunciation.

Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
---
 html/html/themes/ipfire/include/functions.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/html/themes/ipfire/include/functions.pl b/html/html/themes/ipfire/include/functions.pl
index d74c962e4..8485996a2 100644
--- a/html/html/themes/ipfire/include/functions.pl
+++ b/html/html/themes/ipfire/include/functions.pl
@@ -117,7 +117,7 @@ sub openpage {
 
 print <<END;
 <!DOCTYPE html>
-<html>
+<html lang="$language">
 	<head>
 	<title>$headline - $title</title>
 	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
-- 
2.27.0.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] HTML: Add language attribute
  2022-04-24 10:43 [PATCH] HTML: Add language attribute Leo-Andres Hofmann
@ 2022-04-24 14:04 ` Peter Müller
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Müller @ 2022-04-24 14:04 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Thank you for giving the web interface some love and care. :-)

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> This attribute is recommended by W3C, because it is used by
> screen readers to provide the correct pronunciation.
> 
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>  html/html/themes/ipfire/include/functions.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/html/themes/ipfire/include/functions.pl b/html/html/themes/ipfire/include/functions.pl
> index d74c962e4..8485996a2 100644
> --- a/html/html/themes/ipfire/include/functions.pl
> +++ b/html/html/themes/ipfire/include/functions.pl
> @@ -117,7 +117,7 @@ sub openpage {
>  
>  print <<END;
>  <!DOCTYPE html>
> -<html>
> +<html lang="$language">
>  	<head>
>  	<title>$headline - $title</title>
>  	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-24 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 10:43 [PATCH] HTML: Add language attribute Leo-Andres Hofmann
2022-04-24 14:04 ` Peter Müller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox