Re: [PATCH] core177: Do not ship location database extracted in ipset format

["Peter Müller" <peter.mueller@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Thank you for raising this, I'll pay attention to it for future Core Updates.

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> Since the update is not built on the day when people install it, we will
> ship an outdated database. For updates, where the firewall is being
> reloaded or rebooted, we will have an old database in place until the
> next database update job runs.
> 
> Secondly, the data is 33 MiB in size, which is useless data shipped as
> every system will already have a database that is very likely to be more
> recent.
> 
> In this update, we are not shipping the location database again, but I
> wanted to add this change so it does not get lost next time.
> 
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  config/rootfiles/core/177/exclude | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/config/rootfiles/core/177/exclude b/config/rootfiles/core/177/exclude
> index 378c2d563..8ee1c3c2f 100644
> --- a/config/rootfiles/core/177/exclude
> +++ b/config/rootfiles/core/177/exclude
> @@ -27,6 +27,7 @@ var/ipfire/urlfilter/blacklist
>  var/ipfire/urlfilter/settings
>  var/lib/alternatives
>  var/lib/location/database.db
> +var/lib/location/ipset
>  var/log/cache
>  var/log/dhcpcd.log
>  var/log/messages