From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] core177: Do not ship location database extracted in ipset format
Date: Thu, 13 Jul 2023 14:23:00 +0000
Message-ID: <8c1e32f1-187f-5159-ba00-ffd0e6a3e536@ipfire.org>
In-Reply-To: <20230711093726.771964-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1957403977783164290=="
List-Id: <development.lists.ipfire.org>

--===============1957403977783164290==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Thank you for raising this, I'll pay attention to it for future Core Updates.

Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

> Since the update is not built on the day when people install it, we will
> ship an outdated database. For updates, where the firewall is being
> reloaded or rebooted, we will have an old database in place until the
> next database update job runs.
>=20
> Secondly, the data is 33 MiB in size, which is useless data shipped as
> every system will already have a database that is very likely to be more
> recent.
>=20
> In this update, we are not shipping the location database again, but I
> wanted to add this change so it does not get lost next time.
>=20
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  config/rootfiles/core/177/exclude | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/config/rootfiles/core/177/exclude b/config/rootfiles/core/177/=
exclude
> index 378c2d563..8ee1c3c2f 100644
> --- a/config/rootfiles/core/177/exclude
> +++ b/config/rootfiles/core/177/exclude
> @@ -27,6 +27,7 @@ var/ipfire/urlfilter/blacklist
>  var/ipfire/urlfilter/settings
>  var/lib/alternatives
>  var/lib/location/database.db
> +var/lib/location/ipset
>  var/log/cache
>  var/log/dhcpcd.log
>  var/log/messages

--===============1957403977783164290==--