From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Krieger To: development@lists.ipfire.org Subject: Re: [PATCH] ddns: Add provider Feste-IP.Net Date: Wed, 19 May 2021 13:44:03 +0000 Message-ID: <8dcf65d8-5f8d-5b8c-f6b4-861c32d645ab@posteo.de> In-Reply-To: <37323352-007d-f1a6-5ce9-0d614c3ca9e3@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0502021068501068708==" List-Id: --===============0502021068501068708== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Peter, I marked the obsolete patches as "superseded". Regards, Martin Krieger Peter M=C3=BCller: > Hi, >=20 > thanks for your reply. >=20 > First, please do not forget to keep the mailing list CC'ed. For transparenc= y reasons, we have a policy here > stating to keep public conversations public (please refer to https://wiki.i= pfire.org/devel/contact for details). >=20 > Second, your patches _did_ made it into patchwork. They can be found in=20 the "ipfire" section - for your convenience, > here is a list of all active patches submitted by you patchwork currently k= nows about: > https://patchwork.ipfire.org/project/ipfire/list/?submitter=3D93 >=20 > Once having logged in, you can mark patches as being "superseded", so they = won't appear as being active anymore. >=20 > Third, I have seen your updated patch and will comment on it separately=20 the other day. >=20 > Thanks, and best regards, > Peter M=C3=BCller >=20 >=20 >> Hello Peter, >> >> thanks for your reply. Sorry for confusion about the patch. I tried to=20 fullfill the requirements, but due to my low experience on the git process it= went accidantely wrong. >> >> I will improve & resubmit my patch according to your comments. >> >> What ist the right way to mark patches as obsolete or remove them? My patc= hes doesn=E2=80=98t seem to enter https://patchwork.ipfire.org. >> >> Regards, >> >> Martin Krieger >> >> Von meinem iPad gesendet >> >>> Am 17.05.2021 um 21:31 schrieb Peter M=C3=BCller : >>> =EF=BB=BFHi, >>> >>> thank you for providing this. >>> >>> I regret to inform you that >>> >>> (a) both this patch and it's precursor violate the syntax of patches appl= icable to git, >>> having parts of the description and various tags mangled into the=20 RFC 5322 / MIME >>> "Subject" header. >>> >>> You do not need to use "git send-email" as such (personally, I do=20 not use it either, >>> because my development environment cannot establish SMTP connections = due to firewall >>> policies). However, IPFire's development heavily relies on Git, so pl= ease figure out >>> how to run the most basic commands such as "git commit" and "git form= at-patch" in >>> order to properly submit your patches. >>> >>> (b) these patches each success each other, however missing appropriate ve= rsion tags >>> (such as [PATCH v2], [PATCH v3], etc.) in the RFC 5322 "Subject" head= er of their >>> mails. >>> >>> Since you did not mark the obsoleted patches as being superseded in h= ttps://patchwork.ipfire.org/, >>> either, this makes it hard to keep track of the latest version of=20 your patch. Eventually, >>> we might apply, commend or reject based on the wrong one, because=20 of simply having >>> overlooked there is a new, fixed version of it available. >>> >>> Apart from that, it would be good to see this patch tested with IPv6 and = dual-stack scenarios >>> as well - please see also my remark(s) on this below. If I understood=20 the documentation of >>> that DDNS provider correctly, you do not really need to supply two IP=20 addresses having distinct >>> families. Could you at least try executing this snippet with two differen= t IPv4 addresses? >>> >>>> --- >>>> README | 1 + >>>> src/ddns/providers.py | 27 +++++++++++++++++++++++++++ >>>> 2 files changed, 28 insertions(+) >>>> >>>> diff --git a/README b/README >>>> index b6decb35c338..fa6ce5e598b8 100644 >>>> --- a/README >>>> +++ b/README >>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >>>> easydns.com >>>> enom.com >>>> entrydns.net >>>> + feste-ip.net >>>> freedns.afraid.org >>>> inwx.com|de|at|ch|es >>>> itsdns.de >>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>>> index 56e6620c78ab..009e2c9e337d 100644 >>>> --- a/src/ddns/providers.py >>>> +++ b/src/ddns/providers.py >>>> @@ -1179,6 +1179,33 @@ class DDNSProviderEntryDNS(DDNSProvider): >>>> raise DDNSUpdateError >>>> >>>> >>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): >>>> + handle =3D "feste-ip.net" >>>> + name =3D "Feste-IP.Net" >>>> + website =3D "https://www.feste-ip.net/" >>>> + >>>> + # Information about the format of the request is to be found >>>> + # https://forum.feste-ip.net/viewtopic.php?f=3D13&t=3D469 >>>> + >>>> + myips =3D ("myip","myip2") >>> >>> Personal comment: Kinda ugly, but given the documentation of that provide= r, there is no >>> other choice to do this here... >>> >>>> + >>>> + url =3D "https://members.feste-ip.net/nic/update/" >>>> + >>>> + def update(self): >>>> + data =3D { >>>> + "hostname" : self.hostname >>>> + } >>>> + >>>> + for proto in DDNSProvider.protocols: >>>> + idx =3D 0 >>>> + tmpip =3D self.get_address(proto) >>>> + if tmpip: >>>> + data[self.myips[idx]] =3D tmpip >>>> + idx +=3D 1 >>>> + >>>> + self.send_request(data) >>> >>> What is happening here if $tmpip equals a Boolean False? >>> >>>> + >>>> + >>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>>> handle =3D "freedns.afraid.org" >>>> name =3D "freedns.afraid.org" >>> >>> Thanks, and best regards, >>> Peter M=C3=BCller >> --===============0502021068501068708== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="OpenPGP_signature.sig" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ2dBZEZpRUVuV0tqZ2ZoSXBr anh4Tm1BRWV2RUVOYVpqR01GQW1DbEZpTUFDZ2tRRWV2RUVOYVoKakdOd3ZSQUF4YjBzZGVDYTMx dFJjUkt2akpCVVFveEVrSUgvQ0dnSXFJSEhWYWdxRElWSUZpNFdMVnVFOFZXeQpSTlljaURJT1RU Nm1PZkVPS3RVcFFsQy9ESjZXTGZvV0VFWGpiRU1qWlozSVd2bzJ6Nm10Y0xvYW5jcUNqZUhvCkpP YmdGNEx3dlA2K0NGbVJScDIyenVPOXdnL1pzQzVBdCttZEhZSzRiZVRuZkRXalhVTG9yRXZBR2lN Q0pxWU8KN2l6aFhHWGFtMEtidlQ5VEJSQkI3Wm53elJkRkpraklZZ2RWL3pNZytFWHY1TnZLNDZt Z21tZUZzYURBYnF3SwpxUEtaeStyQWpzOEJUQWppb2c2MkNvU0lKV2kweGZ2NWpTVHp4UnU2MG5r RFkrQVB5bkFldzFVU2cwWVZib1FpCkE3N1BCRUJWSlIxSVBHaDRTSmFseENiUFZsbEhhNjAvb3ZP TmRpR25vVFBLVTJoN3liWTZtVitrK2JHREVPSnYKZmJiaEJ4QkRCOWRYZEN6TkJSMUJqVkttTFdW R1ZVd205dFBxVm1HdHl6cHRiQ3ZEZlVTdjMvMzhZaU82MGJZWgp6d0tmYmxRZzliWnBZRlFNYy9W VGNqSW5hRDlhWmE1TlEzS0Fwb0hDWVZSL3Q3eFBpYTdPUmxWTFVhTXVxTDhRCjJvS25OcGZJajhK UHRYUTg0N3ltL1MvNjRZcERMTDg2RFVSTkQwNEpZSmhYTUFtM0p5dmppZnRuT3BVYzFqYTAKUUpo K200bk9QLzdyL2R0M1lZR2k3VDZVYW9vWHNxL2RITEF4VzNZTWhtbVAyV0JqcFQrNEEwQmNZM1d5 S0pYWgoxQmZQU2ZrMk9LcU9EazhxOU5IMzcrZnVwT20rbGxXRWZ1Y0l6ZUNiVE1yZ3JtdTRkUGs9 Cj1pTmpUCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============0502021068501068708==--