From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.7: Adjusted 'traffic.cgi' to display 5-minute graphs
Date: Sat, 22 May 2021 18:35:37 +0200 [thread overview]
Message-ID: <8e7c608f-088a-1c88-3db1-c773c3d71a6e@ipfire.org> (raw)
In-Reply-To: <20210522132556.3382-1-matthias.fischer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]
Looks good to me, thank you. :-)
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/traffic.cgi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/html/cgi-bin/traffic.cgi b/html/cgi-bin/traffic.cgi
> index cafccf73f..4846cfdf9 100644
> --- a/html/cgi-bin/traffic.cgi
> +++ b/html/cgi-bin/traffic.cgi
> @@ -86,7 +86,10 @@ sub display_vnstat
> if ( $testdata =~ 'enough') {
> print"No data for $device !<br>";
> } else {
> + # Summary
> system("/usr/bin/vnstati -c 1 -s -i $device -o /srv/web/ipfire/html/graphs/vnstat-s-$device.png");
> + # 5-minute graphs
> + system("/usr/bin/vnstati -c 1 -5 -i $device -o /srv/web/ipfire/html/graphs/vnstat-5-$device.png");
> # Hour graph
> system("/usr/bin/vnstati -c 1 -h -i $device -o /srv/web/ipfire/html/graphs/vnstat-h-$device.png");
> # Day graph
> @@ -100,6 +103,7 @@ sub display_vnstat
> print <<END
> <table>
> <tr><td><img src="/graphs/vnstat-s-$device.png"></td></tr>
> +<tr><td><img src="/graphs/vnstat-5-$device.png"></td></tr>
> <tr><td><img src="/graphs/vnstat-h-$device.png"></td></tr>
> <tr><td><img src="/graphs/vnstat-d-$device.png"></td></tr>
> <tr><td><img src="/graphs/vnstat-m-$device.png"></td></tr>
>
prev parent reply other threads:[~2021-05-22 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 13:25 Matthias Fischer
2021-05-22 16:35 ` Peter Müller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7c608f-088a-1c88-3db1-c773c3d71a6e@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox