From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] vnstat 2.7: Adjusted 'traffic.cgi' to display 5-minute graphs
Date: Sat, 22 May 2021 18:35:37 +0200
Message-ID: <8e7c608f-088a-1c88-3db1-c773c3d71a6e@ipfire.org>
In-Reply-To: <20210522132556.3382-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8892349190771584257=="
List-Id: <development.lists.ipfire.org>

--===============8892349190771584257==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Looks good to me, thank you. :-)

Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  html/cgi-bin/traffic.cgi | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/html/cgi-bin/traffic.cgi b/html/cgi-bin/traffic.cgi
> index cafccf73f..4846cfdf9 100644
> --- a/html/cgi-bin/traffic.cgi
> +++ b/html/cgi-bin/traffic.cgi
> @@ -86,7 +86,10 @@ sub display_vnstat
>  	if ( $testdata =3D~ 'enough') {
>  		print"No data for $device !<br>";
>  	} else {
> +	    # Summary
>  	    system("/usr/bin/vnstati -c 1 -s -i $device -o /srv/web/ipfire/html/g=
raphs/vnstat-s-$device.png");
> +	    # 5-minute graphs
> +	    system("/usr/bin/vnstati -c 1 -5 -i $device -o /srv/web/ipfire/html/g=
raphs/vnstat-5-$device.png");
>  	    # Hour graph
>  	    system("/usr/bin/vnstati -c 1 -h -i $device -o /srv/web/ipfire/html/g=
raphs/vnstat-h-$device.png");
>  	    # Day graph
> @@ -100,6 +103,7 @@ sub display_vnstat
>  print <<END
>  <table>
>  <tr><td><img src=3D"/graphs/vnstat-s-$device.png"></td></tr>
> +<tr><td><img src=3D"/graphs/vnstat-5-$device.png"></td></tr>
>  <tr><td><img src=3D"/graphs/vnstat-h-$device.png"></td></tr>
>  <tr><td><img src=3D"/graphs/vnstat-d-$device.png"></td></tr>
>  <tr><td><img src=3D"/graphs/vnstat-m-$device.png"></td></tr>
>=20

--===============8892349190771584257==--