Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

Hi All,

On 04/07/2023 14:52, Adolf Belka wrote:
> So next thing is to see if this updated version works for Peter and 
> Arne or if I have more work to do. :-)
>
At the last video conf call Peter and Arne mentioned that they are able 
to test a pppoe connection with the ppp version update patch I submitted 
at the beginning of July.

https://lists.ipfire.org/pipermail/development/2023-July/016101.html

Any progress on the testing. Just let me know if there are any issues 
that I need to work on.

Regards,
Adolf.

> Regards,
> Adolf.
>
> On 04/07/2023 11:08, Michael Tremer wrote:
>> Thanks. This looks good to me.
>>
>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>
>>> On 4 Jul 2023, at 10:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> - This patch goes together with the patch for the ppp update to 2.5.0
>>> - The rp-pppoe.so option is no longer available. There is only the 
>>> pppoe.so available now
>>>
>>> Fixes: Bug#13164
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>> src/initscripts/networking/red | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/initscripts/networking/red 
>>> b/src/initscripts/networking/red
>>> index 16d48f3ac..75a17bd5a 100644
>>> --- a/src/initscripts/networking/red
>>> +++ b/src/initscripts/networking/red
>>> @@ -365,7 +365,7 @@ case "${1}" in
>>> #
>>> if [ "$TYPE" == "pppoe" ]; then
>>> [ "${METHOD}" == "PPPOE_PLUGIN" ] && \
>>> - PLUGOPTS="plugin rp-pppoe.so"
>>> + PLUGOPTS="plugin pppoe.so"
>>> fi
>>>
>>> ### Synchronous Mode
>>> -- 
>>> 2.41.0
>>>
>>

-- 
Sent from my laptop