From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: ddns add provider Feste-IP.NET
Date: Wed, 05 May 2021 23:28:22 +0100
Message-ID: <902847A2-002E-4D76-8638-2A1A4AAB152F@ipfire.org>
In-Reply-To: <9cac2a23-4575-4b06-d4d5-dc9c60ca65bb@posteo.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2762223528141041214=="
List-Id: <development.lists.ipfire.org>

--===============2762223528141041214==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello Martin,

Thank you very much for your submission.

> On 5 May 2021, at 19:13, Martin Krieger <makrie(a)posteo.de> wrote:
> 
> diff --git a/README b/README
> index b6decb3..fa6ce5e 100644
> --- a/README
> +++ b/README
> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>        easydns.com
>        enom.com
>        entrydns.net
> +       feste-ip.net
>        freedns.afraid.org
>        inwx.com|de|at|ch|es
>        itsdns.de
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 56e6620..c70423b 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>                # If we got here, some other update error happened.
>                raise DDNSUpdateError
> 
> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
> +        handle    = "feste-ip.net"
> +        name      = "Feste-IP.Net"
> +        website   = "https//www.feste-ip.net/"

You are missing a “:” in the URL.

> +        protocols = ("ipv4",)

According to this documentation, the provider supports IPv6 as well:

  https://www.feste-ip.net/ddns-service/einrichtung/linux/

> +        # Information about the format of the request is to be found
> +        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
> +
> +        url = "https://members.feste-ip.net/nic/update"
> 
> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>        handle    = “freedns.afraid.org"
> 

Best,
-Michael

--===============2762223528141041214==--