Re: ''backup.cgi' - new icons - new order - query for delete / translation strings

[ummeegge <ummeegge@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3492 bytes --]

Hi Matthias,
and thanks for not giving up in this topic and for your hard work to
stay there actual also after one+ year. I do also think it is a good
idea to clean up the language files even there are not only some
doubles but also triples like e.g.

...
'delete' => 'Löschen',
...
'remove' => 'Löschen',
...
'fwdfw delete' => 'Löschen',
..

but also really a lot´s of unused ones. 

backup.cgi: It seems that this CGI is one of the older ones, a unified
design to the rest should give the WUI possibly more visual consistens
in my opinion but the order of the icons makes also more sense in that
way.

onclick: yes/no confirmation has been often ask for in the forum (it
s...s if you accidentially delete a VPN client or a backup) but as Tom
Rymes said it already, even we have already (nearly) all CGIs patched,
some of them would probably not need a deletion confirmation, a
question arises then which one doesn´t ?


Nice project contribution from you Matthias, thanks again.

Best,

Erik


Am Sonntag, den 25.11.2018, 08:30 -0500 schrieb Tom Rymes:
> Matthias,
> 
> I can’t comment on everything, but I do know that I have consistently
> been confused by the icons on the backup page.
> 
> Confirmation dialogs seem good, so long as we don’t go overboard and
> ask “are you sure” for every tiny action.
> 
> Tom
> 
> > On Nov 24, 2018, at 4:39 PM, Matthias Fischer <
> > matthias.fischer(a)ipfire.org> wrote:
> > 
> > Hi,
> > 
> > Something similar has been posted before ([PATCH] Cosmetics: New
> > icons
> > for backup.cgi), but unfortunately the discussion was not continued
> > for
> > very long.
> > 
> > Triggered by:
> > 
> > https://forum.ipfire.org/viewtopic.php?f=17&t=21372
> > 
> > and
> > 
> > https://forum.ipfire.org/viewtopic.php?f=17&t=21882
> > 
> > I'd like to know whether there is any interest in developing this
> > any
> > further. In the meantime, patches were built for 'backup.cgi' which
> > not
> > only update the icons and their order of precedence for better
> > readability and usability. In an additional step, the 'delete'
> > icons got
> > 'onclick'-confirmation boxes (by Erik!) to prevent accidental
> > deletions.
> > 
> > Another step could be to add this confirmation to other CGIs. This
> > additional query could prevent some trouble in the future as it
> > happened
> > to the original poster of the second link above. He accidentally
> > deleted
> > an OVPN client. No query... I'm already testing this functionality
> > in
> > other contexts (e.g., firewall rules, dhcp, hosts) and it works.
> > 
> > And the last question: each current lang file contains up to ~600
> > unused
> > translation strings. These are summing up to about 5000 strings
> > which
> > are not used or duplicates and could be deleted. Current size of
> > all
> > lang files is 1.2MB - we actually need about 900KB. A current patch
> > can
> > be found here:
> > 
> > 
https://git.ipfire.org/?p=people/ummeegge/ipfire-2.x.git;a=commit;h=acbf3208e4a0d61c138d38326079a29b97545007
> > 
> > At the beginning of this year I built some patches for these unused
> > strings and some other corrections
> > (https://patchwork.ipfire.org/patch/1605/) but sadly got no
> > reaction at
> > all. Is there any interest, should we re-edit the unused
> > translations?
> > 
> > What do you think? Opinions and comments are welcome...
> > 
> > Best,
> > Matthias