From mboxrd@z Thu Jan  1 00:00:00 1970
From: ummeegge <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: ''backup.cgi' - new icons - new order - query for delete /
 translation strings
Date: Tue, 04 Dec 2018 14:55:06 +0100
Message-ID: <90a14944bd2ece5e9b36b54e1ee7db6b4a42471e.camel@ipfire.org>
In-Reply-To: <5CB0C534-EF45-4A45-8EFC-A4DEEB6AF937@rymes.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4046576550008209428=="
List-Id: <development.lists.ipfire.org>

--===============4046576550008209428==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Matthias,
and thanks for not giving up in this topic and for your hard work to
stay there actual also after one+ year. I do also think it is a good
idea to clean up the language files even there are not only some
doubles but also triples like e.g.

...
'delete' =3D> 'L=C3=B6schen',
...
'remove' =3D> 'L=C3=B6schen',
...
'fwdfw delete' =3D> 'L=C3=B6schen',
..

but also really a lot=C2=B4s of unused ones.=20

backup.cgi: It seems that this CGI is one of the older ones, a unified
design to the rest should give the WUI possibly more visual consistens
in my opinion but the order of the icons makes also more sense in that
way.

onclick: yes/no confirmation has been often ask for in the forum (it
s...s if you accidentially delete a VPN client or a backup) but as Tom
Rymes said it already, even we have already (nearly) all CGIs patched,
some of them would probably not need a deletion confirmation, a
question arises then which one doesn=C2=B4t ?


Nice project contribution from you Matthias, thanks again.

Best,

Erik


Am Sonntag, den 25.11.2018, 08:30 -0500 schrieb Tom Rymes:
> Matthias,
>=20
> I can=E2=80=99t comment on everything, but I do know that I have consistent=
ly
> been confused by the icons on the backup page.
>=20
> Confirmation dialogs seem good, so long as we don=E2=80=99t go overboard and
> ask =E2=80=9Care you sure=E2=80=9D for every tiny action.
>=20
> Tom
>=20
> > On Nov 24, 2018, at 4:39 PM, Matthias Fischer <
> > matthias.fischer(a)ipfire.org> wrote:
> >=20
> > Hi,
> >=20
> > Something similar has been posted before ([PATCH] Cosmetics: New
> > icons
> > for backup.cgi), but unfortunately the discussion was not continued
> > for
> > very long.
> >=20
> > Triggered by:
> >=20
> > https://forum.ipfire.org/viewtopic.php?f=3D17&t=3D21372
> >=20
> > and
> >=20
> > https://forum.ipfire.org/viewtopic.php?f=3D17&t=3D21882
> >=20
> > I'd like to know whether there is any interest in developing this
> > any
> > further. In the meantime, patches were built for 'backup.cgi' which
> > not
> > only update the icons and their order of precedence for better
> > readability and usability. In an additional step, the 'delete'
> > icons got
> > 'onclick'-confirmation boxes (by Erik!) to prevent accidental
> > deletions.
> >=20
> > Another step could be to add this confirmation to other CGIs. This
> > additional query could prevent some trouble in the future as it
> > happened
> > to the original poster of the second link above. He accidentally
> > deleted
> > an OVPN client. No query... I'm already testing this functionality
> > in
> > other contexts (e.g., firewall rules, dhcp, hosts) and it works.
> >=20
> > And the last question: each current lang file contains up to ~600
> > unused
> > translation strings. These are summing up to about 5000 strings
> > which
> > are not used or duplicates and could be deleted. Current size of
> > all
> > lang files is 1.2MB - we actually need about 900KB. A current patch
> > can
> > be found here:
> >=20
> >=20
https://git.ipfire.org/?p=3Dpeople/ummeegge/ipfire-2.x.git;a=3Dcommit;h=3Dacb=
f3208e4a0d61c138d38326079a29b97545007
> >=20
> > At the beginning of this year I built some patches for these unused
> > strings and some other corrections
> > (https://patchwork.ipfire.org/patch/1605/) but sadly got no
> > reaction at
> > all. Is there any interest, should we re-edit the unused
> > translations?
> >=20
> > What do you think? Opinions and comments are welcome...
> >=20
> > Best,
> > Matthias


--===============4046576550008209428==--