From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Testing of rapid_commit patch Date: Tue, 03 Dec 2024 17:41:40 +0000 Message-ID: <91C04EE6-818A-4D76-A1A4-F804A6B6B701@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1398450402013689011==" List-Id: --===============1398450402013689011== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable > On 29 Nov 2024, at 19:04, Adolf Belka wrote: >=20 > Hi Michael, >=20 > On 29/11/2024 15:10, Michael Tremer wrote: >> Hello, >> Thanks for testing this in production. Good to know this all works. >>> On 29 Nov 2024, at 11:21, Adolf Belka wrote: >>>=20 >>> Hi Michael, >>>=20 >>> I had previously tested your rapid_commit patch on my vm network system. = However as that network does not have a problem with the rapid_commit option = it was not the best test. >>>=20 >>> I said that i would test it out on my production system after the visit t= o my family. I have now got around to that. >>>=20 >>> My new ISP, that bought out the very good technically based ISP I used to= have, is one of the ones that has a DHCP server that just times out if you h= ave the rapid_commit option in the dhcpcd config file. >>>=20 >>> So I updated my production IPFire to Core-Update 190 Development Build: m= aster/1e2abd66 >>>=20 >>> After rebooting the connection was lost as the rapid_commit option is on = by default. >>>=20 >>> I then ran the setup program and unchecked the rapid commit box on the re= d interface and then rebooted and the connection was running. >>>=20 >>> Another reboot still had the connection running. >>>=20 >>> So I can confirm that the patch is working . >>>=20 >>> The only thing that came to mind is when we do the update people who have= removed or commented out the rapid_commit option in dhcpcd.conf will lose th= eir connection. >>>=20 >>> So either >>>=20 >>> * we need to have the update check if the rapid_commit option has been co= mmented out or has been removed and then disable the rapid commit option for = the red interface. >>>=20 >>> or >>>=20 >>> * we need to make sure that it is well communicated that anyone who has d= isabled the rapid_commit option needs to run the setup program after the upgr= ade (maybe before the reboot) to disable the option for the red interface. >> If we wanted to be really fancy we could check if someone has modified the= configuration file and if so we can automatically set the setting in /var/ip= fire/ethernet/settings. I am not sure how reliable this would be, but it is a= n option. >=20 > I could have a look at putting something together for this and test it out = on my vm system and then submit a patch for it, if that is fine with you. I would like to keep the solution that we have right now and see what happens= once it is out there=E2=80=A6 I wouldn=E2=80=99t want to over-engineer this = all just yet. >=20 > Regards, > Adolf. >=20 >>> We can discuss this at our next conf call meeting on 3rd or 4th Dec. >> We need to bring more things back to the list because there are currently = only so few people joining the call. I would also prefer to sort things out s= ooner on the list if possible and keep the call as free as possible for more = general discussion. >> -Michael >>>=20 >>> Regards, >>>=20 >>> Adolf. >>>=20 >=20 > --=20 > Sent from my laptop --===============1398450402013689011==--