From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Adolf Belka (ipfire-dev)" To: development@lists.ipfire.org Subject: Feedback on Core Update 154 testing Date: Tue, 16 Feb 2021 13:59:10 +0100 Message-ID: <92699267-80d9-111e-ef6b-06c2a04af9fc@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7180581869493731470==" List-Id: --===============7180581869493731470== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi All, After working on a new bug (#10628), my code was not working as I expected it= to. After investigating I realised that when I provided https://patchwork.ip= fire.org/patch/3724/ to add Deny Known Client capability to dhcp.cgi I had pl= aced a curly bracket in the wrong place. It is not syntactically wrong so there is no Internal Error message coming up= but if the Deny Known Clients is not checked then there is no check made for= a valid Default Lease Time. I made an error when I inserted my code into dhcp.cgi for the Deny Known Clie= nts fix. I will raise a patch to correct this. Regards, Adolf. --===============7180581869493731470==--