* [PATCH] sed: Update to 4.8 @ 2021-02-03 15:01 Adolf Belka 2021-02-03 22:27 ` Michael Tremer 0 siblings, 1 reply; 7+ messages in thread From: Adolf Belka @ 2021-02-03 15:01 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 4210 bytes --] - Update sed from 4.4 to 4.8 - Updated rootfile - Changelog * Noteworthy changes in release 4.8 (2020-01-14) [stable] ** Bug fixes - "sed -i" now creates temporary files with correct umask (limited to u=rwx). Previously sed would incorrectly set umask on temporary files, resulting in problems under certain fuse-like file systems. [bug introduced in sed 4.2.1] ** Release distribute gzip-compressed tarballs once again ** Improvements a year's worth of gnulib development, including improved DFA performance * Noteworthy changes in release 4.7 (2018-12-20) [stable] ** Bug fixes - Some uses of \b in the C locale and with the DFA matcher would fail, e.g., the following would mistakenly print "123-x" instead of "123": echo 123-x|LC_ALL=C sed 's/.\bx//' - Using a multibyte locale or certain regexp constructs (some ranges, backreferences) would avoid the bug. [bug introduced in sed 4.6] * Noteworthy changes in release 4.6 (2018-12-19) [stable] ** Improvements - sed now prints a clear error message when r/R/w/W (and s///w) commands are missing a filename. Previously, w/W commands would fail with confusing error message, while r/R would be a silent no-op. - sed now uses fully-buffered output (instead of line-buffered) when writing to files. This should noticeably improve performance of "sed -i" and other write commands. Buffering can be disabled (as before) with "sed -u". - sed in non-cygwin windows environments (e.g. mingw) now properly handles '\n' newlines in -b/--binary mode. ** Bug fixes - sed no longer accesses invalid memory (heap overflow) when given invalid backreferences in 's' command [bug#32082, present at least since sed-4.0.6]. - sed no longer adds extraneous NUL when given s/$//n command. [related to bug#32271, present since sed-4.0.7] - sed no longer accesses invalid memory (heap overflow) with s/$//n regexes. [bug#32271, present since sed-4.3]. ** New Features New option, --debug: print the input sed script in canonical form and annotate program execution. * Noteworthy changes in release 4.5 (2018-03-31) [stable] ** Bug fixes - sed now fails when matching very long input lines (>2GB). Before, sed would silently ignore the regex without indicating an error. [Bug present at least since sed-3.02] - sed no longer rejects comments and closing braces after y/// commands. [Bug existed at least since sed-3.02] - sed -E --posix no longer ignores special meaning of '+','?','|' . [Bug introduced in the original implementation of --posix option in v4.1a-5-gba68fb4] - sed -i now creates selinux context based on the context of the symlink instead of the symlink target. [Bug present since at least sed-4.2] - sed -i --follow-symlinks remains unchanged. - sed now treats the sequence '\x5c' (ASCII 92, backslash) as literal backslash character, not as an escape prefix character. [Bug present since sed-3.02.80] Old behavior: $ echo z | sed -E 's/(z)/\x5c1/' # identical to 's/(z)/\1/' z New behavior: $ echo z | sed -E 's/(z)/\x5c1/' \1 Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> --- config/rootfiles/common/sed | 2 +- lfs/sed | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/rootfiles/common/sed b/config/rootfiles/common/sed index 8db08fa39..f355a89ca 100644 --- a/config/rootfiles/common/sed +++ b/config/rootfiles/common/sed @@ -1,3 +1,3 @@ bin/sed #usr/share/info/sed.info -#usr/share/man/man1/sed.1 +#usr/share/man/man1/sed.1 \ No newline at end of file diff --git a/lfs/sed b/lfs/sed index 9123183e3..9c5b33e4a 100644 --- a/lfs/sed +++ b/lfs/sed @@ -24,7 +24,7 @@ include Config -VER = 4.4 +VER = 4.8 THISAPP = sed-$(VER) DL_FILE = $(THISAPP).tar.xz @@ -53,7 +53,7 @@ objects = $(DL_FILE) $(DL_FILE) = $(DL_FROM)/$(DL_FILE) -$(DL_FILE)_MD5 = e0c583d4c380059abd818cd540fe6938 +$(DL_FILE)_MD5 = 6d906edfdb3202304059233f51f9a71d install : $(TARGET) -- 2.30.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sed: Update to 4.8 2021-02-03 15:01 [PATCH] sed: Update to 4.8 Adolf Belka @ 2021-02-03 22:27 ` Michael Tremer 2021-02-03 22:33 ` Adolf Belka 0 siblings, 1 reply; 7+ messages in thread From: Michael Tremer @ 2021-02-03 22:27 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 4795 bytes --] Hi Adolf, In all the patches from today, you seem to have a little issue in the root files. Scroll down please. > On 3 Feb 2021, at 15:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote: > > - Update sed from 4.4 to 4.8 > - Updated rootfile > - Changelog > * Noteworthy changes in release 4.8 (2020-01-14) [stable] > ** Bug fixes > - "sed -i" now creates temporary files with correct umask (limited to u=rwx). > Previously sed would incorrectly set umask on temporary files, resulting > in problems under certain fuse-like file systems. > [bug introduced in sed 4.2.1] > ** Release > distribute gzip-compressed tarballs once again > ** Improvements > a year's worth of gnulib development, including improved DFA performance > * Noteworthy changes in release 4.7 (2018-12-20) [stable] > ** Bug fixes > - Some uses of \b in the C locale and with the DFA matcher would fail, e.g., > the following would mistakenly print "123-x" instead of "123": > echo 123-x|LC_ALL=C sed 's/.\bx//' > - Using a multibyte locale or certain regexp constructs (some ranges, > backreferences) would avoid the bug. [bug introduced in sed 4.6] > * Noteworthy changes in release 4.6 (2018-12-19) [stable] > ** Improvements > - sed now prints a clear error message when r/R/w/W (and s///w) commands > are missing a filename. Previously, w/W commands would fail with confusing > error message, while r/R would be a silent no-op. > - sed now uses fully-buffered output (instead of line-buffered) when > writing to files. This should noticeably improve performance of "sed -i" > and other write commands. > Buffering can be disabled (as before) with "sed -u". > - sed in non-cygwin windows environments (e.g. mingw) now properly handles > '\n' newlines in -b/--binary mode. > ** Bug fixes > - sed no longer accesses invalid memory (heap overflow) when given invalid > backreferences in 's' command [bug#32082, present at least since sed-4.0.6]. > - sed no longer adds extraneous NUL when given s/$//n command. > [related to bug#32271, present since sed-4.0.7] > - sed no longer accesses invalid memory (heap overflow) with s/$//n regexes. > [bug#32271, present since sed-4.3]. > ** New Features > New option, --debug: print the input sed script in canonical form > and annotate program execution. > * Noteworthy changes in release 4.5 (2018-03-31) [stable] > ** Bug fixes > - sed now fails when matching very long input lines (>2GB). > Before, sed would silently ignore the regex without indicating an > error. [Bug present at least since sed-3.02] > - sed no longer rejects comments and closing braces after y/// commands. > [Bug existed at least since sed-3.02] > - sed -E --posix no longer ignores special meaning of '+','?','|' . > [Bug introduced in the original implementation of --posix option in > v4.1a-5-gba68fb4] > - sed -i now creates selinux context based on the context of the symlink > instead of the symlink target. [Bug present since at least sed-4.2] > - sed -i --follow-symlinks remains unchanged. > - sed now treats the sequence '\x5c' (ASCII 92, backslash) as literal > backslash character, not as an escape prefix character. > [Bug present since sed-3.02.80] > Old behavior: > $ echo z | sed -E 's/(z)/\x5c1/' # identical to 's/(z)/\1/' > z > New behavior: > $ echo z | sed -E 's/(z)/\x5c1/' > \1 > > Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> > --- > config/rootfiles/common/sed | 2 +- > lfs/sed | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/config/rootfiles/common/sed b/config/rootfiles/common/sed > index 8db08fa39..f355a89ca 100644 > --- a/config/rootfiles/common/sed > +++ b/config/rootfiles/common/sed > @@ -1,3 +1,3 @@ > bin/sed > #usr/share/info/sed.info > -#usr/share/man/man1/sed.1 > +#usr/share/man/man1/sed.1 > \ No newline at end of file There is a newline missing at the end of it. I corrected a couple of them and in general they confuse tar when building the image. Did you change editors or something? -Michael > diff --git a/lfs/sed b/lfs/sed > index 9123183e3..9c5b33e4a 100644 > --- a/lfs/sed > +++ b/lfs/sed > @@ -24,7 +24,7 @@ > > include Config > > -VER = 4.4 > +VER = 4.8 > > THISAPP = sed-$(VER) > DL_FILE = $(THISAPP).tar.xz > @@ -53,7 +53,7 @@ objects = $(DL_FILE) > > $(DL_FILE) = $(DL_FROM)/$(DL_FILE) > > -$(DL_FILE)_MD5 = e0c583d4c380059abd818cd540fe6938 > +$(DL_FILE)_MD5 = 6d906edfdb3202304059233f51f9a71d > > install : $(TARGET) > > -- > 2.30.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sed: Update to 4.8 2021-02-03 22:27 ` Michael Tremer @ 2021-02-03 22:33 ` Adolf Belka 2021-02-03 22:34 ` Michael Tremer 0 siblings, 1 reply; 7+ messages in thread From: Adolf Belka @ 2021-02-03 22:33 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 5351 bytes --] Hi Michael, On 03/02/2021 23:27, Michael Tremer wrote: > Hi Adolf, > > In all the patches from today, you seem to have a little issue in the root files. > > Scroll down please. > >> On 3 Feb 2021, at 15:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >> >> - Update sed from 4.4 to 4.8 >> - Updated rootfile >> - Changelog >> * Noteworthy changes in release 4.8 (2020-01-14) [stable] >> ** Bug fixes >> - "sed -i" now creates temporary files with correct umask (limited to u=rwx). >> Previously sed would incorrectly set umask on temporary files, resulting >> in problems under certain fuse-like file systems. >> [bug introduced in sed 4.2.1] >> ** Release >> distribute gzip-compressed tarballs once again >> ** Improvements >> a year's worth of gnulib development, including improved DFA performance >> * Noteworthy changes in release 4.7 (2018-12-20) [stable] >> ** Bug fixes >> - Some uses of \b in the C locale and with the DFA matcher would fail, e.g., >> the following would mistakenly print "123-x" instead of "123": >> echo 123-x|LC_ALL=C sed 's/.\bx//' >> - Using a multibyte locale or certain regexp constructs (some ranges, >> backreferences) would avoid the bug. [bug introduced in sed 4.6] >> * Noteworthy changes in release 4.6 (2018-12-19) [stable] >> ** Improvements >> - sed now prints a clear error message when r/R/w/W (and s///w) commands >> are missing a filename. Previously, w/W commands would fail with confusing >> error message, while r/R would be a silent no-op. >> - sed now uses fully-buffered output (instead of line-buffered) when >> writing to files. This should noticeably improve performance of "sed -i" >> and other write commands. >> Buffering can be disabled (as before) with "sed -u". >> - sed in non-cygwin windows environments (e.g. mingw) now properly handles >> '\n' newlines in -b/--binary mode. >> ** Bug fixes >> - sed no longer accesses invalid memory (heap overflow) when given invalid >> backreferences in 's' command [bug#32082, present at least since sed-4.0.6]. >> - sed no longer adds extraneous NUL when given s/$//n command. >> [related to bug#32271, present since sed-4.0.7] >> - sed no longer accesses invalid memory (heap overflow) with s/$//n regexes. >> [bug#32271, present since sed-4.3]. >> ** New Features >> New option, --debug: print the input sed script in canonical form >> and annotate program execution. >> * Noteworthy changes in release 4.5 (2018-03-31) [stable] >> ** Bug fixes >> - sed now fails when matching very long input lines (>2GB). >> Before, sed would silently ignore the regex without indicating an >> error. [Bug present at least since sed-3.02] >> - sed no longer rejects comments and closing braces after y/// commands. >> [Bug existed at least since sed-3.02] >> - sed -E --posix no longer ignores special meaning of '+','?','|' . >> [Bug introduced in the original implementation of --posix option in >> v4.1a-5-gba68fb4] >> - sed -i now creates selinux context based on the context of the symlink >> instead of the symlink target. [Bug present since at least sed-4.2] >> - sed -i --follow-symlinks remains unchanged. >> - sed now treats the sequence '\x5c' (ASCII 92, backslash) as literal >> backslash character, not as an escape prefix character. >> [Bug present since sed-3.02.80] >> Old behavior: >> $ echo z | sed -E 's/(z)/\x5c1/' # identical to 's/(z)/\1/' >> z >> New behavior: >> $ echo z | sed -E 's/(z)/\x5c1/' >> \1 >> >> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> >> --- >> config/rootfiles/common/sed | 2 +- >> lfs/sed | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/config/rootfiles/common/sed b/config/rootfiles/common/sed >> index 8db08fa39..f355a89ca 100644 >> --- a/config/rootfiles/common/sed >> +++ b/config/rootfiles/common/sed >> @@ -1,3 +1,3 @@ >> bin/sed >> #usr/share/info/sed.info >> -#usr/share/man/man1/sed.1 >> +#usr/share/man/man1/sed.1 >> \ No newline at end of file > > There is a newline missing at the end of it. Whoops. My error. For some reason I had it in my memory that I should "not" have a blank line at the end of the rootfile. I realise now that I "should" have a blank line at the end of all of them. Will put a note about this in my list of things that I should pay attention to getting right. Sorry. Next sets of patches will not have that problem. Regards, Adolf > > I corrected a couple of them and in general they confuse tar when building the image. > > Did you change editors or something? > > -Michael > >> diff --git a/lfs/sed b/lfs/sed >> index 9123183e3..9c5b33e4a 100644 >> --- a/lfs/sed >> +++ b/lfs/sed >> @@ -24,7 +24,7 @@ >> >> include Config >> >> -VER = 4.4 >> +VER = 4.8 >> >> THISAPP = sed-$(VER) >> DL_FILE = $(THISAPP).tar.xz >> @@ -53,7 +53,7 @@ objects = $(DL_FILE) >> >> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >> >> -$(DL_FILE)_MD5 = e0c583d4c380059abd818cd540fe6938 >> +$(DL_FILE)_MD5 = 6d906edfdb3202304059233f51f9a71d >> >> install : $(TARGET) >> >> -- >> 2.30.0 >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sed: Update to 4.8 2021-02-03 22:33 ` Adolf Belka @ 2021-02-03 22:34 ` Michael Tremer 2021-02-04 7:25 ` Adolf Belka 0 siblings, 1 reply; 7+ messages in thread From: Michael Tremer @ 2021-02-03 22:34 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 5677 bytes --] Hi, > On 3 Feb 2021, at 22:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote: > > Hi Michael, > > On 03/02/2021 23:27, Michael Tremer wrote: >> Hi Adolf, >> In all the patches from today, you seem to have a little issue in the root files. >> Scroll down please. >>> On 3 Feb 2021, at 15:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>> >>> - Update sed from 4.4 to 4.8 >>> - Updated rootfile >>> - Changelog >>> * Noteworthy changes in release 4.8 (2020-01-14) [stable] >>> ** Bug fixes >>> - "sed -i" now creates temporary files with correct umask (limited to u=rwx). >>> Previously sed would incorrectly set umask on temporary files, resulting >>> in problems under certain fuse-like file systems. >>> [bug introduced in sed 4.2.1] >>> ** Release >>> distribute gzip-compressed tarballs once again >>> ** Improvements >>> a year's worth of gnulib development, including improved DFA performance >>> * Noteworthy changes in release 4.7 (2018-12-20) [stable] >>> ** Bug fixes >>> - Some uses of \b in the C locale and with the DFA matcher would fail, e.g., >>> the following would mistakenly print "123-x" instead of "123": >>> echo 123-x|LC_ALL=C sed 's/.\bx//' >>> - Using a multibyte locale or certain regexp constructs (some ranges, >>> backreferences) would avoid the bug. [bug introduced in sed 4.6] >>> * Noteworthy changes in release 4.6 (2018-12-19) [stable] >>> ** Improvements >>> - sed now prints a clear error message when r/R/w/W (and s///w) commands >>> are missing a filename. Previously, w/W commands would fail with confusing >>> error message, while r/R would be a silent no-op. >>> - sed now uses fully-buffered output (instead of line-buffered) when >>> writing to files. This should noticeably improve performance of "sed -i" >>> and other write commands. >>> Buffering can be disabled (as before) with "sed -u". >>> - sed in non-cygwin windows environments (e.g. mingw) now properly handles >>> '\n' newlines in -b/--binary mode. >>> ** Bug fixes >>> - sed no longer accesses invalid memory (heap overflow) when given invalid >>> backreferences in 's' command [bug#32082, present at least since sed-4.0.6]. >>> - sed no longer adds extraneous NUL when given s/$//n command. >>> [related to bug#32271, present since sed-4.0.7] >>> - sed no longer accesses invalid memory (heap overflow) with s/$//n regexes. >>> [bug#32271, present since sed-4.3]. >>> ** New Features >>> New option, --debug: print the input sed script in canonical form >>> and annotate program execution. >>> * Noteworthy changes in release 4.5 (2018-03-31) [stable] >>> ** Bug fixes >>> - sed now fails when matching very long input lines (>2GB). >>> Before, sed would silently ignore the regex without indicating an >>> error. [Bug present at least since sed-3.02] >>> - sed no longer rejects comments and closing braces after y/// commands. >>> [Bug existed at least since sed-3.02] >>> - sed -E --posix no longer ignores special meaning of '+','?','|' . >>> [Bug introduced in the original implementation of --posix option in >>> v4.1a-5-gba68fb4] >>> - sed -i now creates selinux context based on the context of the symlink >>> instead of the symlink target. [Bug present since at least sed-4.2] >>> - sed -i --follow-symlinks remains unchanged. >>> - sed now treats the sequence '\x5c' (ASCII 92, backslash) as literal >>> backslash character, not as an escape prefix character. >>> [Bug present since sed-3.02.80] >>> Old behavior: >>> $ echo z | sed -E 's/(z)/\x5c1/' # identical to 's/(z)/\1/' >>> z >>> New behavior: >>> $ echo z | sed -E 's/(z)/\x5c1/' >>> \1 >>> >>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> >>> --- >>> config/rootfiles/common/sed | 2 +- >>> lfs/sed | 4 ++-- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/config/rootfiles/common/sed b/config/rootfiles/common/sed >>> index 8db08fa39..f355a89ca 100644 >>> --- a/config/rootfiles/common/sed >>> +++ b/config/rootfiles/common/sed >>> @@ -1,3 +1,3 @@ >>> bin/sed >>> #usr/share/info/sed.info >>> -#usr/share/man/man1/sed.1 >>> +#usr/share/man/man1/sed.1 >>> \ No newline at end of file >> There is a newline missing at the end of it. > Whoops. My error. For some reason I had it in my memory that I should "not" have a blank line at the end of the rootfile. > I realise now that I "should" have a blank line at the end of all of them. Will put a note about this in my list of things that I should pay attention to getting right. > Sorry. Next sets of patches will not have that problem. No problem. All files have a \n at the end. There are no exceptions as far as I know and every editor should do it automatically. > > Regards, > Adolf >> I corrected a couple of them and in general they confuse tar when building the image. >> Did you change editors or something? >> -Michael >>> diff --git a/lfs/sed b/lfs/sed >>> index 9123183e3..9c5b33e4a 100644 >>> --- a/lfs/sed >>> +++ b/lfs/sed >>> @@ -24,7 +24,7 @@ >>> >>> include Config >>> >>> -VER = 4.4 >>> +VER = 4.8 >>> >>> THISAPP = sed-$(VER) >>> DL_FILE = $(THISAPP).tar.xz >>> @@ -53,7 +53,7 @@ objects = $(DL_FILE) >>> >>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >>> >>> -$(DL_FILE)_MD5 = e0c583d4c380059abd818cd540fe6938 >>> +$(DL_FILE)_MD5 = 6d906edfdb3202304059233f51f9a71d >>> >>> install : $(TARGET) >>> >>> -- >>> 2.30.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sed: Update to 4.8 2021-02-03 22:34 ` Michael Tremer @ 2021-02-04 7:25 ` Adolf Belka 2021-02-04 8:21 ` Matthias Fischer 0 siblings, 1 reply; 7+ messages in thread From: Adolf Belka @ 2021-02-04 7:25 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 5957 bytes --] Hi, Were all my "no new line" errors fixed or do I need to redo any of the patches. Regards, Adolf On 03/02/2021 23:34, Michael Tremer wrote: > Hi, > >> On 3 Feb 2021, at 22:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >> >> Hi Michael, >> >> On 03/02/2021 23:27, Michael Tremer wrote: >>> Hi Adolf, >>> In all the patches from today, you seem to have a little issue in the root files. >>> Scroll down please. >>>> On 3 Feb 2021, at 15:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>>> >>>> - Update sed from 4.4 to 4.8 >>>> - Updated rootfile >>>> - Changelog >>>> * Noteworthy changes in release 4.8 (2020-01-14) [stable] >>>> ** Bug fixes >>>> - "sed -i" now creates temporary files with correct umask (limited to u=rwx). >>>> Previously sed would incorrectly set umask on temporary files, resulting >>>> in problems under certain fuse-like file systems. >>>> [bug introduced in sed 4.2.1] >>>> ** Release >>>> distribute gzip-compressed tarballs once again >>>> ** Improvements >>>> a year's worth of gnulib development, including improved DFA performance >>>> * Noteworthy changes in release 4.7 (2018-12-20) [stable] >>>> ** Bug fixes >>>> - Some uses of \b in the C locale and with the DFA matcher would fail, e.g., >>>> the following would mistakenly print "123-x" instead of "123": >>>> echo 123-x|LC_ALL=C sed 's/.\bx//' >>>> - Using a multibyte locale or certain regexp constructs (some ranges, >>>> backreferences) would avoid the bug. [bug introduced in sed 4.6] >>>> * Noteworthy changes in release 4.6 (2018-12-19) [stable] >>>> ** Improvements >>>> - sed now prints a clear error message when r/R/w/W (and s///w) commands >>>> are missing a filename. Previously, w/W commands would fail with confusing >>>> error message, while r/R would be a silent no-op. >>>> - sed now uses fully-buffered output (instead of line-buffered) when >>>> writing to files. This should noticeably improve performance of "sed -i" >>>> and other write commands. >>>> Buffering can be disabled (as before) with "sed -u". >>>> - sed in non-cygwin windows environments (e.g. mingw) now properly handles >>>> '\n' newlines in -b/--binary mode. >>>> ** Bug fixes >>>> - sed no longer accesses invalid memory (heap overflow) when given invalid >>>> backreferences in 's' command [bug#32082, present at least since sed-4.0.6]. >>>> - sed no longer adds extraneous NUL when given s/$//n command. >>>> [related to bug#32271, present since sed-4.0.7] >>>> - sed no longer accesses invalid memory (heap overflow) with s/$//n regexes. >>>> [bug#32271, present since sed-4.3]. >>>> ** New Features >>>> New option, --debug: print the input sed script in canonical form >>>> and annotate program execution. >>>> * Noteworthy changes in release 4.5 (2018-03-31) [stable] >>>> ** Bug fixes >>>> - sed now fails when matching very long input lines (>2GB). >>>> Before, sed would silently ignore the regex without indicating an >>>> error. [Bug present at least since sed-3.02] >>>> - sed no longer rejects comments and closing braces after y/// commands. >>>> [Bug existed at least since sed-3.02] >>>> - sed -E --posix no longer ignores special meaning of '+','?','|' . >>>> [Bug introduced in the original implementation of --posix option in >>>> v4.1a-5-gba68fb4] >>>> - sed -i now creates selinux context based on the context of the symlink >>>> instead of the symlink target. [Bug present since at least sed-4.2] >>>> - sed -i --follow-symlinks remains unchanged. >>>> - sed now treats the sequence '\x5c' (ASCII 92, backslash) as literal >>>> backslash character, not as an escape prefix character. >>>> [Bug present since sed-3.02.80] >>>> Old behavior: >>>> $ echo z | sed -E 's/(z)/\x5c1/' # identical to 's/(z)/\1/' >>>> z >>>> New behavior: >>>> $ echo z | sed -E 's/(z)/\x5c1/' >>>> \1 >>>> >>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> >>>> --- >>>> config/rootfiles/common/sed | 2 +- >>>> lfs/sed | 4 ++-- >>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/config/rootfiles/common/sed b/config/rootfiles/common/sed >>>> index 8db08fa39..f355a89ca 100644 >>>> --- a/config/rootfiles/common/sed >>>> +++ b/config/rootfiles/common/sed >>>> @@ -1,3 +1,3 @@ >>>> bin/sed >>>> #usr/share/info/sed.info >>>> -#usr/share/man/man1/sed.1 >>>> +#usr/share/man/man1/sed.1 >>>> \ No newline at end of file >>> There is a newline missing at the end of it. >> Whoops. My error. For some reason I had it in my memory that I should "not" have a blank line at the end of the rootfile. >> I realise now that I "should" have a blank line at the end of all of them. Will put a note about this in my list of things that I should pay attention to getting right. >> Sorry. Next sets of patches will not have that problem. > > No problem. > > All files have a \n at the end. There are no exceptions as far as I know and every editor should do it automatically. > >> >> Regards, >> Adolf >>> I corrected a couple of them and in general they confuse tar when building the image. >>> Did you change editors or something? >>> -Michael >>>> diff --git a/lfs/sed b/lfs/sed >>>> index 9123183e3..9c5b33e4a 100644 >>>> --- a/lfs/sed >>>> +++ b/lfs/sed >>>> @@ -24,7 +24,7 @@ >>>> >>>> include Config >>>> >>>> -VER = 4.4 >>>> +VER = 4.8 >>>> >>>> THISAPP = sed-$(VER) >>>> DL_FILE = $(THISAPP).tar.xz >>>> @@ -53,7 +53,7 @@ objects = $(DL_FILE) >>>> >>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >>>> >>>> -$(DL_FILE)_MD5 = e0c583d4c380059abd818cd540fe6938 >>>> +$(DL_FILE)_MD5 = 6d906edfdb3202304059233f51f9a71d >>>> >>>> install : $(TARGET) >>>> >>>> -- >>>> 2.30.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sed: Update to 4.8 2021-02-04 7:25 ` Adolf Belka @ 2021-02-04 8:21 ` Matthias Fischer 2021-02-05 18:01 ` Michael Tremer 0 siblings, 1 reply; 7+ messages in thread From: Matthias Fischer @ 2021-02-04 8:21 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 6397 bytes --] Hi Adolf, in case you need it: to change a lot of your files and don't want to open one by one: sed -i -e '$a\' [FILENAME(S)] does this for me. Simple, fast. ;-) Don't know if you knew this already, just a tip. HTH, Matthias On 04.02.2021 08:25, Adolf Belka wrote: > Hi, > > Were all my "no new line" errors fixed or do I need to redo any of the patches. > > Regards, > Adolf > > On 03/02/2021 23:34, Michael Tremer wrote: >> Hi, >> >>> On 3 Feb 2021, at 22:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>> >>> Hi Michael, >>> >>> On 03/02/2021 23:27, Michael Tremer wrote: >>>> Hi Adolf, >>>> In all the patches from today, you seem to have a little issue in the root files. >>>> Scroll down please. >>>>> On 3 Feb 2021, at 15:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>>>> >>>>> - Update sed from 4.4 to 4.8 >>>>> - Updated rootfile >>>>> - Changelog >>>>> * Noteworthy changes in release 4.8 (2020-01-14) [stable] >>>>> ** Bug fixes >>>>> - "sed -i" now creates temporary files with correct umask (limited to u=rwx). >>>>> Previously sed would incorrectly set umask on temporary files, resulting >>>>> in problems under certain fuse-like file systems. >>>>> [bug introduced in sed 4.2.1] >>>>> ** Release >>>>> distribute gzip-compressed tarballs once again >>>>> ** Improvements >>>>> a year's worth of gnulib development, including improved DFA performance >>>>> * Noteworthy changes in release 4.7 (2018-12-20) [stable] >>>>> ** Bug fixes >>>>> - Some uses of \b in the C locale and with the DFA matcher would fail, e.g., >>>>> the following would mistakenly print "123-x" instead of "123": >>>>> echo 123-x|LC_ALL=C sed 's/.\bx//' >>>>> - Using a multibyte locale or certain regexp constructs (some ranges, >>>>> backreferences) would avoid the bug. [bug introduced in sed 4.6] >>>>> * Noteworthy changes in release 4.6 (2018-12-19) [stable] >>>>> ** Improvements >>>>> - sed now prints a clear error message when r/R/w/W (and s///w) commands >>>>> are missing a filename. Previously, w/W commands would fail with confusing >>>>> error message, while r/R would be a silent no-op. >>>>> - sed now uses fully-buffered output (instead of line-buffered) when >>>>> writing to files. This should noticeably improve performance of "sed -i" >>>>> and other write commands. >>>>> Buffering can be disabled (as before) with "sed -u". >>>>> - sed in non-cygwin windows environments (e.g. mingw) now properly handles >>>>> '\n' newlines in -b/--binary mode. >>>>> ** Bug fixes >>>>> - sed no longer accesses invalid memory (heap overflow) when given invalid >>>>> backreferences in 's' command [bug#32082, present at least since sed-4.0.6]. >>>>> - sed no longer adds extraneous NUL when given s/$//n command. >>>>> [related to bug#32271, present since sed-4.0.7] >>>>> - sed no longer accesses invalid memory (heap overflow) with s/$//n regexes. >>>>> [bug#32271, present since sed-4.3]. >>>>> ** New Features >>>>> New option, --debug: print the input sed script in canonical form >>>>> and annotate program execution. >>>>> * Noteworthy changes in release 4.5 (2018-03-31) [stable] >>>>> ** Bug fixes >>>>> - sed now fails when matching very long input lines (>2GB). >>>>> Before, sed would silently ignore the regex without indicating an >>>>> error. [Bug present at least since sed-3.02] >>>>> - sed no longer rejects comments and closing braces after y/// commands. >>>>> [Bug existed at least since sed-3.02] >>>>> - sed -E --posix no longer ignores special meaning of '+','?','|' . >>>>> [Bug introduced in the original implementation of --posix option in >>>>> v4.1a-5-gba68fb4] >>>>> - sed -i now creates selinux context based on the context of the symlink >>>>> instead of the symlink target. [Bug present since at least sed-4.2] >>>>> - sed -i --follow-symlinks remains unchanged. >>>>> - sed now treats the sequence '\x5c' (ASCII 92, backslash) as literal >>>>> backslash character, not as an escape prefix character. >>>>> [Bug present since sed-3.02.80] >>>>> Old behavior: >>>>> $ echo z | sed -E 's/(z)/\x5c1/' # identical to 's/(z)/\1/' >>>>> z >>>>> New behavior: >>>>> $ echo z | sed -E 's/(z)/\x5c1/' >>>>> \1 >>>>> >>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> >>>>> --- >>>>> config/rootfiles/common/sed | 2 +- >>>>> lfs/sed | 4 ++-- >>>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/config/rootfiles/common/sed b/config/rootfiles/common/sed >>>>> index 8db08fa39..f355a89ca 100644 >>>>> --- a/config/rootfiles/common/sed >>>>> +++ b/config/rootfiles/common/sed >>>>> @@ -1,3 +1,3 @@ >>>>> bin/sed >>>>> #usr/share/info/sed.info >>>>> -#usr/share/man/man1/sed.1 >>>>> +#usr/share/man/man1/sed.1 >>>>> \ No newline at end of file >>>> There is a newline missing at the end of it. >>> Whoops. My error. For some reason I had it in my memory that I should "not" have a blank line at the end of the rootfile. >>> I realise now that I "should" have a blank line at the end of all of them. Will put a note about this in my list of things that I should pay attention to getting right. >>> Sorry. Next sets of patches will not have that problem. >> >> No problem. >> >> All files have a \n at the end. There are no exceptions as far as I know and every editor should do it automatically. >> >>> >>> Regards, >>> Adolf >>>> I corrected a couple of them and in general they confuse tar when building the image. >>>> Did you change editors or something? >>>> -Michael >>>>> diff --git a/lfs/sed b/lfs/sed >>>>> index 9123183e3..9c5b33e4a 100644 >>>>> --- a/lfs/sed >>>>> +++ b/lfs/sed >>>>> @@ -24,7 +24,7 @@ >>>>> >>>>> include Config >>>>> >>>>> -VER = 4.4 >>>>> +VER = 4.8 >>>>> >>>>> THISAPP = sed-$(VER) >>>>> DL_FILE = $(THISAPP).tar.xz >>>>> @@ -53,7 +53,7 @@ objects = $(DL_FILE) >>>>> >>>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >>>>> >>>>> -$(DL_FILE)_MD5 = e0c583d4c380059abd818cd540fe6938 >>>>> +$(DL_FILE)_MD5 = 6d906edfdb3202304059233f51f9a71d >>>>> >>>>> install : $(TARGET) >>>>> >>>>> -- >>>>> 2.30.0 >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sed: Update to 4.8 2021-02-04 8:21 ` Matthias Fischer @ 2021-02-05 18:01 ` Michael Tremer 0 siblings, 0 replies; 7+ messages in thread From: Michael Tremer @ 2021-02-05 18:01 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 6755 bytes --] Thanks for the command. I ran it on next and committed the result. -Michael > On 4 Feb 2021, at 08:21, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote: > > Hi Adolf, > > in case you need it: to change a lot of your files and don't want to > open one by one: > > sed -i -e '$a\' [FILENAME(S)] > > does this for me. Simple, fast. ;-) > > Don't know if you knew this already, just a tip. > > HTH, > Matthias > > On 04.02.2021 08:25, Adolf Belka wrote: >> Hi, >> >> Were all my "no new line" errors fixed or do I need to redo any of the patches. >> >> Regards, >> Adolf >> >> On 03/02/2021 23:34, Michael Tremer wrote: >>> Hi, >>> >>>> On 3 Feb 2021, at 22:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>>> >>>> Hi Michael, >>>> >>>> On 03/02/2021 23:27, Michael Tremer wrote: >>>>> Hi Adolf, >>>>> In all the patches from today, you seem to have a little issue in the root files. >>>>> Scroll down please. >>>>>> On 3 Feb 2021, at 15:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >>>>>> >>>>>> - Update sed from 4.4 to 4.8 >>>>>> - Updated rootfile >>>>>> - Changelog >>>>>> * Noteworthy changes in release 4.8 (2020-01-14) [stable] >>>>>> ** Bug fixes >>>>>> - "sed -i" now creates temporary files with correct umask (limited to u=rwx). >>>>>> Previously sed would incorrectly set umask on temporary files, resulting >>>>>> in problems under certain fuse-like file systems. >>>>>> [bug introduced in sed 4.2.1] >>>>>> ** Release >>>>>> distribute gzip-compressed tarballs once again >>>>>> ** Improvements >>>>>> a year's worth of gnulib development, including improved DFA performance >>>>>> * Noteworthy changes in release 4.7 (2018-12-20) [stable] >>>>>> ** Bug fixes >>>>>> - Some uses of \b in the C locale and with the DFA matcher would fail, e.g., >>>>>> the following would mistakenly print "123-x" instead of "123": >>>>>> echo 123-x|LC_ALL=C sed 's/.\bx//' >>>>>> - Using a multibyte locale or certain regexp constructs (some ranges, >>>>>> backreferences) would avoid the bug. [bug introduced in sed 4.6] >>>>>> * Noteworthy changes in release 4.6 (2018-12-19) [stable] >>>>>> ** Improvements >>>>>> - sed now prints a clear error message when r/R/w/W (and s///w) commands >>>>>> are missing a filename. Previously, w/W commands would fail with confusing >>>>>> error message, while r/R would be a silent no-op. >>>>>> - sed now uses fully-buffered output (instead of line-buffered) when >>>>>> writing to files. This should noticeably improve performance of "sed -i" >>>>>> and other write commands. >>>>>> Buffering can be disabled (as before) with "sed -u". >>>>>> - sed in non-cygwin windows environments (e.g. mingw) now properly handles >>>>>> '\n' newlines in -b/--binary mode. >>>>>> ** Bug fixes >>>>>> - sed no longer accesses invalid memory (heap overflow) when given invalid >>>>>> backreferences in 's' command [bug#32082, present at least since sed-4.0.6]. >>>>>> - sed no longer adds extraneous NUL when given s/$//n command. >>>>>> [related to bug#32271, present since sed-4.0.7] >>>>>> - sed no longer accesses invalid memory (heap overflow) with s/$//n regexes. >>>>>> [bug#32271, present since sed-4.3]. >>>>>> ** New Features >>>>>> New option, --debug: print the input sed script in canonical form >>>>>> and annotate program execution. >>>>>> * Noteworthy changes in release 4.5 (2018-03-31) [stable] >>>>>> ** Bug fixes >>>>>> - sed now fails when matching very long input lines (>2GB). >>>>>> Before, sed would silently ignore the regex without indicating an >>>>>> error. [Bug present at least since sed-3.02] >>>>>> - sed no longer rejects comments and closing braces after y/// commands. >>>>>> [Bug existed at least since sed-3.02] >>>>>> - sed -E --posix no longer ignores special meaning of '+','?','|' . >>>>>> [Bug introduced in the original implementation of --posix option in >>>>>> v4.1a-5-gba68fb4] >>>>>> - sed -i now creates selinux context based on the context of the symlink >>>>>> instead of the symlink target. [Bug present since at least sed-4.2] >>>>>> - sed -i --follow-symlinks remains unchanged. >>>>>> - sed now treats the sequence '\x5c' (ASCII 92, backslash) as literal >>>>>> backslash character, not as an escape prefix character. >>>>>> [Bug present since sed-3.02.80] >>>>>> Old behavior: >>>>>> $ echo z | sed -E 's/(z)/\x5c1/' # identical to 's/(z)/\1/' >>>>>> z >>>>>> New behavior: >>>>>> $ echo z | sed -E 's/(z)/\x5c1/' >>>>>> \1 >>>>>> >>>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> >>>>>> --- >>>>>> config/rootfiles/common/sed | 2 +- >>>>>> lfs/sed | 4 ++-- >>>>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git a/config/rootfiles/common/sed b/config/rootfiles/common/sed >>>>>> index 8db08fa39..f355a89ca 100644 >>>>>> --- a/config/rootfiles/common/sed >>>>>> +++ b/config/rootfiles/common/sed >>>>>> @@ -1,3 +1,3 @@ >>>>>> bin/sed >>>>>> #usr/share/info/sed.info >>>>>> -#usr/share/man/man1/sed.1 >>>>>> +#usr/share/man/man1/sed.1 >>>>>> \ No newline at end of file >>>>> There is a newline missing at the end of it. >>>> Whoops. My error. For some reason I had it in my memory that I should "not" have a blank line at the end of the rootfile. >>>> I realise now that I "should" have a blank line at the end of all of them. Will put a note about this in my list of things that I should pay attention to getting right. >>>> Sorry. Next sets of patches will not have that problem. >>> >>> No problem. >>> >>> All files have a \n at the end. There are no exceptions as far as I know and every editor should do it automatically. >>> >>>> >>>> Regards, >>>> Adolf >>>>> I corrected a couple of them and in general they confuse tar when building the image. >>>>> Did you change editors or something? >>>>> -Michael >>>>>> diff --git a/lfs/sed b/lfs/sed >>>>>> index 9123183e3..9c5b33e4a 100644 >>>>>> --- a/lfs/sed >>>>>> +++ b/lfs/sed >>>>>> @@ -24,7 +24,7 @@ >>>>>> >>>>>> include Config >>>>>> >>>>>> -VER = 4.4 >>>>>> +VER = 4.8 >>>>>> >>>>>> THISAPP = sed-$(VER) >>>>>> DL_FILE = $(THISAPP).tar.xz >>>>>> @@ -53,7 +53,7 @@ objects = $(DL_FILE) >>>>>> >>>>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE) >>>>>> >>>>>> -$(DL_FILE)_MD5 = e0c583d4c380059abd818cd540fe6938 >>>>>> +$(DL_FILE)_MD5 = 6d906edfdb3202304059233f51f9a71d >>>>>> >>>>>> install : $(TARGET) >>>>>> >>>>>> -- >>>>>> 2.30.0 >>> >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-05 18:01 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-03 15:01 [PATCH] sed: Update to 4.8 Adolf Belka 2021-02-03 22:27 ` Michael Tremer 2021-02-03 22:33 ` Adolf Belka 2021-02-03 22:34 ` Michael Tremer 2021-02-04 7:25 ` Adolf Belka 2021-02-04 8:21 ` Matthias Fischer 2021-02-05 18:01 ` Michael Tremer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox