From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4bSct56bc7z32Xv for ; Thu, 26 Jun 2025 12:09:01 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4bSct22wmhz32Xt for ; Thu, 26 Jun 2025 12:08:58 +0000 (UTC) Received: from regulus.brecht-schule.hamburg (regulus.brecht-schule.hamburg [84.46.83.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "regulus.brecht-schule.hamburg", Issuer "R10" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4bSct11Blvz1JG for ; Thu, 26 Jun 2025 12:08:57 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=pass header.d=brecht-schule.hamburg header.s=202101ed25519 header.b=UGsnYPpL; dkim=pass header.d=brecht-schule.hamburg header.s=202101rsa header.b=nIsAFiot; spf=pass (mail01.ipfire.org: domain of dietzmann@brecht-schule.hamburg designates 84.46.83.131 as permitted sender) smtp.mailfrom=dietzmann@brecht-schule.hamburg; dmarc=pass (policy=reject) header.from=brecht-schule.hamburg ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1750939737; a=rsa-sha256; cv=none; b=AaGPNZGBQh1dOf0KdfTLkLKgoWbLMjFZaUNKidRnA5nQ+Q7S1PNI2EthaFM43f7O3fdQj8 GMk/fgSOJXus4nLLcFadsO9jAsNqXZiRB+j9h7pg3weDq/dRQGuWbdCjzTIZQNNQAaaLm3 t3VRf7vKNY8Vwjel9pfAfP2P+hBluS0FbHgVtaKpzwtIDcXh//2FA4MTX0zRxjnoPoLK05 v11ilCzUfPUtSVmg0IvcjEb6iFgLrIz1BUAaJZ9kVlZJTfJMo9nuPfN6h3k8lw6X80eG2M 4KAmxoRb0v3CIoWZwdyTAk8owRji43SakhxdOl7vlAui6ysnRCQe+ykOq/LHTA== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=brecht-schule.hamburg header.s=202101ed25519 header.b=UGsnYPpL; dkim=pass header.d=brecht-schule.hamburg header.s=202101rsa header.b=nIsAFiot; spf=pass (mail01.ipfire.org: domain of dietzmann@brecht-schule.hamburg designates 84.46.83.131 as permitted sender) smtp.mailfrom=dietzmann@brecht-schule.hamburg; dmarc=pass (policy=reject) header.from=brecht-schule.hamburg ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1750939737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uG2/wr6RuEEhCWkSUueQwIdSt1AUjd2mfsskoD2M/Sc=; b=gfNsqdiVk47D256ugBoalKOlraEUdSyTY7lLMs2c6acfZWnZFtU00YKWMzouiF+OmvgLBV 8RVI46gETPUWR92bbWqZdcmUh34jZxwQB247MMEDMegRbDftSIbcMA0LF0iX8ZoM36m48r dyu4rOHzxg6HLlXRMsWlsJCt/6zectrlCx5Y7eNtTTx1nbzVgsuWLanKujZEk59wJcN4cC dMPAJZIsvIGu0UAGZ/8J9xVRjEgbJLA/4g0uMw2MCFN0BV9l8KMWXNheFDdYi4eoPKay55 XzoIihGFl+DUeJNujvLDKCS8YNhqCSJ0tUb7li4PMydkgA2v0E7H50bZrdyNtQ== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by regulus.brecht-schule.hamburg (Postfix) with ESMTPSA id 4bScsz3LK6zgYR4; Thu, 26 Jun 2025 14:08:55 +0200 (CEST) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=brecht-schule.hamburg; s=202101ed25519; t=1750939735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uG2/wr6RuEEhCWkSUueQwIdSt1AUjd2mfsskoD2M/Sc=; b=UGsnYPpLuKVdznV/kOVYjGI2n6/1Og5Srnjzf/WEBdj1fu5JUj0fksUUJBU4Jkp4rYlLEv BztCowndFH1LwpAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brecht-schule.hamburg; s=202101rsa; t=1750939735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uG2/wr6RuEEhCWkSUueQwIdSt1AUjd2mfsskoD2M/Sc=; b=nIsAFiotAUapBfXBdpYe5CFWwFMBGAq55DIApq+L7A1AG6qYQaBs6jkwgMEeggoIfVIXbQ xvFLwDRO8G6kU4yXhCfXmrIWcia94yzhAZLy1bOgT+viQBuKgRgTlv8wQsDMmg/syB1YQE /bGya0H2vyPjLt7zJ1J6u38hBn4327Nx9zlOhpUkg0y53zA3GVBVyVrKI8rJQCoBjhK9Be T0fMgHMM+rY5vMtzO/Oc4qnHJ88DE45WbVtq1ycQmLnTN8yoIEzyeXtEnjm7p6QkqT2Y/n xrSK5m54W4t0IZb62gj0489dVJPm9esqE8UzL5PHH2ef1vUTctjuh8WR5/md8g== Message-ID: <92ca5601-7d10-4abd-9e5a-8f61ac1d20ad@brecht-schule.hamburg> Date: Thu, 26 Jun 2025 14:08:54 +0200 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: [EXTERN] Re: [PATCH 4/5] fwhosts.cgi: Move the tooltip into the usage counter Content-Language: de-DE To: Michael Tremer , Adolf Belka Cc: "IPFire: Development-List" References: <20250623171658.530138-1-michael.tremer@ipfire.org> <20250623171658.530138-4-michael.tremer@ipfire.org> <2bf6ef30-c057-4d39-98d5-8ef4ea35edea@ipfire.org> From: Peer Dietzmann Organization: Brecht Schule Hamburg / Brecht-IT In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-0.89 / 11.00]; BAYES_HAM(-3.00)[100.00%]; IP_REPUTATION_SPAM(2.74)[asn: 15943(0.19), country: DE(0.00), ip: 84.46.83.131(0.49)]; DWL_DNSWL_MED(-2.00)[brecht-schule.hamburg:dkim]; SPF_REPUTATION_SPAM(1.68)[0.56016500214994]; R_DKIM_ALLOW(0.89)[brecht-schule.hamburg:s=202101ed25519,brecht-schule.hamburg:s=202101rsa]; DKIM_REPUTATION(0.61)[0.60951568859837]; NEURAL_HAM(-0.51)[-0.505]; DMARC_POLICY_ALLOW(-0.50)[brecht-schule.hamburg,reject]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[84.46.83.131:from]; ONCE_RECEIVED(0.20)[]; R_SPF_ALLOW(-0.20)[+ip4:84.46.83.131]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:15943, ipnet:84.46.0.0/17, country:DE]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; HAS_ORG_HEADER(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[brecht-schule.hamburg:+]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; RECEIVED_HELO_LOCALHOST(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_ONE(0.00)[1]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Action: no action X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4bSct11Blvz1JG Hello Michael, Hello Adolf, it was actually a bit hard to find a working solution to place this information somewhere. I scrolled through all the icons IPFire has "built in" and thought that a blue i icon would lead the user to think "oh what's this? What information can I get there?". When hovering then over the icon all necessary information is directly displayed without any button or box or anything which would require additional code and styling. Thereby all other icons are clickable I think there is no additional documentation required, the users will find it on their own. But I am also fine with Michael's solution. -- Best regards Peer On 25.06.25 18:52, Michael Tremer wrote: > Hello Adolf, > > Thank you for the feedback. > > It is indeed not obvious. On the other hand, the large icon is not really a solution either in my opinion. It is simply too large and distracting for a feature that won’t be used *that* much. > > I would however love some visual hint, but I cannot really think of anything between the two options that we have for now. > > -Michael > >> On 25 Jun 2025, at 17:40, Adolf Belka wrote: >> >> Tested-by: Adolf Belka >> >> I actually found the i in a blue circle icon very helpful for this. I was able to figure out where I should place my mouse pointer for the info. >> >> With this patch applied, which was the first way I tested it, I had no idea where to place the mouse pointer as nothing looked different to the existing situation. I did try placing it over the usage counter a couple of times but obviously not for long enough in my first tries as I never saw anything get shown. >> >> Reading the title of this patch more carefully I went back and now held the mouse pointer over the usage counter and waited for 1 to 2 seconds and now the info was shown. Typically I found it takes a minimum of 1 second and sometimes around 1.5 seconds before anything is shown and first time around I was obviously not waiting long enough at any one location. >> >> If the usage counter is to stay as the location to place the mouse pointer onto for the info then I think this will need to be explained very clearly in the wiki documentation otherwise users might not discover this useful function directly on the WUI page. >> >> >> On 23/06/2025 19:16, Michael Tremer wrote: >>> This will clutter the page less as we don't have any good icon sets. >>> Signed-off-by: Michael Tremer >>> --- >>> html/cgi-bin/fwhosts.cgi | 42 +++++++++++----------------------------- >>> 1 file changed, 11 insertions(+), 31 deletions(-) >>> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi >>> index 69970a840..953f81e5f 100644 >>> --- a/html/cgi-bin/fwhosts.cgi >>> +++ b/html/cgi-bin/fwhosts.cgi >>> @@ -1932,7 +1932,7 @@ sub viewtablenet >>> }else{ >>> print<>> >>> - >>> + >>> END >>> } >>> my $count=0; >>> @@ -1953,11 +1953,7 @@ END >>> my $colnet="$customnetwork{$key}[1]/".&General::subtocidr($customnetwork{$key}[2]); >>> my $netcount=&getnetcount($customnetwork{$key}[0]); >>> my $netusedin=&getusedin($customnetwork{$key}[0]); >>> - my $htmlparttouse=""; >>> - if ($netusedin) { >>> - $htmlparttouse = ""; >>> - } >>> - print""; >>> + print""; >>> print<>>
$Lang::tr{'name'}$Lang::tr{'fwhost netaddress'}$Lang::tr{'remark'}$Lang::tr{'used'}
$Lang::tr{'name'}$Lang::tr{'fwhost netaddress'}$Lang::tr{'remark'}$Lang::tr{'used'}
$customnetwork{$key}[0]
".&getcolor($colnet)."$customnetwork{$key}[3]$netcount x$htmlparttouse$customnetwork{$key}[0]".&getcolor($colnet)."$customnetwork{$key}[3]$netcount x >>> >>> @@ -2091,7 +2087,7 @@ sub viewtablehost >>> }else{ >>> print<>> >>> - >>> + >>> END >>> } >>> my $count=0; >>> @@ -2112,12 +2108,9 @@ END >>> my $hostcount=0; >>> $hostcount=&gethostcount($customhost{$key}[0]); >>> my $hostusedin=&getusedin($customhost{$key}[0]); >>> - my $htmlparttouse=""; >>> - if ($hostusedin) { >>> - $htmlparttouse = ""; >>> - } >>> - print""; >>> - print<>> + my $color = &getcolor($ip); >>> + print <>> + >>>
$Lang::tr{'name'}$Lang::tr{'fwhost ip_mac'}$Lang::tr{'remark'}$Lang::tr{'used'}
$Lang::tr{'name'}$Lang::tr{'fwhost ip_mac'}$Lang::tr{'remark'}$Lang::tr{'used'}
$customhost{$key}[0]".&getcolor($ip)."$customhost{$key}[3]$hostcount x$htmlparttouse$customhost{$key}[0]$color$customhost{$key}[3]$hostcount x >>> >>> >>> @@ -2192,11 +2185,8 @@ sub viewtablegrp >>> print "
$grpname   "; >>> print " $Lang::tr{'remark'}:  $remark   " if ($remark ne ''); >>> my $netgrpcount=&getnetcount($grpname); >>> - print "$Lang::tr{'used'}: $netgrpcount x "; >>> my $groupusedin=&getusedin($grpname); >>> - if ($groupusedin) { >>> - print ""; >>> - } >>> + print "$Lang::tr{'used'}: $netgrpcount x"; >>> if($netgrpcount == '0') >>> { >>> print""; >>> @@ -2335,10 +2325,7 @@ sub viewtablelocationgrp >>> # Get group count. >>> my $locationgrpcount=&getlocationcount($grpname); >>> my $locationusedin=&getlocusedin($grpname); >>> - print "$Lang::tr{'used'}: $locationgrpcount x "; >>> - if ($locationusedin) { >>> - print ""; >>> - } >>> + print "$Lang::tr{'used'}: $locationgrpcount x"; >>> # Only display delete icon, if the group is not used by a firewall rule. >>> if($locationgrpcount == '0') { >>> print"
\n"; >>> @@ -2459,7 +2446,7 @@ sub viewtableservice >>> &General::readhasharray("$fwconfigout", \%fwout); >>> print<>> >>> - >>> + >>> END >>> my $col=''; >>> foreach my $key (sort { ncmp($customservice{$a}[0],$customservice{$b}[0])} keys %customservice) >>> @@ -2481,14 +2468,10 @@ END >>> #Neuer count >>> $srvcount=&getsrvcount($customservice{$key}[0]); >>> my $serviceusedin=&getsrvusedin($customservice{$key}[0]); >>> - my $htmlparttouse=""; >>> - if ($serviceusedin) { >>> - $htmlparttouse=""; >>> - } >>> if($customservice{$key}[3] eq 'All ICMP-Types'){print $Lang::tr{'fwdfw all icmp'};} >>> elsif($customservice{$key}[3] ne 'BLANK'){print $customservice{$key}[3];} >>> print<>> - >>> + >>>
$Lang::tr{'fwhost srv_name'}$Lang::tr{'fwhost prot'}$Lang::tr{'fwhost port'}ICMP$Lang::tr{'fwhost used'}
$Lang::tr{'fwhost srv_name'}$Lang::tr{'fwhost prot'}$Lang::tr{'fwhost port'}ICMP$Lang::tr{'fwhost used'}
$srvcount x$htmlparttouse$srvcount x >>> >>> >>> @@ -2560,11 +2543,8 @@ sub viewtableservicegrp >>> if($count >0){print"
";$count=1;} >>> print "
$grpname    "; >>> print "$Lang::tr{'remark'}:  $remark " if ($remark ne ''); >>> - print "  $Lang::tr{'used'}: $grpcount x "; >>> my $srvgrpusedin=&getsrvusedin($customservicegrp{$key}[0]); >>> - if ($srvgrpusedin) { >>> - print ""; >>> - } >>> + print "  $Lang::tr{'used'}: $grpcount x"; >>> if($grpcount == '0') >>> { >>> print""; -- Mit freundlichem Gruß Peer Dietzmann Brecht-IT | Administration und Support Brecht-Schule Hamburg GmbH Norderstrasse 163-165 | 20097 Hamburg Tel.: +49 40 21 11 12 - 37 | Fax: +49 40 21 11 12 - 20 E-Mail: dietzmann@brecht-schule.hamburg | www.brecht-schule.hamburg Diese Email enthält ggfs. vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese Email irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Email. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Email ist nicht gestattet.