From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Trying to update gd Date: Fri, 18 Jun 2021 23:26:50 +0200 Message-ID: <939f59ab-2116-7bf4-2c65-0fa73ba4a9d7@ipfire.org> In-Reply-To: <41E6BF14-232C-44D6-981D-75CE7012E959@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7664242290108524626==" List-Id: --===============7664242290108524626== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 18/06/2021 10:35, Michael Tremer wrote: > Hello, >=20 >> On 17 Jun 2021, at 19:53, Adolf Belka wrote: >> >> Hi All, >> >> I found that gd was at version 2.0.33 from 2006 and there have been severa= l updates all the way up to May this year, some of them to fix bugs or securi= ty concerns. >=20 > Definitely needs an update! >=20 >> So I did a build for version 2.3.1 also taking the opportunity to disable-= static libraries. >> >> This built successfully and I also ran the find-dependencies as the librar= ies changed from libgd.so.2.0.0 to libgd.3.0.9 There were no dependencies on= libgd.so.2 or libgd.2.0.0 >> >> As gd is used for the charts I installed the generated iso into a vm on my= testbed system to confirm they worked. >> >> None of the charts showed any data. Also the log pie charts did not work. = The error message from httpd/error_log was:- >> >> >> Can't load '/usr/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi/auto= /GD/GD.so' for module GD: libtiff.so.5: cannot open shared object file: No su= ch file or directory at /usr/lib/perl5/5.32.1/x86_64-linux-thread-multi/DynaL= oader.pm line 193. >> ^@ at /srv/web/ipfire/cgi-bin/getrrdimage.cgi line 24. >> Compilation failed in require at /srv/web/ipfire/cgi-bin/getrrdimage.cgi l= ine 24. >> BEGIN failed--compilation aborted at /srv/web/ipfire/cgi-bin/getrrdimage.c= gi line 24. >> [Thu Jun 17 16:38:29.559844 2021] [cgid:error] [pid 3156:tid 1272278532316= 80] [client 192.168.200.50:49220] End of script output before headers: getrrd= image.cgi, referer: https://ipfire.localdomain:444/ >> >> >> This seems to be saying it can't find libtiff.so.5 >> >> Looking through the source tarballs over time I found that version 2.1.0 w= as where it started to look for libtiff. >> >> I then installed the libtiff addon in my vm and the charts were all workin= g. So the new gd requires the libtiff shared object libraries. >> >> The addon installs a lot more than just the libtiff so libs so it does not= seem right to build that structurally into the firewall. >> >> >> The only option I have come up with is to copy the libtiff so's into /usr/= lib/ after the install stage of gd. >> >> libtiff is built before gd so the files are available in the build. This w= ould seem to then provide the required libs without the rest of the libtiff f= iles. >> >> Is this a reasonable approach to use or is there a different method I shou= ld be using. >=20 > Can you not pass something like =E2=80=94-disable-tiff to the configure scr= ipt of gd to avoid it linking against libtiff? >=20 > We do not generate any TIFF files here, so it would be safe to disable that= functionality. Thanks very much for the guidance. There was a configure option --without-tif= f so I used that. Built successfully and then tested it in my vm testbed. All= charts except memory.cgi work. I need to get more data to confirm that the l= og pie charts work. With memory.cgi I get an Internal Server Error. The log gives the following:- Bareword "collectd" not allowed while "strict subs" in use at /srv/web/ipfire= /cgi-bin/memory.cgi line 59. Bareword "localhost" not allowed while "strict subs" in use at /srv/web/ipfir= e/cgi-bin/memory.cgi line 59. Bareword "swap" not allowed while "strict subs" in use at /srv/web/ipfire/cgi= -bin/memory.cgi line 59. Execution of /srv/web/ipfire/cgi-bin/memory.cgi aborted due to compilation er= rors. Looking at line 59 and checking in git this looks to be related to a change d= one by Stefan Schantl 8 days ago https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D4353c579248b301= 6740252009b4ed15a4c6f8fe3 I don't want to commit the patch for gd until I have memory.cgi confirmed wor= king and enough firewall data to confirm the pie charts are working but it lo= oks close to completion. Regards, Adolf. > -Michael >=20 >> >> >> Regards, >> >> Adolf. >> >> >> --=20 >> Sent from my laptop >> >=20 --===============7664242290108524626==--