From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: New bootstrap/jQuery WUI theme - based on adminlte
Date: Mon, 07 Jan 2019 14:13:13 +0000
Message-ID: <9429DA66-5F63-4F08-806D-AF684DBD50A2@ipfire.org>
In-Reply-To: =?utf-8?q?=3CAM0PR03MB4932DD29AEE6E920A4047803B6BB0=40AM0PR03MB?=
 =?utf-8?q?4932=2Eeurprd03=2Eprod=2Eoutlook=2Ecom=3E?=
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1923937761998766158=="
List-Id: <development.lists.ipfire.org>

--===============1923937761998766158==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Rachid,

Thank you for writing and apologies for the late reply from me.

Although many people have talked to me about your email in person, nobody had=
 the time to respond.

> On 24 Dec 2018, at 10:32, Rachid Groeneveld <rachidgroeneveld(a)hotmail.nl>=
 wrote:
>=20
> Hi all,
>=20
> I hope I'm doing this right, as it's my first time "posting" to a (developm=
ent) mailing list.

Welcome :)

> Let me introduce myself first; I'm Rachid (Saiyato on the forums) and I've =
been working on a new WUI theme, right now it's a bit bloated compared to the=
 other skins, but it also features a lot; especially in terms of icons. I'm n=
ot a developer by profession, but I do understand some languages (C#, python,=
 perl, javascript), the only problem is that I lack pattern knowledge, which =
means my code might not be a neat as I would like it to be. So please do corr=
ect my erroneous code when you see it =F0=9F=98=89 I do strive to use as litt=
le code as possible and combine/re-use portions, as well as google for the be=
st options (if I can find the right keywords). If you have any questions, don=
't hesitate to contact me, I live in the Netherlands, so Nederlands, English =
or Deutsch is fine.

English is perfect.

> As for the WUI, I used the bootstrap/adminlte framework, which was fairly e=
asy to implement, I threw in some fonts for icons, so it's quite easy to fanc=
y-up your config pages. As this point I did implement an override script for =
some parts of the existing UI's, this way I could 'integrate' those pages bet=
ter, but feel free to provide me with better ways/tip 'n tricks.
>=20
> As you might see I'm struggling with naming... Pascal, camel... all low... =
What should I do best in the IPFire ecosystem?

I usually do the all_lowercase_and_underline_format. Some legacy code UsesThe=
CamelCaseNotation.

> The attached screenshot give an impression of the UI, I did remove the map =
though... it caused all sorts of resizing issues and I'm not sure what kind o=
f reporting actually makes sense on the dash. So that's still an open issue. =
I uploaded the whole lot to github (https://github.com/Saiyato/ipfire-skin-da=
shboard) and created some issues for known problems, it also features an inst=
allation script, which automatically sets the skin (~/main/settings[@THEME]).=
 Since it's bootstrap, it will resize on phones and still remain responsive a=
nd modern looking.
>=20
> Most of the values are displaying real info, I used various cgi's to copy c=
ode from. The only dummy values are the statistics box (since I'm not sure wh=
at makes sense to show there) and guest wifi (maybe someone will make an addo=
n for that, right now it's not supported out-of-the-box, correct me if I'm wr=
ong).

My question would be: Where are you going with this? You have added a new das=
hboard which looks modern and so on. The entire IPFire UI is very old though =
and I am not sure what can be achieved with pure CSS to make it look any bett=
er. That is works on mobile is nice, but not a priority.

So, what do the old pages look like?

We have some ideas for an entirely new design on the artwork mailing list. Ha=
ve a look. I think this already has many similarities.

Best,
-Michael

>=20
> Happy holidays to all and a happy new year in advance!

P.S. Happy New Year!

>=20
> Cheers, Rachid
>=20
> PS: something went wrong attaching the images, so one attachment might be c=
orrupt, mea culpa.
> <ipfire_new_skin.png><ipfire_new_skin_phone_menu_open.png>


--===============1923937761998766158==--