From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] perl-libnet: Provides replacement for deprecated perl-Net-SMTP-SSL
Date: Thu, 25 Mar 2021 09:42:47 +0000 [thread overview]
Message-ID: <9474E62E-C63D-4DE4-AB8E-1BDE216D3F1C@ipfire.org> (raw)
In-Reply-To: <20210324113714.63498-2-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 4681 bytes --]
Hello,
This patch looks good, but I was wondering if we do not want to ship all (sub-)modules that are in here?
Does it work with only shipping that one file?
-Michael
> On 24 Mar 2021, at 11:37, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>
> - libnet is a collection of perl5 modules which all relate to network
> programming.
> - perl-libnet is replacing perl-Net-SMTP-SSL as a dependency for git
> The only module being installed from perl-libnet is Net-SMTP
> Since Net::SMTP v1.28 (2014-10-08), Net::SMTP itself has support for
> SMTP over SSL, and also for STARTTLS
> - Recommendation of the maintainer of module Net-SMTP-SSL is to use
> Net-SMTP and Net-SMTP-SSL has been deprecated.
> - Remove perl-Net-SMTP-SSL from make.sh and replace with perl-libnet
> - Remove perl-Net-SMTP-SSL rootfile
> - Create perl-libnet rootfile
>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/rootfiles/packages/perl-Net-SMTP-SSL | 6 ------
> config/rootfiles/packages/perl-libnet | 19 +++++++++++++++++++
> lfs/{perl-Net-SMTP-SSL => perl-libnet} | 10 +++++-----
> make.sh | 2 +-
> 4 files changed, 25 insertions(+), 12 deletions(-)
> delete mode 100644 config/rootfiles/packages/perl-Net-SMTP-SSL
> create mode 100644 config/rootfiles/packages/perl-libnet
> rename lfs/{perl-Net-SMTP-SSL => perl-libnet} (95%)
>
> diff --git a/config/rootfiles/packages/perl-Net-SMTP-SSL b/config/rootfiles/packages/perl-Net-SMTP-SSL
> deleted file mode 100644
> index 1ac5584f7..000000000
> --- a/config/rootfiles/packages/perl-Net-SMTP-SSL
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -#usr/lib/perl5/site_perl/5.30.0/Net/SMTP
> -usr/lib/perl5/site_perl/5.30.0/Net/SMTP/SSL.pm
> -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/SMTP
> -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/SMTP/SSL
> -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/SMTP/SSL/.packlist
> -#usr/share/man/man3/Net::SMTP::SSL.3
> diff --git a/config/rootfiles/packages/perl-libnet b/config/rootfiles/packages/perl-libnet
> new file mode 100644
> index 000000000..ffe788da0
> --- /dev/null
> +++ b/config/rootfiles/packages/perl-libnet
> @@ -0,0 +1,19 @@
> +#usr/lib/perl5/site_perl/5.30.0/Net/Cmd.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/Config.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/Domain.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP
> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/A.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/E.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/I.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/L.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/dataconn.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/NNTP.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/Netrc.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/POP3.pm
> +usr/lib/perl5/site_perl/5.30.0/Net/SMTP.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/Time.pm
> +#usr/lib/perl5/site_perl/5.30.0/Net/libnet.cfg
> +#usr/lib/perl5/site_perl/5.30.0/Net/libnetFAQ.pod
> +#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/.packlist
> +#usr/share/man/man3/Net::FTP::dataconn.3
> diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-libnet
> similarity index 95%
> rename from lfs/perl-Net-SMTP-SSL
> rename to lfs/perl-libnet
> index 2bb00a808..27e716f82 100644
> --- a/lfs/perl-Net-SMTP-SSL
> +++ b/lfs/perl-libnet
> @@ -24,16 +24,16 @@
>
> include Config
>
> -VER = 1.04
> +VER = 3.13
>
> -THISAPP = Net-SMTP-SSL-$(VER)
> +THISAPP = libnet-$(VER)
> DL_FILE = ${THISAPP}.tar.gz
> DL_FROM = $(URL_IPFIRE)
> DIR_APP = $(DIR_SRC)/$(THISAPP)
> TARGET = $(DIR_INFO)/$(THISAPP)
> -PROG = perl-Net-SMTP-SSL
> +PROG = perl-libnet
> DEPS =
> -PAK_VER = 3
> +PAK_VER = 1
>
> ###############################################################################
> # Top-level Rules
> @@ -43,7 +43,7 @@ objects = $(DL_FILE)
>
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>
> -$(DL_FILE)_MD5 = 62b49c961043898b43b041dafbc1b389
> +$(DL_FILE)_MD5 = 3fa5c6989db687b2381cd42fe55f5134
>
> install : $(TARGET)
>
> diff --git a/make.sh b/make.sh
> index 0c124ac81..8d2e0bfc5 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1499,7 +1499,7 @@ buildipfire() {
> lfsmake2 libmpdclient
> lfsmake2 mpc
> lfsmake2 perl-Net-CIDR-Lite
> - lfsmake2 perl-Net-SMTP-SSL
> + lfsmake2 perl-libnet
> lfsmake2 perl-MIME-Base64
> lfsmake2 perl-Authen-SASL
> lfsmake2 perl-MIME-Lite
> --
> 2.31.0
>
next prev parent reply other threads:[~2021-03-25 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 11:37 [PATCH 0/2] Introduction to perl-libnet patch series Adolf Belka
2021-03-24 11:37 ` [PATCH 1/2] perl-libnet: Provides replacement for deprecated perl-Net-SMTP-SSL Adolf Belka
2021-03-25 9:42 ` Michael Tremer [this message]
2021-03-25 11:58 ` Adolf Belka
2021-03-24 11:37 ` [PATCH 2/2] git: Change dependency from perl-Net-SMTP-SSL to perl-libnet Adolf Belka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9474E62E-C63D-4DE4-AB8E-1BDE216D3F1C@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox