From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH 1/2] perl-libnet: Provides replacement for deprecated perl-Net-SMTP-SSL Date: Thu, 25 Mar 2021 09:42:47 +0000 Message-ID: <9474E62E-C63D-4DE4-AB8E-1BDE216D3F1C@ipfire.org> In-Reply-To: <20210324113714.63498-2-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8932082658522880720==" List-Id: --===============8932082658522880720== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, This patch looks good, but I was wondering if we do not want to ship all (sub= -)modules that are in here? Does it work with only shipping that one file? -Michael > On 24 Mar 2021, at 11:37, Adolf Belka wrote: >=20 > - libnet is a collection of perl5 modules which all relate to network > programming. > - perl-libnet is replacing perl-Net-SMTP-SSL as a dependency for git > The only module being installed from perl-libnet is Net-SMTP > Since Net::SMTP v1.28 (2014-10-08), Net::SMTP itself has support for > SMTP over SSL, and also for STARTTLS > - Recommendation of the maintainer of module Net-SMTP-SSL is to use > Net-SMTP and Net-SMTP-SSL has been deprecated. > - Remove perl-Net-SMTP-SSL from make.sh and replace with perl-libnet > - Remove perl-Net-SMTP-SSL rootfile > - Create perl-libnet rootfile >=20 > Signed-off-by: Adolf Belka > --- > config/rootfiles/packages/perl-Net-SMTP-SSL | 6 ------ > config/rootfiles/packages/perl-libnet | 19 +++++++++++++++++++ > lfs/{perl-Net-SMTP-SSL =3D> perl-libnet} | 10 +++++----- > make.sh | 2 +- > 4 files changed, 25 insertions(+), 12 deletions(-) > delete mode 100644 config/rootfiles/packages/perl-Net-SMTP-SSL > create mode 100644 config/rootfiles/packages/perl-libnet > rename lfs/{perl-Net-SMTP-SSL =3D> perl-libnet} (95%) >=20 > diff --git a/config/rootfiles/packages/perl-Net-SMTP-SSL b/config/rootfiles= /packages/perl-Net-SMTP-SSL > deleted file mode 100644 > index 1ac5584f7..000000000 > --- a/config/rootfiles/packages/perl-Net-SMTP-SSL > +++ /dev/null > @@ -1,6 +0,0 @@ > -#usr/lib/perl5/site_perl/5.30.0/Net/SMTP > -usr/lib/perl5/site_perl/5.30.0/Net/SMTP/SSL.pm > -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/= SMTP > -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/= SMTP/SSL > -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/= SMTP/SSL/.packlist > -#usr/share/man/man3/Net::SMTP::SSL.3 > diff --git a/config/rootfiles/packages/perl-libnet b/config/rootfiles/packa= ges/perl-libnet > new file mode 100644 > index 000000000..ffe788da0 > --- /dev/null > +++ b/config/rootfiles/packages/perl-libnet > @@ -0,0 +1,19 @@ > +#usr/lib/perl5/site_perl/5.30.0/Net/Cmd.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/Config.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/Domain.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/FTP > +#usr/lib/perl5/site_perl/5.30.0/Net/FTP.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/A.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/E.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/I.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/L.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/dataconn.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/NNTP.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/Netrc.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/POP3.pm > +usr/lib/perl5/site_perl/5.30.0/Net/SMTP.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/Time.pm > +#usr/lib/perl5/site_perl/5.30.0/Net/libnet.cfg > +#usr/lib/perl5/site_perl/5.30.0/Net/libnetFAQ.pod > +#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/= .packlist > +#usr/share/man/man3/Net::FTP::dataconn.3 > diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-libnet > similarity index 95% > rename from lfs/perl-Net-SMTP-SSL > rename to lfs/perl-libnet > index 2bb00a808..27e716f82 100644 > --- a/lfs/perl-Net-SMTP-SSL > +++ b/lfs/perl-libnet > @@ -24,16 +24,16 @@ >=20 > include Config >=20 > -VER =3D 1.04 > +VER =3D 3.13 >=20 > -THISAPP =3D Net-SMTP-SSL-$(VER) > +THISAPP =3D libnet-$(VER) > DL_FILE =3D ${THISAPP}.tar.gz > DL_FROM =3D $(URL_IPFIRE) > DIR_APP =3D $(DIR_SRC)/$(THISAPP) > TARGET =3D $(DIR_INFO)/$(THISAPP) > -PROG =3D perl-Net-SMTP-SSL > +PROG =3D perl-libnet > DEPS =3D > -PAK_VER =3D 3 > +PAK_VER =3D 1 >=20 > ###########################################################################= #### > # Top-level Rules > @@ -43,7 +43,7 @@ objects =3D $(DL_FILE) >=20 > $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >=20 > -$(DL_FILE)_MD5 =3D 62b49c961043898b43b041dafbc1b389 > +$(DL_FILE)_MD5 =3D 3fa5c6989db687b2381cd42fe55f5134 >=20 > install : $(TARGET) >=20 > diff --git a/make.sh b/make.sh > index 0c124ac81..8d2e0bfc5 100755 > --- a/make.sh > +++ b/make.sh > @@ -1499,7 +1499,7 @@ buildipfire() { > lfsmake2 libmpdclient > lfsmake2 mpc > lfsmake2 perl-Net-CIDR-Lite > - lfsmake2 perl-Net-SMTP-SSL > + lfsmake2 perl-libnet > lfsmake2 perl-MIME-Base64 > lfsmake2 perl-Authen-SASL > lfsmake2 perl-MIME-Lite > --=20 > 2.31.0 >=20 --===============8932082658522880720==--