From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] graphs.pl: Change directory name to replace HOSTILE with HOSTILE_DROP - fixes bug#12838
Date: Tue, 05 Apr 2022 13:18:13 +0200 [thread overview]
Message-ID: <9537d2c8-4f65-22aa-02bc-8f22eaf93709@ipfire.org> (raw)
In-Reply-To: <20220404203331.3612132-2-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 04.04.2022 um 22:33 schrieb Adolf Belka:
> From: Bernhard Bitsch <bbitsch(a)ipfire.org>
>
> - The directory name for the hostile data was using HOSTILE while the chain was called
> HOSTILE_DROP. This resulted in the files in the directory not being updated.
>
> Fixes: bug#12838
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/cfgroot/graphs.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
> index b964f1e80..3368e5aad 100644
> --- a/config/cfgroot/graphs.pl
> +++ b/config/cfgroot/graphs.pl
> @@ -693,7 +693,7 @@ sub updatefwhitsgraph {
> "DEF:newnotsyn=".$mainsettings{'RRDLOG'}."/collectd/localhost/iptables-filter-NEWNOTSYN/ipt_bytes-DROP_NEWNOTSYN.rrd:value:AVERAGE",
> "DEF:portscan=".$mainsettings{'RRDLOG'}."/collectd/localhost/iptables-filter-PSCAN/ipt_bytes-DROP_PScan.rrd:value:AVERAGE",
> "DEF:spoofedmartian=".$mainsettings{'RRDLOG'}."/collectd/localhost/iptables-filter-SPOOFED_MARTIAN/ipt_bytes-DROP_SPOOFED_MARTIAN.rrd:value:AVERAGE",
> - "DEF:hostile=".$mainsettings{'RRDLOG'}."/collectd/localhost/iptables-filter-HOSTILE/ipt_bytes-DROP_HOSTILE.rrd:value:AVERAGE",
> + "DEF:hostile=".$mainsettings{'RRDLOG'}."/collectd/localhost/iptables-filter-HOSTILE_DROP/ipt_bytes-DROP_HOSTILE.rrd:value:AVERAGE",
> "COMMENT:".sprintf("%-26s",$Lang::tr{'caption'}),
> "COMMENT:".sprintf("%15s",$Lang::tr{'maximal'}),
> "COMMENT:".sprintf("%15s",$Lang::tr{'average'}),
next prev parent reply other threads:[~2022-04-05 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 20:33 [PATCH 1/2] collectd.conf: Change chain from HOSTILE to " Adolf Belka
2022-04-04 20:33 ` [PATCH 2/2] graphs.pl: Change directory name to replace HOSTILE with " Adolf Belka
2022-04-05 11:18 ` Bernhard Bitsch [this message]
2022-04-05 11:16 ` [PATCH 1/2] collectd.conf: Change chain from HOSTILE to " Bernhard Bitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9537d2c8-4f65-22aa-02bc-8f22eaf93709@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox