From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Hofmann <hofmann@leo-andres.de>
To: development@lists.ipfire.org
Subject: Re: [PATCH] RRD graphs: Remove padding around graph images
Date: Wed, 14 Jul 2021 22:31:41 +0200
Message-ID: <956d2bea-7c95-d45f-5c69-184fa9443733@leo-andres.de>
In-Reply-To: <6B3B8C0D-4394-4875-98C0-B6E06565F5C5@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2707253938019561773=="
List-Id: <development.lists.ipfire.org>

--===============2707253938019561773==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

thank you for reviewing this. I think that's a good idea, I'll give it a try.

Regards
Leo

Am 14.07.2021 um 18:31 schrieb Michael Tremer:
> Hello,
>
> This looks like a valid fix:
>
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>
> Would it be a good consideration to render the graphs in SVG format instead=
? That way they could never be blurry because it is a vector graphic.
>
> Best,
> -Michael
>
>> On 11 Jul 2021, at 19:22, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wro=
te:
>>
>> The images inherited padding from the general design and
>> have been resized to fit the layout, resulting in blurred graphs.
>> This removes the padding and shows the graphs in full size.
>>
>> Fixes: #12657
>>
>> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
>> ---
>> html/html/themes/ipfire/include/css/style.css | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/html/html/themes/ipfire/include/css/style.css b/html/html/the=
mes/ipfire/include/css/style.css
>> index 2c727a770..b92f476c4 100644
>> --- a/html/html/themes/ipfire/include/css/style.css
>> +++ b/html/html/themes/ipfire/include/css/style.css
>> @@ -359,7 +359,7 @@ div.rrdimage > ul {
>> }
>>
>> div.rrdimage > img {
>> -	box-sizing: border-box;
>> +	padding: 0;
>> 	max-width: 100%;
>> 	min-height: 290px;
>> }
>> --=20
>> 2.27.0.windows.1
>>

--===============2707253938019561773==--