From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: The unshared changes give a problem with build after doing git
 pull on next
Date: Thu, 29 Aug 2024 09:41:08 +0200
Message-ID: <95FFE345-9CA5-4B14-A6C1-F8423FF5028A@ipfire.org>
In-Reply-To: <db831997-9f03-42e6-bd26-fd42c0bd448f@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7332124356995536131=="
List-Id: <development.lists.ipfire.org>

--===============7332124356995536131==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 28 Aug 2024, at 19:52, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> Hi All,
>=20
> On 28/08/2024 18:30, Matthias Fischer wrote:
>> On 28.08.2024 17:46, Michael Tremer wrote:
>>> Hello everyone,
>> Hi,
>>=20
>>> Could you please confirm that this works:
>>>=20
>>>   https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D5e8730eb9=
aec83a76b3ae7719925ede8470069a6
>=20
> I don't know if the problem is because of the above commit but coreutils fa=
ils to build. It appears to be not finding aclocal-1.16
>=20
> It built fine yesterday so the problem must be one of the updates that was =
in the git pull I did today.

This is correct, but not a problem of the build system, but the package:

  https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D3e9871d20728c=
5b25ffbee4de38391c57096ae48

I dropped the patch that caused it to re-run autoconf. I don=E2=80=99t think =
we need this one.

-Michael

> Regards,
>=20
> Adolf.
>=20
>> For me it does.
>>=20
>>> It works for me on Ubuntu 22.04 LTS with kernel 5.15.
>> Here:
>> Ubuntu 22.04 LTS / 6.8.0-40-generic
>>=20
>> I tested 'make.sh' with all important parameters (clean, downloadsrc,
>> gettoolchain) - right now a 'next'-build is running and looking good -
>> I'll report when its ready. ;-)
>>=20
>> Best
>> Matthias
>>=20
>>> There is also another fix to support kernels without time namespaces (< 5=
.6). However, I am not sure if the built itself runs through on this and does=
 not require anything more recent:
>>>=20
>>>   https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3Dfaccfa707=
54fabaed56c9147ace4d509f7d2317c
>>>=20
>>> -Michael
>>>=20
>>>> On 27 Aug 2024, at 20:03, / / <siosios1(a)hotmail.com> wrote:
>>>>=20
>>>> I can concur that moving the line to where Matthias put it does fix the =
issues on my machines with downloading and building, it also takes care of th=
e error ->  mount: /git/ipfire-2.x/build_x86_64/proc: mount point does not ex=
ist from what I am seeing.
>>>>=20
>>>> # If unshare is asked to terminate, terminate all child processes
>>>>   "--kill-child"
>>>>  )
>>>>=20
>>>> mount --bind ${BUILD_DIR}/proc ${BUILD_DIR}/proc
>>>>=20
>>>> fi
>>>>=20
>>>> while [ $# -gt 0 ]; do
>>>>=20
>>>> one thing I don't see is the mount when i check the output of mount or t=
he output of findmnt -o+PROPAGATION


--===============7332124356995536131==--