From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Feedback on drop-hostile graph changes for bug#12981 Date: Sat, 10 Feb 2024 18:42:59 +0100 Message-ID: <960d6901-7ced-42ef-9f59-779dcda948e8@ipfire.org> In-Reply-To: <3e98e120-8dae-49db-9da6-56801ea60e9e@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8106902068281598583==" List-Id: --===============8106902068281598583== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 10/02/2024 18:08, Adolf Belka wrote: > Hi Michael, > > On 10/02/2024 15:22, Adolf Belka wrote: >> Hi Jon and Michael, >> >> On 10/02/2024 15:09, jon wrote: >>> Keep in mind there is a fcron for old RRDs (over 1 year old): >>> >>> # Cleanup the collectd RRD (graphs) >>> %weekly * * /bin/find /var/log/rrd -mtime +365 -type f -name '*.rrd' -del= ete -o -type d -empty -delete >> The problem here is that we are changing the Hostile data from DROP_HOSTIL= E into DROP_HOSTILE_IN & DROP_HOSTILE_OUT but we want to keep the history of = DROP_HOSTILE and in a fresh install it is only creating the DROP_HOSTILE_IN a= nd DROP_HOSTILE_OUT directories and the graph is also looking if there is any= data historically from the DROP_HOSTILE data. >>> >>> >>>> On Feb 10, 2024, at 7:14 AM, Adolf Belka > wrote: >>>> >>>> Hi Michael, >>>> >>>> Sorry for delay in feedback. >>>> >>>> I tried out the drop-hostile changes with both an update from CU182 to C= U184 and a fresh install of CU184 and had an error message showing with the g= raph in both cases. >>>> >>>> When I did the update from CU182 to CU184 the error message >>>> >>>> /var/log/rrd/collectd/localhost/iptables-filter-HOSTILE_DROP_IN/ipt_byte= s-DROP_HOSTILE.rrd >>>> >>>> was not present. >>>> >>>> See the screenshot attachment. >>>> >>>> Checking the directories there was only the iptables-filter-HOSTILE_DROP= directory and not the iptables-filter-HOSTILE_DROP_IN or iptables-filter-HOS= TILE_DROP_OUT directories. >>>> >>>> Maybe something needs to be done in the update.sh script to create the n= ew directories. I am not sure what though. >>>> >>>> >>>> When I did a fresh install from CU184 it was the other way round. >>>> >>>> /var/log/rrd/collectd/localhost/iptables-filter-HOSTILE_DROP/ipt_bytes-D= ROP_HOSTILE.rrd >>>> >>>> was not present. >>>> >>>> Checking the directories there were the iptables-filter-HOSTILE_DROP_IN = and iptables-filter-HOSTILE_DROP_OUT directories but not the iptables-filter-= HOSTILE_DROP directory. >>>> >>>> For a fresh install then there will be no history with the old naming so= here I would think we need to create the old directory name as standard for = everyone but it will just not have any data. If the user does a restore of an= old backup then that HOSTILE_DROP data would become available. >> >> I think I might have found out what has caused this. In my original patch = set I changed collectd.conf to only chain the filters for the IN and OUT and = I removed the Chain filter HOSTILE_DROP DROP_HOSTILE entry in the plugin ipta= bles section. >> >> As we are continuing to use the HOSTILE_DROP for the history I have added = that old line back into collectd.conf and am running a build and will test ou= t that fresh install to see if it solves the problem for that particular issu= e. >> > Looks like I don't understand the whole collectd/rrd/graphs thing enough. > > Adding that line back into the collectd.conf file did not cause the iptable= s-filter-HOSTILE_DROP directory to be created. > > I have looked through all the code changes done and I can't understand why = this is occurring let alone how to fix it. > > I still don't understand why it does not work but the code change you did with https://git.ipfire.org/?p=3Dpeople/ms/ipfire-2.x.git;a=3Dblobdiff;f=3Dconfig/= cfgroot/graphs.pl;h=3Da23e49c98093ff435b7b929df93f0a4abfe86ac8;hp=3Df527447b5= 310bf6d7309184dda46842b06e713d1;hb=3Da6e4c650a7303dfc7612ee806122a7cfb6cc2632= ;hpb=3D0ad5ffaff8443ff32a996c8f3854fcf90d6dc26c should deal with the HOSTILE_DROP directory not being present for a fresh ins= tall. The CDEF command you created "CDEF:hostile=3Dhostilelegacy,UN,hostilein,hostileout,+,hostilelegacy,IF", should end up replacing hostilelegacy,UN with 1 because hostilelegacy should = be Unknown due to the directory not existing. Then the IF statement takes hos= tilein + hostileout if hostilelegacy is Unknown or takes hostilelegacy if hos= tilelegacy is valid data. So I have been able to follow the RPN CDEF command (I struggle with RPN) afte= r a lot of reading and the command should be doing what you intended it to do= but it doesn't seem to be and I haven't been able to figure out why. Regards, Adolf. > Regards, > > Adolf. > >> Regards, >> Adolf. >>>> >>>> >>>> On the fresh install of CU148 I did a restore of a backup from CU182 and= then the graph worked as all three directories then were present. >>>> >>>> >>>> Regards, >>>> >>>> Adolf. >>>> >>> --===============8106902068281598583==--