From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] fmt: Convert from build only to run time also for mpd
Date: Thu, 11 Aug 2022 18:28:35 +0000 [thread overview]
Message-ID: <9628713e-8bc3-27d8-e479-d3e2a6a428fe@ipfire.org> (raw)
In-Reply-To: <20220811122921.3499697-2-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> - libfmt required in run time by mpd
> - mpd changelog specifically said fmt was a build only dependency
> - Bug#12909 flagged up that fmt was also a run time dependency for mpd
>
> Fixes: Bug#12909
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/rootfiles/{common => packages}/fmt | 4 ++--
> lfs/fmt | 7 +++++++
> 2 files changed, 9 insertions(+), 2 deletions(-)
> rename config/rootfiles/{common => packages}/fmt (92%)
>
> diff --git a/config/rootfiles/common/fmt b/config/rootfiles/packages/fmt
> similarity index 92%
> rename from config/rootfiles/common/fmt
> rename to config/rootfiles/packages/fmt
> index d9067f14a..ab97316a2 100644
> --- a/config/rootfiles/common/fmt
> +++ b/config/rootfiles/packages/fmt
> @@ -18,6 +18,6 @@
> #usr/lib/cmake/fmt/fmt-targets-release.cmake
> #usr/lib/cmake/fmt/fmt-targets.cmake
> #usr/lib/libfmt.so
> -#usr/lib/libfmt.so.8
> -#usr/lib/libfmt.so.8.1.1
> +usr/lib/libfmt.so.8
> +usr/lib/libfmt.so.8.1.1
> #usr/lib/pkgconfig/fmt.pc
> diff --git a/lfs/fmt b/lfs/fmt
> index 754de03b1..9f36e4942 100644
> --- a/lfs/fmt
> +++ b/lfs/fmt
> @@ -24,6 +24,8 @@
>
> include Config
>
> +SUMMARY = Open-source formatting library for C++
> +
> VER = 8.1.1
>
> THISAPP = fmt-$(VER)
> @@ -31,6 +33,11 @@ DL_FILE = $(THISAPP).tar.gz
> DL_FROM = $(URL_IPFIRE)
> DIR_APP = $(DIR_SRC)/$(THISAPP)
> TARGET = $(DIR_INFO)/$(THISAPP)
> +PROG = fmt
> +PAK_VER = 1
> +SUP_ARCH = aarch64 armv6l x86_64
> +
> +DEPS =
>
> ###############################################################################
> # Top-level Rules
next prev parent reply other threads:[~2022-08-11 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 12:29 [PATCH 1/2] mpd: Add fmt as a run time dependency Adolf Belka
2022-08-11 12:29 ` [PATCH 2/2] fmt: Convert from build only to run time also for mpd Adolf Belka
2022-08-11 18:28 ` Peter Müller [this message]
2022-08-11 18:28 ` [PATCH 1/2] mpd: Add fmt as a run time dependency Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9628713e-8bc3-27d8-e479-d3e2a6a428fe@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox