From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] Added i586/386 support for GO language required for
 node_exporter.
Date: Thu, 06 May 2021 22:26:46 +0200
Message-ID: <96ac7a19-8221-ca7c-a7db-3d7a14101bfe@ipfire.org>
In-Reply-To: <20210506194616.2972714-2-holger.sunke@posteo.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7035998992172413501=="
List-Id: <development.lists.ipfire.org>

--===============7035998992172413501==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Holger,

On 06/05/2021 21:46, Holger Sunke wrote:
> ---
>   lfs/Config | 4 ++++
>   lfs/go     | 6 +++---
>   2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/lfs/Config b/lfs/Config
> index eadbbc408..4d0f2f00b 100644
> --- a/lfs/Config
> +++ b/lfs/Config
> @@ -138,6 +138,10 @@ ifeq "$(BUILD_ARCH)" "aarch64"
>   	GOARCH =3D arm64
>   endif
>  =20
> +ifeq "$(BUILD_ARCH)" "i586"
> +	GOARCH =3D 386
> +endif
> +

A question I would have here is if creating this package in i586 architecture=
 makes sense when in 7 months the i586 version of IPFire will have reached En=
d Of Life and will no longer be updated.

Regards,

Adolf

>   #########################################################################=
######
>   # Common Macro Definitions
>   #########################################################################=
######
> diff --git a/lfs/go b/lfs/go
> index 6ebb37080..97effcb84 100644
> --- a/lfs/go
> +++ b/lfs/go
> @@ -28,10 +28,9 @@ VER        =3D 1.15.4
>  =20
>   THISAPP    =3D go-$(VER)
>   DL_FILE    =3D go$(VER).$(GOOS)-$(GOARCH).tar.gz
> -DL_FROM    =3D $(URL_IPFIRE)
> +DL_FROM    =3D https://golang.org/dl/
>   DIR_APP    =3D $(DIR_SRC)/go
>   TARGET     =3D $(DIR_INFO)/$(THISAPP)
> -SUP_ARCH   =3D x86_64
>  =20
>   #########################################################################=
######
>   # Top-level Rules
> @@ -41,7 +40,8 @@ objects =3D $(DL_FILE)
>  =20
>   $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>  =20
> -$(DL_FILE)_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
> +go$(VER).$(GOOS)-amd64.tar.gz_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
> +go$(VER).$(GOOS)-386.tar.gz_MD5 =3D 8d1c3539c88710273f61b0c810b7448c
>  =20
>   install : $(TARGET)
>  =20

--===============7035998992172413501==--